All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
	Evgeniy Polyakov <zbr@ioremap.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	Adam Ford <aford173@gmail.com>, "Andrew F . Davis" <afd@ti.com>,
	Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCHv3] w1: omap-hdq: Simplify driver with PM runtime autosuspend
Date: Tue, 21 Apr 2020 11:02:20 -0700	[thread overview]
Message-ID: <20200421180220.GB37466@atomide.com> (raw)
In-Reply-To: <20200421085336.32cf8ffe@aktux>

* Andreas Kemnade <andreas@kemnade.info> [200421 06:54]:
> On Mon, 20 Apr 2020 23:11:18 +0200
> "H. Nikolaus Schaller" <hns@goldelico.com> wrote:
> > The only maybe important observation was when I disabled all
> > kernel modules except *hdq*.ko and *bq27*.ko. Then I did only
> > get an emergency shell so that it is quite similar to the
> > scenario Andreas has tested. With this setup it did work.
> > 
> So I guess without idling uarts?
> 
> > I then tried to reenable other kernel modules but the result
> > wasn't convincing that it gives a reliable result.
> > 
> > So I have still no clear indication when the problem occurs and
> > when not.
> > 
> Hmm, last summer I had problems even without that patch reading
> temperature while doing umts transfers. Maybe there are some
> connections,
> maybe not. For that scenario we might have emc issues, thermal problems
> or a real kernel problem.

I have confimed here that logicpd torpedo devkit with battery
works just fine while entering off mode during idle. I can see
the temperature just fine with:

# cat /sys/class/power_supply/bq27000-battery/uevent
POWER_SUPPLY_NAME=bq27000-battery
POWER_SUPPLY_STATUS=Charging
POWER_SUPPLY_PRESENT=1
POWER_SUPPLY_VOLTAGE_NOW=3829000
POWER_SUPPLY_CURRENT_NOW=-592084
POWER_SUPPLY_CAPACITY_LEVEL=Normal
POWER_SUPPLY_TEMP=306
POWER_SUPPLY_TECHNOLOGY=Li-ion
POWER_SUPPLY_CHARGE_FULL_DESIGN=2056320
POWER_SUPPLY_CYCLE_COUNT=0
POWER_SUPPLY_POWER_AVG=0
POWER_SUPPLY_MANUFACTURER=Texas Instruments

This is 37xx though, maybe you have 35xx and there's some errata
that we're not handling?

I'm only seeing "2.7. HDQTM/1-Wire® Communication Constraints"
for external pull-up resitor in 34xx errata at [0].

I wonder if wrong external pull could cause flakyeness after
enabling the hdq module?

If nothing else helps, you could try to block idle for hdq
module, but I have a feeling that's a workaround for something
else.

Regards,

Tony

[0] https://www.ti.com/pdfs/wtbu/SWPZ009A_OMAP4430_Errata_Public_vA.pdf


  reply	other threads:[~2020-04-21 18:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  0:40 [PATCHv3] w1: omap-hdq: Simplify driver with PM runtime autosuspend Tony Lindgren
2020-04-16 15:02 ` H. Nikolaus Schaller
2020-04-16 18:46   ` Tony Lindgren
2020-04-16 20:04     ` Andreas Kemnade
2020-04-16 20:33       ` Tony Lindgren
2020-04-17 14:21         ` H. Nikolaus Schaller
2020-04-17 14:22     ` H. Nikolaus Schaller
2020-04-17 14:43       ` Andreas Kemnade
2020-04-17 14:52         ` H. Nikolaus Schaller
2020-04-17 15:07           ` Tony Lindgren
2020-04-17 15:14             ` Tony Lindgren
2020-04-17 15:36               ` Andreas Kemnade
2020-04-17 21:03             ` H. Nikolaus Schaller
2020-04-20 15:08               ` Tony Lindgren
2020-04-20 21:11                 ` H. Nikolaus Schaller
2020-04-21  6:53                   ` Andreas Kemnade
2020-04-21 18:02                     ` Tony Lindgren [this message]
2020-04-21 18:13                       ` H. Nikolaus Schaller
2020-04-21 18:20                         ` Tony Lindgren
2020-04-21 18:24                           ` Andreas Kemnade
2020-04-21 20:40                           ` H. Nikolaus Schaller
2020-04-22 10:04                             ` Andreas Kemnade
2020-04-22 16:06                               ` H. Nikolaus Schaller
     [not found]                                 ` <A2AC3E81-49B2-4CF2-A7CF-6075AEB1B72D@goldelico.com>
2020-04-25 10:29                                   ` H. Nikolaus Schaller
2020-04-25 10:37                                     ` H. Nikolaus Schaller
2020-04-29 21:34                                       ` H. Nikolaus Schaller
2020-04-29 21:38                                         ` Tony Lindgren
2020-05-09 11:47                                           ` H. Nikolaus Schaller
2020-05-09 13:59                                             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421180220.GB37466@atomide.com \
    --to=tony@atomide.com \
    --cc=afd@ti.com \
    --cc=aford173@gmail.com \
    --cc=andreas@kemnade.info \
    --cc=gregkh@linuxfoundation.org \
    --cc=hns@goldelico.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=vigneshr@ti.com \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.