All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Andreas Kemnade <andreas@kemnade.info>,
	Evgeniy Polyakov <zbr@ioremap.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	Adam Ford <aford173@gmail.com>, "Andrew F . Davis" <afd@ti.com>,
	Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCHv3] w1: omap-hdq: Simplify driver with PM runtime autosuspend
Date: Wed, 29 Apr 2020 14:38:17 -0700	[thread overview]
Message-ID: <20200429213817.GU37466@atomide.com> (raw)
In-Reply-To: <891CBD28-3F91-493D-AD80-6575608846A4@goldelico.com>

* H. Nikolaus Schaller <hns@goldelico.com> [200429 21:35]:
> I have reworked the way the spinlocks, setting and resetting
> of the hdq_irqstatus bits are done and now it works right from
> start of boot. Without any timeouts or delays.
> 
> I am not exactly sure what went wrong, but it seems as if
> the read is already done when the write interrupt status
> bit is processed. Then, the old logic did wipe out both
> bits by hdq_reset_irqstatus() and the read code did timeout
> because it did not notice that the data had already been
> available. This may depend on other system activities so
> that it can explain why other tests didn't reveal it.
> 
> omap_hdq_runtime_resume() and omap_hdq_runtime_suspend()
> also behave fine.
> 
> Before I can post something I need to clean up my hacks
> and add similar fixes to omap_hdq_break() and omap_w1_triplet()
> where I hope that I don't break those...

OK good to hear you were able to figure out what is
going on here.

Regards,

Tony

  reply	other threads:[~2020-04-29 21:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  0:40 [PATCHv3] w1: omap-hdq: Simplify driver with PM runtime autosuspend Tony Lindgren
2020-04-16 15:02 ` H. Nikolaus Schaller
2020-04-16 18:46   ` Tony Lindgren
2020-04-16 20:04     ` Andreas Kemnade
2020-04-16 20:33       ` Tony Lindgren
2020-04-17 14:21         ` H. Nikolaus Schaller
2020-04-17 14:22     ` H. Nikolaus Schaller
2020-04-17 14:43       ` Andreas Kemnade
2020-04-17 14:52         ` H. Nikolaus Schaller
2020-04-17 15:07           ` Tony Lindgren
2020-04-17 15:14             ` Tony Lindgren
2020-04-17 15:36               ` Andreas Kemnade
2020-04-17 21:03             ` H. Nikolaus Schaller
2020-04-20 15:08               ` Tony Lindgren
2020-04-20 21:11                 ` H. Nikolaus Schaller
2020-04-21  6:53                   ` Andreas Kemnade
2020-04-21 18:02                     ` Tony Lindgren
2020-04-21 18:13                       ` H. Nikolaus Schaller
2020-04-21 18:20                         ` Tony Lindgren
2020-04-21 18:24                           ` Andreas Kemnade
2020-04-21 20:40                           ` H. Nikolaus Schaller
2020-04-22 10:04                             ` Andreas Kemnade
2020-04-22 16:06                               ` H. Nikolaus Schaller
     [not found]                                 ` <A2AC3E81-49B2-4CF2-A7CF-6075AEB1B72D@goldelico.com>
2020-04-25 10:29                                   ` H. Nikolaus Schaller
2020-04-25 10:37                                     ` H. Nikolaus Schaller
2020-04-29 21:34                                       ` H. Nikolaus Schaller
2020-04-29 21:38                                         ` Tony Lindgren [this message]
2020-05-09 11:47                                           ` H. Nikolaus Schaller
2020-05-09 13:59                                             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429213817.GU37466@atomide.com \
    --to=tony@atomide.com \
    --cc=afd@ti.com \
    --cc=aford173@gmail.com \
    --cc=andreas@kemnade.info \
    --cc=gregkh@linuxfoundation.org \
    --cc=hns@goldelico.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=vigneshr@ti.com \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.