From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net,
Jakov Petrina <jakov.petrina@sartura.hr>,
gregory.clement@bootlin.com, linux-kernel@vger.kernel.org,
vladimir.vid@sartura.hr, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x
Date: Wed, 22 Apr 2020 16:37:13 +0100 [thread overview]
Message-ID: <20200422153712.GQ25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200422152439.GG974925@lunn.ch>
On Wed, Apr 22, 2020 at 05:24:39PM +0200, Andrew Lunn wrote:
> On Wed, Apr 22, 2020 at 05:09:15PM +0200, Jakov Petrina wrote:
> > This resolves issues with certain SPF modules.
>
> Hi Jakov
>
> Please could you explain this some more. PHYLINK should be setting the
> mode appropriately, based on the capabilities of the SFP module. Is
> the real problem that the SFP module is indicating the wrong baud
> rate?
The issue is way more complex than that, and this is just a sticky
plaster over the problem, and I'm really unconvinced that the issue
has really been solved.
There are some GPON modules that support 2.5G and 1G, try to guess
the speed of the host somehow. How that happens is not really
known, and I never got the impression that even Scott at Telus worked
it out - he just played around until he got stuff to work, and this
patch is the result.
This patch just works around the problem because it _may_ cause the
interface to be at 2.5G at boot, but it won't be at 2.5G after a
1G module has previously been plugged in, and one of these GPON
modules is subsequently inserted.
So, this is just a bodge that works in one particular situation for a
problem with modules playing their own games.
So, it has to be a NAK.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jakov Petrina <jakov.petrina@sartura.hr>,
jason@lakedaemon.net, devicetree@vger.kernel.org,
gregory.clement@bootlin.com, linux-kernel@vger.kernel.org,
vladimir.vid@sartura.hr, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x
Date: Wed, 22 Apr 2020 16:37:13 +0100 [thread overview]
Message-ID: <20200422153712.GQ25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200422152439.GG974925@lunn.ch>
On Wed, Apr 22, 2020 at 05:24:39PM +0200, Andrew Lunn wrote:
> On Wed, Apr 22, 2020 at 05:09:15PM +0200, Jakov Petrina wrote:
> > This resolves issues with certain SPF modules.
>
> Hi Jakov
>
> Please could you explain this some more. PHYLINK should be setting the
> mode appropriately, based on the capabilities of the SFP module. Is
> the real problem that the SFP module is indicating the wrong baud
> rate?
The issue is way more complex than that, and this is just a sticky
plaster over the problem, and I'm really unconvinced that the issue
has really been solved.
There are some GPON modules that support 2.5G and 1G, try to guess
the speed of the host somehow. How that happens is not really
known, and I never got the impression that even Scott at Telus worked
it out - he just played around until he got stuff to work, and this
patch is the result.
This patch just works around the problem because it _may_ cause the
interface to be at 2.5G at boot, but it won't be at 2.5G after a
1G module has previously been plugged in, and one of these GPON
modules is subsequently inserted.
So, this is just a bodge that works in one particular situation for a
problem with modules playing their own games.
So, it has to be a NAK.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
next prev parent reply other threads:[~2020-04-22 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 15:09 [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x Jakov Petrina
2020-04-22 15:09 ` Jakov Petrina
2020-04-22 15:24 ` Andrew Lunn
2020-04-22 15:24 ` Andrew Lunn
2020-04-22 15:37 ` Russell King - ARM Linux admin [this message]
2020-04-22 15:37 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422153712.GQ25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jakov.petrina@sartura.hr \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=vladimir.vid@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.