[PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x
@ 2020-04-22 15:09 ` Jakov Petrina
  0 siblings, 0 replies; 6+ messages in thread
From: Jakov Petrina @ 2020-04-22 15:09 UTC (permalink / raw)
  To: jason
  Cc: devicetree, Jakov Petrina, gregory.clement, linux-kernel,
	vladimir.vid, robh+dt, linux-arm-kernel, sebastian.hesselbarth

This resolves issues with certain SPF modules.

Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
Signed-off-by: Vladimir Vid <vladimir.vid@sartura.hr>
---
 arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
index 7eb6c1796cef..b6e2a9c68b2a 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
@@ -144,7 +144,7 @@ lm75@49 {
 };
 
 &eth0 {
-	phy-mode = "sgmii";
+	phy-mode = "2500base-x";
 	status = "okay";
 	managed = "in-band-status";
 	phys = <&comphy1 0>;
@@ -152,7 +152,7 @@ &eth0 {
 };
 
 &eth1 {
-	phy-mode = "sgmii";
+	phy-mode = "2500base-x";
 	status = "okay";
 	managed = "in-band-status";
 	phys = <&comphy0 1>;
-- 
2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x
@ 2020-04-22 15:09 ` Jakov Petrina
  0 siblings, 0 replies; 6+ messages in thread
From: Jakov Petrina @ 2020-04-22 15:09 UTC (permalink / raw)
  To: jason
  Cc: gregory.clement, sebastian.hesselbarth, vladimir.vid, robh+dt,
	linux-arm-kernel, devicetree, linux-kernel, Jakov Petrina

This resolves issues with certain SPF modules.

Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
Signed-off-by: Vladimir Vid <vladimir.vid@sartura.hr>
---
 arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
index 7eb6c1796cef..b6e2a9c68b2a 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
@@ -144,7 +144,7 @@ lm75@49 {
 };
 
 &eth0 {
-	phy-mode = "sgmii";
+	phy-mode = "2500base-x";
 	status = "okay";
 	managed = "in-band-status";
 	phys = <&comphy1 0>;
@@ -152,7 +152,7 @@ &eth0 {
 };
 
 &eth1 {
-	phy-mode = "sgmii";
+	phy-mode = "2500base-x";
 	status = "okay";
 	managed = "in-band-status";
 	phys = <&comphy0 1>;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x
  2020-04-22 15:09 ` Jakov Petrina
@ 2020-04-22 15:24   ` Andrew Lunn
  -1 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2020-04-22 15:24 UTC (permalink / raw)
  To: Jakov Petrina
  Cc: devicetree, jason, gregory.clement, linux-kernel, vladimir.vid,
	Russell King, robh+dt, linux-arm-kernel, sebastian.hesselbarth

On Wed, Apr 22, 2020 at 05:09:15PM +0200, Jakov Petrina wrote:
> This resolves issues with certain SPF modules.

Hi Jakov

Please could you explain this some more. PHYLINK should be setting the
mode appropriately, based on the capabilities of the SFP module. Is
the real problem that the SFP module is indicating the wrong baud
rate?

	Andrew

> 
> Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
> Signed-off-by: Vladimir Vid <vladimir.vid@sartura.hr>
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> index 7eb6c1796cef..b6e2a9c68b2a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> @@ -144,7 +144,7 @@ lm75@49 {
>  };
>  
>  &eth0 {
> -	phy-mode = "sgmii";
> +	phy-mode = "2500base-x";
>  	status = "okay";
>  	managed = "in-band-status";
>  	phys = <&comphy1 0>;
> @@ -152,7 +152,7 @@ &eth0 {
>  };
>  
>  &eth1 {
> -	phy-mode = "sgmii";
> +	phy-mode = "2500base-x";
>  	status = "okay";
>  	managed = "in-band-status";
>  	phys = <&comphy0 1>;
> -- 
> 2.24.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x
@ 2020-04-22 15:24   ` Andrew Lunn
  0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2020-04-22 15:24 UTC (permalink / raw)
  To: Jakov Petrina
  Cc: jason, devicetree, gregory.clement, linux-kernel, vladimir.vid,
	robh+dt, linux-arm-kernel, sebastian.hesselbarth, Russell King

On Wed, Apr 22, 2020 at 05:09:15PM +0200, Jakov Petrina wrote:
> This resolves issues with certain SPF modules.

Hi Jakov

Please could you explain this some more. PHYLINK should be setting the
mode appropriately, based on the capabilities of the SFP module. Is
the real problem that the SFP module is indicating the wrong baud
rate?

	Andrew

> 
> Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
> Signed-off-by: Vladimir Vid <vladimir.vid@sartura.hr>
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> index 7eb6c1796cef..b6e2a9c68b2a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> @@ -144,7 +144,7 @@ lm75@49 {
>  };
>  
>  &eth0 {
> -	phy-mode = "sgmii";
> +	phy-mode = "2500base-x";
>  	status = "okay";
>  	managed = "in-band-status";
>  	phys = <&comphy1 0>;
> @@ -152,7 +152,7 @@ &eth0 {
>  };
>  
>  &eth1 {
> -	phy-mode = "sgmii";
> +	phy-mode = "2500base-x";
>  	status = "okay";
>  	managed = "in-band-status";
>  	phys = <&comphy0 1>;
> -- 
> 2.24.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x
  2020-04-22 15:24   ` Andrew Lunn
@ 2020-04-22 15:37     ` Russell King - ARM Linux admin
  -1 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux admin @ 2020-04-22 15:37 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: devicetree, jason, Jakov Petrina, gregory.clement, linux-kernel,
	vladimir.vid, robh+dt, linux-arm-kernel, sebastian.hesselbarth

On Wed, Apr 22, 2020 at 05:24:39PM +0200, Andrew Lunn wrote:
> On Wed, Apr 22, 2020 at 05:09:15PM +0200, Jakov Petrina wrote:
> > This resolves issues with certain SPF modules.
> 
> Hi Jakov
> 
> Please could you explain this some more. PHYLINK should be setting the
> mode appropriately, based on the capabilities of the SFP module. Is
> the real problem that the SFP module is indicating the wrong baud
> rate?

The issue is way more complex than that, and this is just a sticky
plaster over the problem, and I'm really unconvinced that the issue
has really been solved.

There are some GPON modules that support 2.5G and 1G, try to guess
the speed of the host somehow.  How that happens is not really
known, and I never got the impression that even Scott at Telus worked
it out - he just played around until he got stuff to work, and this
patch is the result.

This patch just works around the problem because it _may_ cause the
interface to be at 2.5G at boot, but it won't be at 2.5G after a
1G module has previously been plugged in, and one of these GPON
modules is subsequently inserted.

So, this is just a bodge that works in one particular situation for a
problem with modules playing their own games.

So, it has to be a NAK.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x
@ 2020-04-22 15:37     ` Russell King - ARM Linux admin
  0 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux admin @ 2020-04-22 15:37 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Jakov Petrina, jason, devicetree, gregory.clement, linux-kernel,
	vladimir.vid, robh+dt, linux-arm-kernel, sebastian.hesselbarth

On Wed, Apr 22, 2020 at 05:24:39PM +0200, Andrew Lunn wrote:
> On Wed, Apr 22, 2020 at 05:09:15PM +0200, Jakov Petrina wrote:
> > This resolves issues with certain SPF modules.
> 
> Hi Jakov
> 
> Please could you explain this some more. PHYLINK should be setting the
> mode appropriately, based on the capabilities of the SFP module. Is
> the real problem that the SFP module is indicating the wrong baud
> rate?

The issue is way more complex than that, and this is just a sticky
plaster over the problem, and I'm really unconvinced that the issue
has really been solved.

There are some GPON modules that support 2.5G and 1G, try to guess
the speed of the host somehow.  How that happens is not really
known, and I never got the impression that even Scott at Telus worked
it out - he just played around until he got stuff to work, and this
patch is the result.

This patch just works around the problem because it _may_ cause the
interface to be at 2.5G at boot, but it won't be at 2.5G after a
1G module has previously been plugged in, and one of these GPON
modules is subsequently inserted.

So, this is just a bodge that works in one particular situation for a
problem with modules playing their own games.

So, it has to be a NAK.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-04-22 15:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-22 15:09 [PATCH] arm: dts: uDPU: switch PHY operation mode to 2500base-x Jakov Petrina
2020-04-22 15:09 ` Jakov Petrina
2020-04-22 15:24 ` Andrew Lunn
2020-04-22 15:24   ` Andrew Lunn
2020-04-22 15:37   ` Russell King - ARM Linux admin
2020-04-22 15:37     ` Russell King - ARM Linux admin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.