From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: devicetree@vger.kernel.org, vigneshr@ti.com, richard@nod.at,
Yifeng Zhao <yifeng.zhao@rock-chips.com>,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
linux-mtd@lists.infradead.org, heiko@sntech.de
Subject: Re: [PATCH v5 1/7] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller
Date: Wed, 29 Apr 2020 11:13:14 +0200 [thread overview]
Message-ID: <20200429111314.5f15d72b@xps13> (raw)
In-Reply-To: <4a83e5d2-90cc-1db7-cdfd-47b7ceb4fcef@gmail.com>
Hi Johan,
Johan Jonker <jbx6244@gmail.com> wrote on Wed, 29 Apr 2020 10:53:30
+0200:
> Hi Yifeng,
>
> > On Sun, Apr 26, 2020 at 06:02:44PM +0800, Yifeng Zhao wrote:
> >> Documentation support for Rockchip RK3xxx NAND flash controllers
> >>
> >> Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
> >> ---
> >>
> >> Changes in v5:
> >> - Fix some wrong define
> >> - Add boot-medium define
> >> - Remove some compatible define
> >>
> >> Changes in v4:
> >> - The compatible define with rkxx_nfc
> >> - Add assigned-clocks
> >> - Fix some wrong define
> >>
> >> Changes in v3:
> >> - Change the title for the dt-bindings
> >>
> >> Changes in v2: None
> >>
> >> .../mtd/rockchip,nand-controller.yaml | 124 ++++++++++++++++++
> >> 1 file changed, 124 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
>
> The name of this file is based on Miquel's opinion, but the
> compatibility strings, (for which robh has given a 'reviewed by' tag) in
> version 4 don't fit with this format.
What do you mean? Is the file name restricted somehow? I just don't
want a compatible with just "nand" in it because this word is too vague
as it defines: a bus, a spec, a chip, people are also confusing it with
the controller and sometimes with the ECC engine too. "nfc" is okay
though.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Yifeng Zhao <yifeng.zhao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
richard-/L3Ra7n9ekc@public.gmane.org,
vigneshr-l0cyMroinI0@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v5 1/7] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller
Date: Wed, 29 Apr 2020 11:13:14 +0200 [thread overview]
Message-ID: <20200429111314.5f15d72b@xps13> (raw)
In-Reply-To: <4a83e5d2-90cc-1db7-cdfd-47b7ceb4fcef-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Johan,
Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote on Wed, 29 Apr 2020 10:53:30
+0200:
> Hi Yifeng,
>
> > On Sun, Apr 26, 2020 at 06:02:44PM +0800, Yifeng Zhao wrote:
> >> Documentation support for Rockchip RK3xxx NAND flash controllers
> >>
> >> Signed-off-by: Yifeng Zhao <yifeng.zhao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> >> ---
> >>
> >> Changes in v5:
> >> - Fix some wrong define
> >> - Add boot-medium define
> >> - Remove some compatible define
> >>
> >> Changes in v4:
> >> - The compatible define with rkxx_nfc
> >> - Add assigned-clocks
> >> - Fix some wrong define
> >>
> >> Changes in v3:
> >> - Change the title for the dt-bindings
> >>
> >> Changes in v2: None
> >>
> >> .../mtd/rockchip,nand-controller.yaml | 124 ++++++++++++++++++
> >> 1 file changed, 124 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
>
> The name of this file is based on Miquel's opinion, but the
> compatibility strings, (for which robh has given a 'reviewed by' tag) in
> version 4 don't fit with this format.
What do you mean? Is the file name restricted somehow? I just don't
want a compatible with just "nand" in it because this word is too vague
as it defines: a bus, a spec, a chip, people are also confusing it with
the controller and sometimes with the ECC engine too. "nfc" is okay
though.
Thanks,
Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: Yifeng Zhao <yifeng.zhao@rock-chips.com>,
richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
heiko@sntech.de, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v5 1/7] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller
Date: Wed, 29 Apr 2020 11:13:14 +0200 [thread overview]
Message-ID: <20200429111314.5f15d72b@xps13> (raw)
In-Reply-To: <4a83e5d2-90cc-1db7-cdfd-47b7ceb4fcef@gmail.com>
Hi Johan,
Johan Jonker <jbx6244@gmail.com> wrote on Wed, 29 Apr 2020 10:53:30
+0200:
> Hi Yifeng,
>
> > On Sun, Apr 26, 2020 at 06:02:44PM +0800, Yifeng Zhao wrote:
> >> Documentation support for Rockchip RK3xxx NAND flash controllers
> >>
> >> Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
> >> ---
> >>
> >> Changes in v5:
> >> - Fix some wrong define
> >> - Add boot-medium define
> >> - Remove some compatible define
> >>
> >> Changes in v4:
> >> - The compatible define with rkxx_nfc
> >> - Add assigned-clocks
> >> - Fix some wrong define
> >>
> >> Changes in v3:
> >> - Change the title for the dt-bindings
> >>
> >> Changes in v2: None
> >>
> >> .../mtd/rockchip,nand-controller.yaml | 124 ++++++++++++++++++
> >> 1 file changed, 124 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml
>
> The name of this file is based on Miquel's opinion, but the
> compatibility strings, (for which robh has given a 'reviewed by' tag) in
> version 4 don't fit with this format.
What do you mean? Is the file name restricted somehow? I just don't
want a compatible with just "nand" in it because this word is too vague
as it defines: a bus, a spec, a chip, people are also confusing it with
the controller and sometimes with the ECC engine too. "nfc" is okay
though.
Thanks,
Miquèl
next prev parent reply other threads:[~2020-04-29 9:13 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 10:02 [PATCH v5 0/7] Add Rockchip NFC drivers for RK3308 and others Yifeng Zhao
2020-04-26 10:02 ` Yifeng Zhao
2020-04-26 10:02 ` Yifeng Zhao
2020-04-26 10:02 ` [PATCH v5 1/7] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Yifeng Zhao
2020-04-26 10:02 ` Yifeng Zhao
2020-04-26 10:02 ` Yifeng Zhao
2020-04-28 15:01 ` Rob Herring
2020-04-28 15:01 ` Rob Herring
2020-04-28 15:01 ` Rob Herring
2020-04-29 3:56 ` Re: [PATCH v5 1/7] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller【请注意，邮件由robherring2@gmail.com代发】 赵仪峰
2020-04-29 3:56 ` 赵仪峰
2020-04-29 8:53 ` [PATCH v5 1/7] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Johan Jonker
2020-04-29 8:53 ` Johan Jonker
2020-04-29 8:53 ` Johan Jonker
2020-04-29 9:13 ` Miquel Raynal [this message]
2020-04-29 9:13 ` Miquel Raynal
2020-04-29 9:13 ` Miquel Raynal
2020-04-29 9:28 ` Johan Jonker
2020-04-29 9:28 ` Johan Jonker
2020-04-29 9:28 ` Johan Jonker
2020-04-30 13:02 ` 赵仪峰
2020-04-30 13:02 ` 赵仪峰
2020-04-30 13:02 ` 赵仪峰
2020-05-01 11:47 ` Johan Jonker
2020-05-01 11:47 ` Johan Jonker
2020-05-01 11:47 ` Johan Jonker
2020-04-26 10:02 ` [PATCH v5 2/7] mtd: rawnand: rockchip: NFC drivers for RK3308, RK3188 and others Yifeng Zhao
2020-04-26 10:02 ` Yifeng Zhao
2020-04-26 15:59 ` Johan Jonker
2020-04-26 15:59 ` Johan Jonker
2020-04-26 15:59 ` Johan Jonker
2020-04-29 11:02 ` Re: [PATCH v5 2/7] mtd: rawnand: rockchip: NFC drivers for RK3308, RK3188 and others【请注意，邮件由linux-rockchip-bounces+yifeng.zhao=rock-chips.com@lists.infradead.org代发】 赵仪峰
2020-04-29 11:02 ` 赵仪峰
2020-04-29 15:55 ` [PATCH v5 2/7] mtd: rawnand: rockchip: NFC drivers for RK3308, RK3188 and others Johan Jonker
2020-04-29 15:55 ` Johan Jonker
2020-04-29 15:55 ` Johan Jonker
2020-04-29 17:04 ` Miquel Raynal
2020-04-29 17:04 ` Miquel Raynal
2020-04-29 17:04 ` Miquel Raynal
2020-04-26 10:02 ` [PATCH v5 3/7] MAINTAINERS: add maintainers to rockchip nfc Yifeng Zhao
2020-04-26 10:02 ` Yifeng Zhao
2020-04-26 10:02 ` Yifeng Zhao
2020-04-26 13:40 ` Johan Jonker
2020-04-26 13:40 ` Johan Jonker
2020-04-26 13:40 ` Johan Jonker
2020-04-26 10:02 ` [PATCH v5 4/7] arm64: dts: rockchip: Add nfc dts for RK3308 SOC Yifeng Zhao
2020-04-26 10:02 ` Yifeng Zhao
2020-04-26 10:02 ` Yifeng Zhao
2020-04-26 10:11 ` [PATCH v5 5/7] arm64: dts: rockchip: Add nfc dts for PX30 SOC Yifeng Zhao
2020-04-26 10:11 ` Yifeng Zhao
2020-04-26 10:11 ` Yifeng Zhao
2020-04-26 10:11 ` [PATCH v5 6/7] xarm: dts: rockchip: Add nfc dts for RV1108 SOC Yifeng Zhao
2020-04-26 10:11 ` Yifeng Zhao
2020-04-26 10:11 ` Yifeng Zhao
2020-04-26 10:11 ` [PATCH v5 7/7] arm: dts: rockchip: Add nfc dts for RK3066 and RK3188 SOC Yifeng Zhao
2020-04-26 10:11 ` Yifeng Zhao
2020-04-26 10:11 ` Yifeng Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429111314.5f15d72b@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.