From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Victor Lavaud <victor.lavaud@protonmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>
Subject: Re: Patch to fix missing Exec field in qemu.desktop
Date: Mon, 18 May 2020 10:49:18 +0100 [thread overview]
Message-ID: <20200518094918.GE1430944@redhat.com> (raw)
In-Reply-To: <zrVSyE1D2Xtxcr723wTf2sJRtM0IPuBRH0S-Gyx2XsvooDqbMYhqrK_aVk3AZM8RkjyOzYKWQH3VrnWDjwVUspDJHYUKXOyLZEZlvAzz6Ww=@protonmail.com>
On Sat, May 16, 2020 at 02:42:47PM +0000, Victor Lavaud via wrote:
>
>
>
> Sent with ProtonMail Secure Email.
>
> From 207a1a34accdc5b563d29484292829a4193c35f8 Mon Sep 17 00:00:00 2001
> From: Victor Lavaud <victor.lavaud@gmail.com>
> Date: Sat, 16 May 2020 16:33:00 +0200
> Subject: [PATCH] Fix missing Exec field in qemu.desktop
>
> Signed-off-by: Victor Lavaud <victor.lavaud@pm.me>
> ---
> ui/qemu.desktop | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ui/qemu.desktop b/ui/qemu.desktop
> index 20f09f56be..1b9f02a0cc 100644
> --- a/ui/qemu.desktop
> +++ b/ui/qemu.desktop
> @@ -6,3 +6,4 @@ Type=Application
> Terminal=false
> Keywords=Emulators;Virtualization;KVM;
> NoDisplay=true
> +Exec=qemu
There is no such binary, and we *intentionally* don't included any
'Exec' field, because it doesn't make sense. We consider the validation
tool that complains about missing 'Exec' field to be incorrect
https://bugs.launchpad.net/qemu/+bug/1868221
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Victor Lavaud <victor.lavaud@protonmail.com>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: Patch to fix missing Exec field in qemu.desktop
Date: Mon, 18 May 2020 10:49:18 +0100 [thread overview]
Message-ID: <20200518094918.GE1430944@redhat.com> (raw)
In-Reply-To: <zrVSyE1D2Xtxcr723wTf2sJRtM0IPuBRH0S-Gyx2XsvooDqbMYhqrK_aVk3AZM8RkjyOzYKWQH3VrnWDjwVUspDJHYUKXOyLZEZlvAzz6Ww=@protonmail.com>
On Sat, May 16, 2020 at 02:42:47PM +0000, Victor Lavaud via wrote:
>
>
>
> Sent with ProtonMail Secure Email.
>
> From 207a1a34accdc5b563d29484292829a4193c35f8 Mon Sep 17 00:00:00 2001
> From: Victor Lavaud <victor.lavaud@gmail.com>
> Date: Sat, 16 May 2020 16:33:00 +0200
> Subject: [PATCH] Fix missing Exec field in qemu.desktop
>
> Signed-off-by: Victor Lavaud <victor.lavaud@pm.me>
> ---
> ui/qemu.desktop | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ui/qemu.desktop b/ui/qemu.desktop
> index 20f09f56be..1b9f02a0cc 100644
> --- a/ui/qemu.desktop
> +++ b/ui/qemu.desktop
> @@ -6,3 +6,4 @@ Type=Application
> Terminal=false
> Keywords=Emulators;Virtualization;KVM;
> NoDisplay=true
> +Exec=qemu
There is no such binary, and we *intentionally* don't included any
'Exec' field, because it doesn't make sense. We consider the validation
tool that complains about missing 'Exec' field to be incorrect
https://bugs.launchpad.net/qemu/+bug/1868221
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-05-18 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 14:42 Patch to fix missing Exec field in qemu.desktop Victor Lavaud
2020-05-16 14:42 ` Victor Lavaud via
2020-05-18 9:49 ` Daniel P. Berrangé [this message]
2020-05-18 9:49 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518094918.GE1430944@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=victor.lavaud@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.