All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch to fix missing Exec field in qemu.desktop
@ 2020-05-16 14:42 ` Victor Lavaud via
  0 siblings, 0 replies; 4+ messages in thread
From: Victor Lavaud @ 2020-05-16 14:42 UTC (permalink / raw)
  To: qemu-devel@nongnu.org; +Cc: qemu-trivial@nongnu.org


[-- Attachment #1.1.1: Type: text/plain, Size: 44 bytes --]




Sent with ProtonMail Secure Email.


[-- Attachment #1.1.2.1: Type: text/html, Size: 308 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: fix-exec-field-in-qemu-desktop.patch --]
[-- Type: text/x-patch; filename="fix-exec-field-in-qemu-desktop.patch"; name="fix-exec-field-in-qemu-desktop.patch", Size: 578 bytes --]

From 207a1a34accdc5b563d29484292829a4193c35f8 Mon Sep 17 00:00:00 2001
From: Victor Lavaud <victor.lavaud@gmail.com>
Date: Sat, 16 May 2020 16:33:00 +0200
Subject: [PATCH] Fix missing Exec field in qemu.desktop

Signed-off-by: Victor Lavaud <victor.lavaud@pm.me>
---
 ui/qemu.desktop | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/qemu.desktop b/ui/qemu.desktop
index 20f09f56be..1b9f02a0cc 100644
--- a/ui/qemu.desktop
+++ b/ui/qemu.desktop
@@ -6,3 +6,4 @@ Type=Application
 Terminal=false
 Keywords=Emulators;Virtualization;KVM;
 NoDisplay=true
+Exec=qemu
-- 
2.26.2


[-- Attachment #1.3: publickey - victor.lavaud@protonmail.com - 0x54FBFBBD.asc --]
[-- Type: application/pgp-keys, Size: 1810 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 477 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Patch to fix missing Exec field in qemu.desktop
@ 2020-05-16 14:42 ` Victor Lavaud via
  0 siblings, 0 replies; 4+ messages in thread
From: Victor Lavaud via @ 2020-05-16 14:42 UTC (permalink / raw)
  To: qemu-devel@nongnu.org; +Cc: qemu-trivial@nongnu.org


[-- Attachment #1.1.1: Type: text/plain, Size: 44 bytes --]




Sent with ProtonMail Secure Email.


[-- Attachment #1.1.2.1: Type: text/html, Size: 308 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: fix-exec-field-in-qemu-desktop.patch --]
[-- Type: text/x-patch; filename="fix-exec-field-in-qemu-desktop.patch"; name="fix-exec-field-in-qemu-desktop.patch", Size: 578 bytes --]

From 207a1a34accdc5b563d29484292829a4193c35f8 Mon Sep 17 00:00:00 2001
From: Victor Lavaud <victor.lavaud@gmail.com>
Date: Sat, 16 May 2020 16:33:00 +0200
Subject: [PATCH] Fix missing Exec field in qemu.desktop

Signed-off-by: Victor Lavaud <victor.lavaud@pm.me>
---
 ui/qemu.desktop | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/qemu.desktop b/ui/qemu.desktop
index 20f09f56be..1b9f02a0cc 100644
--- a/ui/qemu.desktop
+++ b/ui/qemu.desktop
@@ -6,3 +6,4 @@ Type=Application
 Terminal=false
 Keywords=Emulators;Virtualization;KVM;
 NoDisplay=true
+Exec=qemu
-- 
2.26.2


[-- Attachment #1.3: publickey - victor.lavaud@protonmail.com - 0x54FBFBBD.asc --]
[-- Type: application/pgp-keys, Size: 1810 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 477 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: Patch to fix missing Exec field in qemu.desktop
  2020-05-16 14:42 ` Victor Lavaud via
@ 2020-05-18  9:49   ` Daniel P. Berrangé
  -1 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2020-05-18  9:49 UTC (permalink / raw)
  To: Victor Lavaud; +Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org

On Sat, May 16, 2020 at 02:42:47PM +0000, Victor Lavaud via wrote:
> 
> 
> 
> Sent with ProtonMail Secure Email.
> 

> From 207a1a34accdc5b563d29484292829a4193c35f8 Mon Sep 17 00:00:00 2001
> From: Victor Lavaud <victor.lavaud@gmail.com>
> Date: Sat, 16 May 2020 16:33:00 +0200
> Subject: [PATCH] Fix missing Exec field in qemu.desktop
> 
> Signed-off-by: Victor Lavaud <victor.lavaud@pm.me>
> ---
>  ui/qemu.desktop | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ui/qemu.desktop b/ui/qemu.desktop
> index 20f09f56be..1b9f02a0cc 100644
> --- a/ui/qemu.desktop
> +++ b/ui/qemu.desktop
> @@ -6,3 +6,4 @@ Type=Application
>  Terminal=false
>  Keywords=Emulators;Virtualization;KVM;
>  NoDisplay=true
> +Exec=qemu

There is no such binary, and we *intentionally* don't included any
'Exec' field, because it doesn't make sense. We consider the validation
tool that complains about missing 'Exec' field to be incorrect

   https://bugs.launchpad.net/qemu/+bug/1868221


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Patch to fix missing Exec field in qemu.desktop
@ 2020-05-18  9:49   ` Daniel P. Berrangé
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2020-05-18  9:49 UTC (permalink / raw)
  To: Victor Lavaud; +Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On Sat, May 16, 2020 at 02:42:47PM +0000, Victor Lavaud via wrote:
> 
> 
> 
> Sent with ProtonMail Secure Email.
> 

> From 207a1a34accdc5b563d29484292829a4193c35f8 Mon Sep 17 00:00:00 2001
> From: Victor Lavaud <victor.lavaud@gmail.com>
> Date: Sat, 16 May 2020 16:33:00 +0200
> Subject: [PATCH] Fix missing Exec field in qemu.desktop
> 
> Signed-off-by: Victor Lavaud <victor.lavaud@pm.me>
> ---
>  ui/qemu.desktop | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ui/qemu.desktop b/ui/qemu.desktop
> index 20f09f56be..1b9f02a0cc 100644
> --- a/ui/qemu.desktop
> +++ b/ui/qemu.desktop
> @@ -6,3 +6,4 @@ Type=Application
>  Terminal=false
>  Keywords=Emulators;Virtualization;KVM;
>  NoDisplay=true
> +Exec=qemu

There is no such binary, and we *intentionally* don't included any
'Exec' field, because it doesn't make sense. We consider the validation
tool that complains about missing 'Exec' field to be incorrect

   https://bugs.launchpad.net/qemu/+bug/1868221


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-18  9:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-16 14:42 Patch to fix missing Exec field in qemu.desktop Victor Lavaud
2020-05-16 14:42 ` Victor Lavaud via
2020-05-18  9:49 ` Daniel P. Berrangé
2020-05-18  9:49   ` Daniel P. Berrangé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.