From: Mark Brown <broonie@kernel.org>
To: "Ramuthevar,
Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: cheol.yong.kim@intel.com, robh@kernel.org, vigneshr@ti.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
qi-ming.wu@intel.com
Subject: Re: [PATCH v2 1/1] dt-bindings: spi: Add schema for Cadence QSPI Controller driver
Date: Thu, 21 May 2020 11:56:46 +0100 [thread overview]
Message-ID: <20200521105646.GA4770@sirena.org.uk> (raw)
In-Reply-To: <fd086da7-7e18-83bc-d423-56095b0cff96@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1167 bytes --]
On Thu, May 21, 2020 at 10:18:26AM +0800, Ramuthevar, Vadivel MuruganX wrote:
> On 20/5/2020 8:43 pm, Mark Brown wrote:
> > On Wed, May 20, 2020 at 08:36:12PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > > .../devicetree/bindings/mtd/cadence-quadspi.txt | 67 -----------
> > > .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 133 +++++++++++++++++++++
> > The changelog says this is adding a new binding but the actual change is
> > mostly a conversion to YAML. Please split the additions out into a
> > separate change, ideally doing that before the conversion since there is
> > a backlog on review of YAML conversions.
> Initially was sending the only YAML file alone, then reviewers suggest to me
> do this way so I did, next by split the patches like below...
> 1. remove the cadence-quadspi.txt (patch1)
> 2. convert txt to YAML (patch2)
That doesn't address either of the issues. The removal of the old
bindings and addition of the YAML ones needs to be in a single patch
doing that conversion. What I'm suggesting should be done separately is
whatever changes to the semantics of the bindings you are (according to
your changelog) doing.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Ramuthevar,
Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-spi@vger.kernel.org, vigneshr@ti.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com
Subject: Re: [PATCH v2 1/1] dt-bindings: spi: Add schema for Cadence QSPI Controller driver
Date: Thu, 21 May 2020 11:56:46 +0100 [thread overview]
Message-ID: <20200521105646.GA4770@sirena.org.uk> (raw)
In-Reply-To: <fd086da7-7e18-83bc-d423-56095b0cff96@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
On Thu, May 21, 2020 at 10:18:26AM +0800, Ramuthevar, Vadivel MuruganX wrote:
> On 20/5/2020 8:43 pm, Mark Brown wrote:
> > On Wed, May 20, 2020 at 08:36:12PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > > .../devicetree/bindings/mtd/cadence-quadspi.txt | 67 -----------
> > > .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 133 +++++++++++++++++++++
> > The changelog says this is adding a new binding but the actual change is
> > mostly a conversion to YAML. Please split the additions out into a
> > separate change, ideally doing that before the conversion since there is
> > a backlog on review of YAML conversions.
> Initially was sending the only YAML file alone, then reviewers suggest to me
> do this way so I did, next by split the patches like below...
> 1. remove the cadence-quadspi.txt (patch1)
> 2. convert txt to YAML (patch2)
That doesn't address either of the issues. The removal of the old
bindings and addition of the YAML ones needs to be in a single patch
doing that conversion. What I'm suggesting should be done separately is
whatever changes to the semantics of the bindings you are (according to
your changelog) doing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-21 10:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 12:36 [PATCH v2 1/1] dt-bindings: spi: Add schema for Cadence QSPI Controller driver Ramuthevar, Vadivel MuruganX
2020-05-20 12:36 ` Ramuthevar,Vadivel MuruganX
2020-05-20 12:43 ` Mark Brown
2020-05-20 12:43 ` Mark Brown
2020-05-21 2:18 ` Ramuthevar, Vadivel MuruganX
2020-05-21 2:18 ` Ramuthevar, Vadivel MuruganX
2020-05-21 10:56 ` Mark Brown [this message]
2020-05-21 10:56 ` Mark Brown
2020-05-21 12:14 ` Ramuthevar, Vadivel MuruganX
2020-05-21 12:14 ` Ramuthevar, Vadivel MuruganX
2020-05-21 12:20 ` Mark Brown
2020-05-21 12:20 ` Mark Brown
2020-05-21 12:34 ` Ramuthevar, Vadivel MuruganX
2020-05-21 12:34 ` Ramuthevar, Vadivel MuruganX
2020-05-21 12:37 ` Mark Brown
2020-05-21 12:37 ` Mark Brown
2020-05-21 12:43 ` Ramuthevar, Vadivel MuruganX
2020-05-21 12:43 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521105646.GA4770@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=qi-ming.wu@intel.com \
--cc=robh@kernel.org \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.