From: "Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: cheol.yong.kim@intel.com, robh@kernel.org, vigneshr@ti.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
qi-ming.wu@intel.com
Subject: Re: [PATCH v2 1/1] dt-bindings: spi: Add schema for Cadence QSPI Controller driver
Date: Thu, 21 May 2020 20:43:51 +0800 [thread overview]
Message-ID: <f2f15cc2-e2e4-3379-f3b8-ca31a65ded54@linux.intel.com> (raw)
In-Reply-To: <20200521123735.GC4770@sirena.org.uk>
Hi Mark,
On 21/5/2020 8:37 pm, Mark Brown wrote:
> On Thu, May 21, 2020 at 08:34:43PM +0800, Ramuthevar, Vadivel MuruganX wrote:
>> On 21/5/2020 8:20 pm, Mark Brown wrote:
>
>>> I mean that any changes to the bindings ought to be split out into
>>> separate patches, if there's multiple changes it may make sense for
>>> there to be multiple patches.
>
>> Got it, we do not have multiple changes since it is new YAML file.
>> in case if we feel anything to be added , we add as separate patches.
>
> If this is just a conversion to YAML then your changelog is wildly
> inaccurate and needs to be improved, your changelog says you are adding
> new things.
Yes , You are right, just conversion only, over that adding/modifying
few of the properties like compatible and node name in the example..etc
Sure I will make a multiple patches , Thanks!
Regards
Vadivel
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: "Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: robh@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-spi@vger.kernel.org, vigneshr@ti.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com
Subject: Re: [PATCH v2 1/1] dt-bindings: spi: Add schema for Cadence QSPI Controller driver
Date: Thu, 21 May 2020 20:43:51 +0800 [thread overview]
Message-ID: <f2f15cc2-e2e4-3379-f3b8-ca31a65ded54@linux.intel.com> (raw)
In-Reply-To: <20200521123735.GC4770@sirena.org.uk>
Hi Mark,
On 21/5/2020 8:37 pm, Mark Brown wrote:
> On Thu, May 21, 2020 at 08:34:43PM +0800, Ramuthevar, Vadivel MuruganX wrote:
>> On 21/5/2020 8:20 pm, Mark Brown wrote:
>
>>> I mean that any changes to the bindings ought to be split out into
>>> separate patches, if there's multiple changes it may make sense for
>>> there to be multiple patches.
>
>> Got it, we do not have multiple changes since it is new YAML file.
>> in case if we feel anything to be added , we add as separate patches.
>
> If this is just a conversion to YAML then your changelog is wildly
> inaccurate and needs to be improved, your changelog says you are adding
> new things.
Yes , You are right, just conversion only, over that adding/modifying
few of the properties like compatible and node name in the example..etc
Sure I will make a multiple patches , Thanks!
Regards
Vadivel
>
next prev parent reply other threads:[~2020-05-21 12:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 12:36 [PATCH v2 1/1] dt-bindings: spi: Add schema for Cadence QSPI Controller driver Ramuthevar, Vadivel MuruganX
2020-05-20 12:36 ` Ramuthevar,Vadivel MuruganX
2020-05-20 12:43 ` Mark Brown
2020-05-20 12:43 ` Mark Brown
2020-05-21 2:18 ` Ramuthevar, Vadivel MuruganX
2020-05-21 2:18 ` Ramuthevar, Vadivel MuruganX
2020-05-21 10:56 ` Mark Brown
2020-05-21 10:56 ` Mark Brown
2020-05-21 12:14 ` Ramuthevar, Vadivel MuruganX
2020-05-21 12:14 ` Ramuthevar, Vadivel MuruganX
2020-05-21 12:20 ` Mark Brown
2020-05-21 12:20 ` Mark Brown
2020-05-21 12:34 ` Ramuthevar, Vadivel MuruganX
2020-05-21 12:34 ` Ramuthevar, Vadivel MuruganX
2020-05-21 12:37 ` Mark Brown
2020-05-21 12:37 ` Mark Brown
2020-05-21 12:43 ` Ramuthevar, Vadivel MuruganX [this message]
2020-05-21 12:43 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2f15cc2-e2e4-3379-f3b8-ca31a65ded54@linux.intel.com \
--to=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=qi-ming.wu@intel.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.