From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error
Date: Fri, 22 May 2020 16:32:43 -0700 [thread overview]
Message-ID: <20200522233243.GA94020@google.com> (raw)
In-Reply-To: <20200522144752.216197-1-jaegeuk@kernel.org>
Shutdown test is somtimes hung, since it keeps trying to flush dirty node pages
in an inifinite loop. Let's drop dirty pages at umount in that case.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
v2:
- fix typos
fs/f2fs/node.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index e632de10aedab..8c63964a82fd0 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1520,8 +1520,15 @@ static int __write_node_page(struct page *page, bool atomic, bool *submitted,
trace_f2fs_writepage(page, NODE);
- if (unlikely(f2fs_cp_error(sbi)))
+ if (unlikely(f2fs_cp_error(sbi))) {
+ if (is_sbi_flag_set(sbi, SBI_IS_CLOSE)) {
+ dec_page_count(sbi, F2FS_DIRTY_NODES);
+ up_read(&sbi->node_write);
+ unlock_page(page);
+ return 0;
+ }
goto redirty_out;
+ }
if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
goto redirty_out;
--
2.27.0.rc0.183.gde8f92d652-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Subject: Re: [PATCH] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error
Date: Fri, 22 May 2020 16:32:43 -0700 [thread overview]
Message-ID: <20200522233243.GA94020@google.com> (raw)
In-Reply-To: <20200522144752.216197-1-jaegeuk@kernel.org>
Shutdown test is somtimes hung, since it keeps trying to flush dirty node pages
in an inifinite loop. Let's drop dirty pages at umount in that case.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
v2:
- fix typos
fs/f2fs/node.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index e632de10aedab..8c63964a82fd0 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1520,8 +1520,15 @@ static int __write_node_page(struct page *page, bool atomic, bool *submitted,
trace_f2fs_writepage(page, NODE);
- if (unlikely(f2fs_cp_error(sbi)))
+ if (unlikely(f2fs_cp_error(sbi))) {
+ if (is_sbi_flag_set(sbi, SBI_IS_CLOSE)) {
+ dec_page_count(sbi, F2FS_DIRTY_NODES);
+ up_read(&sbi->node_write);
+ unlock_page(page);
+ return 0;
+ }
goto redirty_out;
+ }
if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
goto redirty_out;
--
2.27.0.rc0.183.gde8f92d652-goog
next prev parent reply other threads:[~2020-05-22 23:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 14:47 [f2fs-dev] [PATCH] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error Jaegeuk Kim
2020-05-22 14:47 ` Jaegeuk Kim
2020-05-22 23:32 ` Jaegeuk Kim [this message]
2020-05-22 23:32 ` Jaegeuk Kim
2020-05-25 3:56 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2020-05-25 3:56 ` Jaegeuk Kim
2020-05-25 6:30 ` [f2fs-dev] " Chao Yu
2020-05-25 6:30 ` Chao Yu
2020-05-25 15:06 ` Jaegeuk Kim
2020-05-25 15:06 ` Jaegeuk Kim
2020-05-26 1:11 ` Chao Yu
2020-05-26 1:11 ` Chao Yu
2020-05-26 1:34 ` Chao Yu
2020-05-26 1:34 ` Chao Yu
2020-05-26 1:56 ` Jaegeuk Kim
2020-05-26 1:56 ` Jaegeuk Kim
2020-05-27 2:35 ` Chao Yu
2020-05-27 2:35 ` Chao Yu
2020-05-27 20:56 ` Jaegeuk Kim
2020-05-27 20:56 ` Jaegeuk Kim
2020-05-28 1:20 ` Chao Yu
2020-05-28 1:20 ` Chao Yu
2020-05-25 2:16 ` [f2fs-dev] [PATCH] " Chao Yu
2020-05-25 2:16 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522233243.GA94020@google.com \
--to=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.