From: Borislav Petkov <bp@alien8.de>
To: Markus Elfring <Markus.Elfring@web.de>, Qiushi Wu <wu000273@umn.edu>
Cc: linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Doug Thompson <dougthompson@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Morse <james.morse@arm.com>, Kangjie Lu <kjlu@umn.edu>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rrichter@marvell.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main_kobj()
Date: Fri, 29 May 2020 09:08:24 +0000 [thread overview]
Message-ID: <20200529090824.GB9011@zn.tnic> (raw)
In-Reply-To: <77d6b960-aedc-c7ce-5df9-f3653bfd500a@web.de>
On Fri, May 29, 2020 at 10:45:08AM +0200, Markus Elfring wrote:
> Would you like to indicate with such information (according to
> the topic “net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject”)
> that your issue was detected also with the help of the kernel fuzzing
> tool “syzkaller”?
There's no need for any commt reference - there's text over
kobject_init_and_add() explaining what you need to do when that function
fails.
> How do you think about to add an imperative wording to the change description?
His commit message is fine.
> Will it be helpful to combine this update step together with
> “edac: Fix reference count leak in edac_pci_main_kobj_setup”
> into a small patch series?
Just combine them into one patch.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Markus Elfring <Markus.Elfring@web.de>, Qiushi Wu <wu000273@umn.edu>
Cc: linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Doug Thompson <dougthompson@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Morse <james.morse@arm.com>, Kangjie Lu <kjlu@umn.edu>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rrichter@marvell.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main_kobj()
Date: Fri, 29 May 2020 11:08:24 +0200 [thread overview]
Message-ID: <20200529090824.GB9011@zn.tnic> (raw)
In-Reply-To: <77d6b960-aedc-c7ce-5df9-f3653bfd500a@web.de>
On Fri, May 29, 2020 at 10:45:08AM +0200, Markus Elfring wrote:
> Would you like to indicate with such information (according to
> the topic “net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject”)
> that your issue was detected also with the help of the kernel fuzzing
> tool “syzkaller”?
There's no need for any commt reference - there's text over
kobject_init_and_add() explaining what you need to do when that function
fails.
> How do you think about to add an imperative wording to the change description?
His commit message is fine.
> Will it be helpful to combine this update step together with
> “edac: Fix reference count leak in edac_pci_main_kobj_setup”
> into a small patch series?
Just combine them into one patch.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-05-29 9:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 8:45 [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main_kobj() Markus Elfring
2020-05-29 8:45 ` Markus Elfring
2020-05-29 9:08 ` Borislav Petkov [this message]
2020-05-29 9:08 ` Borislav Petkov
2020-05-29 9:20 ` Markus Elfring
2020-05-29 9:20 ` Markus Elfring
2020-05-29 9:36 ` Borislav Petkov
2020-05-29 9:36 ` Borislav Petkov
2020-05-29 9:40 ` Markus Elfring
2020-05-29 9:40 ` Markus Elfring
2020-05-29 9:47 ` Borislav Petkov
2020-05-29 9:47 ` Borislav Petkov
2020-05-29 10:40 ` Markus Elfring
2020-05-29 10:40 ` Markus Elfring
2020-05-29 11:50 ` Borislav Petkov
2020-05-29 11:50 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529090824.GB9011@zn.tnic \
--to=bp@alien8.de \
--cc=Markus.Elfring@web.de \
--cc=dougthompson@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.