From: Borislav Petkov <bp@alien8.de>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Qiushi Wu <wu000273@umn.edu>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Doug Thompson <dougthompson@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Morse <james.morse@arm.com>, Kangjie Lu <kjlu@umn.edu>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rrichter@marvell.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main_kobj()
Date: Fri, 29 May 2020 09:36:44 +0000 [thread overview]
Message-ID: <20200529093644.GC9011@zn.tnic> (raw)
In-Reply-To: <28ebc99f-c0dd-00b2-7a53-9edf0df36c9c@web.de>
On Fri, May 29, 2020 at 11:20:42AM +0200, Markus Elfring wrote:
> * The label “err_out” can be replaced by direct return statement,
> can't it?
No, it cannot. It keeps the error handling code out-of-line so that the
function body remains readable.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Qiushi Wu <wu000273@umn.edu>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Doug Thompson <dougthompson@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Morse <james.morse@arm.com>, Kangjie Lu <kjlu@umn.edu>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rrichter@marvell.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main_kobj()
Date: Fri, 29 May 2020 11:36:44 +0200 [thread overview]
Message-ID: <20200529093644.GC9011@zn.tnic> (raw)
In-Reply-To: <28ebc99f-c0dd-00b2-7a53-9edf0df36c9c@web.de>
On Fri, May 29, 2020 at 11:20:42AM +0200, Markus Elfring wrote:
> * The label “err_out” can be replaced by direct return statement,
> can't it?
No, it cannot. It keeps the error handling code out-of-line so that the
function body remains readable.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-05-29 9:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 8:45 [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main_kobj() Markus Elfring
2020-05-29 8:45 ` Markus Elfring
2020-05-29 9:08 ` Borislav Petkov
2020-05-29 9:08 ` Borislav Petkov
2020-05-29 9:20 ` Markus Elfring
2020-05-29 9:20 ` Markus Elfring
2020-05-29 9:36 ` Borislav Petkov [this message]
2020-05-29 9:36 ` Borislav Petkov
2020-05-29 9:40 ` Markus Elfring
2020-05-29 9:40 ` Markus Elfring
2020-05-29 9:47 ` Borislav Petkov
2020-05-29 9:47 ` Borislav Petkov
2020-05-29 10:40 ` Markus Elfring
2020-05-29 10:40 ` Markus Elfring
2020-05-29 11:50 ` Borislav Petkov
2020-05-29 11:50 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529093644.GC9011@zn.tnic \
--to=bp@alien8.de \
--cc=Markus.Elfring@web.de \
--cc=dougthompson@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.