From: Kees Cook <keescook@chromium.org>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Alexander Potapenko <glider@google.com>,
Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
x86@kernel.org, drbd-dev@lists.linbit.com,
linux-block@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-ide@vger.kernel.org, linux-clk@vger.kernel.org,
linux-spi@vger.kernel.org, linux-mm@kvack.org,
Clang-Built-Linux ML <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH 00/10] Remove uninitialized_var() macro
Date: Thu, 4 Jun 2020 07:27:42 -0700 [thread overview]
Message-ID: <202006040727.265B0E586@keescook> (raw)
In-Reply-To: <CA+icZUU4Re5g3rRJ=WF3_KiCEc3CUmbH_PibTunuK_E1QskEjQ@mail.gmail.com>
On Thu, Jun 04, 2020 at 09:26:58AM +0200, Sedat Dilek wrote:
> On Thu, Jun 4, 2020 at 5:33 AM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > On Wed, Jun 03, 2020 at 04:31:53PM -0700, Kees Cook wrote:
> > > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > > (or can in the future), and suppresses unrelated compiler warnings
> > > (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> > > either simply initialize the variable or make compiler changes.
> > >
> > > As recommended[2] by[3] Linus[4], remove the macro.
> > [...]
> > For the series, consider it:
> >
> > Tested-by: Nathan Chancellor <natechancellor@gmail.com> [build]
> [...]
>
> I tried with updated version (checkpatch) of your tree and see no
> (new) warnings in my build-log.
>
> Feel free to add my...
>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Awesome! Thank you both! :)
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Clang-Built-Linux ML <clang-built-linux@googlegroups.com>,
linux-ide@vger.kernel.org, netdev@vger.kernel.org,
x86@kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-block@vger.kernel.org,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
linux-mm@kvack.org, Alexander Potapenko <glider@google.com>,
b43-dev@lists.infradead.org, Joe Perches <joe@perches.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-clk@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH 00/10] Remove uninitialized_var() macro
Date: Thu, 4 Jun 2020 07:27:42 -0700 [thread overview]
Message-ID: <202006040727.265B0E586@keescook> (raw)
In-Reply-To: <CA+icZUU4Re5g3rRJ=WF3_KiCEc3CUmbH_PibTunuK_E1QskEjQ@mail.gmail.com>
On Thu, Jun 04, 2020 at 09:26:58AM +0200, Sedat Dilek wrote:
> On Thu, Jun 4, 2020 at 5:33 AM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > On Wed, Jun 03, 2020 at 04:31:53PM -0700, Kees Cook wrote:
> > > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > > (or can in the future), and suppresses unrelated compiler warnings
> > > (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> > > either simply initialize the variable or make compiler changes.
> > >
> > > As recommended[2] by[3] Linus[4], remove the macro.
> > [...]
> > For the series, consider it:
> >
> > Tested-by: Nathan Chancellor <natechancellor@gmail.com> [build]
> [...]
>
> I tried with updated version (checkpatch) of your tree and see no
> (new) warnings in my build-log.
>
> Feel free to add my...
>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Awesome! Thank you both! :)
--
Kees Cook
next prev parent reply other threads:[~2020-06-04 14:27 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 23:31 [PATCH 00/10] Remove uninitialized_var() macro Kees Cook
2020-06-03 23:31 ` [Drbd-dev] " Kees Cook
2020-06-03 23:31 ` [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage Kees Cook
2020-06-03 23:31 ` [Drbd-dev] " Kees Cook
2020-06-04 7:58 ` Thomas Gleixner
2020-06-04 7:58 ` [Drbd-dev] " Thomas Gleixner
2020-06-04 11:41 ` Miguel Ojeda
2020-06-04 11:41 ` [Drbd-dev] " Miguel Ojeda
2020-06-04 14:56 ` Kees Cook
2020-06-04 14:56 ` [Drbd-dev] " Kees Cook
2020-06-04 15:22 ` Miguel Ojeda
2020-06-04 15:22 ` [Drbd-dev] " Miguel Ojeda
2020-06-04 14:34 ` Kees Cook
2020-06-04 14:34 ` [Drbd-dev] " Kees Cook
2020-06-04 21:39 ` Thomas Gleixner
2020-06-04 21:39 ` [Drbd-dev] " Thomas Gleixner
2020-06-04 22:39 ` Kees Cook
2020-06-04 22:39 ` [Drbd-dev] " Kees Cook
2020-06-03 23:31 ` [PATCH 02/10] drbd: " Kees Cook
2020-06-03 23:31 ` [Drbd-dev] " Kees Cook
2020-06-04 19:56 ` Nick Desaulniers
2020-06-04 19:56 ` [Drbd-dev] " Nick Desaulniers
2020-06-03 23:31 ` [PATCH 03/10] b43: " Kees Cook
2020-06-03 23:31 ` [Drbd-dev] " Kees Cook
2020-06-04 20:08 ` Nick Desaulniers
2020-06-04 20:08 ` [Drbd-dev] " Nick Desaulniers
2020-06-04 20:18 ` Kees Cook
2020-06-04 20:18 ` [Drbd-dev] " Kees Cook
2020-06-04 20:25 ` Nick Desaulniers
2020-06-04 20:25 ` [Drbd-dev] " Nick Desaulniers
2020-06-05 9:20 ` Kalle Valo
2020-06-05 9:20 ` [Drbd-dev] " Kalle Valo
2020-06-03 23:31 ` [PATCH 04/10] rtlwifi: rtl8192cu: " Kees Cook
2020-06-03 23:31 ` [Drbd-dev] " Kees Cook
2020-06-04 20:16 ` Nick Desaulniers
2020-06-04 20:16 ` [Drbd-dev] " Nick Desaulniers
2020-06-05 9:18 ` Kalle Valo
2020-06-05 9:18 ` [Drbd-dev] " Kalle Valo
2020-06-03 23:31 ` [PATCH 05/10] ide: " Kees Cook
2020-06-03 23:31 ` [Drbd-dev] " Kees Cook
2020-06-04 19:29 ` Nick Desaulniers
2020-06-04 19:29 ` [Drbd-dev] " Nick Desaulniers
2020-06-04 20:20 ` Kees Cook
2020-06-04 20:20 ` [Drbd-dev] " Kees Cook
2020-06-04 20:29 ` Nick Desaulniers
2020-06-04 20:29 ` [Drbd-dev] " Nick Desaulniers
2020-06-15 19:32 ` Kees Cook
2020-06-15 19:32 ` [Drbd-dev] " Kees Cook
2020-06-04 20:58 ` Sedat Dilek
2020-06-04 20:58 ` [Drbd-dev] " Sedat Dilek
2020-06-03 23:31 ` [PATCH 06/10] clk: st: " Kees Cook
2020-06-03 23:31 ` [Drbd-dev] " Kees Cook
2020-06-04 4:38 ` Stephen Boyd
2020-06-04 4:38 ` [Drbd-dev] " Stephen Boyd
2020-06-03 23:32 ` [PATCH 07/10] spi: davinci: " Kees Cook
2020-06-03 23:32 ` [Drbd-dev] " Kees Cook
2020-06-04 19:40 ` Nick Desaulniers
2020-06-04 19:40 ` [Drbd-dev] " Nick Desaulniers
2020-06-03 23:32 ` [PATCH 08/10] checkpatch: Remove awareness of uninitialized_var() macro Kees Cook
2020-06-03 23:32 ` [Drbd-dev] " Kees Cook
2020-06-04 0:02 ` Joe Perches
2020-06-04 0:02 ` [Drbd-dev] " Joe Perches
2020-06-04 1:40 ` Kees Cook
2020-06-04 1:40 ` [Drbd-dev] " Kees Cook
2020-06-04 1:47 ` Joe Perches
2020-06-04 1:47 ` [Drbd-dev] " Joe Perches
2020-06-04 2:44 ` Kees Cook
2020-06-04 2:44 ` [Drbd-dev] " Kees Cook
2020-06-04 2:53 ` Sedat Dilek
2020-06-04 2:53 ` [Drbd-dev] " Sedat Dilek
2020-06-04 3:46 ` Kees Cook
2020-06-04 3:46 ` [Drbd-dev] " Kees Cook
2020-06-03 23:32 ` [PATCH 09/10] treewide: Remove uninitialized_var() usage Kees Cook
2020-06-04 3:33 ` Nathan Chancellor
2020-06-04 3:33 ` [Drbd-dev] " Nathan Chancellor
2020-06-04 4:02 ` Kees Cook
2020-06-04 4:02 ` [Drbd-dev] " Kees Cook
2020-06-04 10:45 ` Leon Romanovsky
2020-06-04 10:45 ` [Drbd-dev] " Leon Romanovsky
2020-06-04 11:33 ` kernel test robot
2020-06-04 13:23 ` Jason Gunthorpe
2020-06-04 13:23 ` [Drbd-dev] " Jason Gunthorpe
2020-06-04 14:59 ` Kees Cook
2020-06-04 14:59 ` [Drbd-dev] " Kees Cook
2020-06-04 17:57 ` Jason Gunthorpe
2020-06-04 17:57 ` [Drbd-dev] " Jason Gunthorpe
2020-06-04 19:09 ` Geert Uytterhoeven
2020-06-04 19:09 ` [Drbd-dev] " Geert Uytterhoeven
2020-06-05 9:25 ` Kalle Valo
2020-06-05 9:25 ` [Drbd-dev] " Kalle Valo
2020-06-03 23:32 ` [PATCH 10/10] compiler: Remove uninitialized_var() macro Kees Cook
2020-06-03 23:32 ` [Drbd-dev] " Kees Cook
2020-06-04 0:00 ` Bart Van Assche
2020-06-04 0:00 ` [Drbd-dev] " Bart Van Assche
2020-06-04 0:50 ` Miguel Ojeda
2020-06-04 0:50 ` [Drbd-dev] " Miguel Ojeda
2020-06-04 1:23 ` [PATCH 00/10] " Sedat Dilek
2020-06-04 1:23 ` [Drbd-dev] " Sedat Dilek
2020-06-04 1:44 ` Kees Cook
2020-06-04 1:44 ` [Drbd-dev] " Kees Cook
2020-06-04 1:46 ` Sedat Dilek
2020-06-04 1:46 ` [Drbd-dev] " Sedat Dilek
2020-06-04 3:33 ` Nathan Chancellor
2020-06-04 3:33 ` [Drbd-dev] " Nathan Chancellor
2020-06-04 7:26 ` Sedat Dilek
2020-06-04 7:26 ` [Drbd-dev] " Sedat Dilek
2020-06-04 14:27 ` Kees Cook [this message]
2020-06-04 14:27 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006040727.265B0E586@keescook \
--to=keescook@chromium.org \
--cc=apw@canonical.com \
--cc=b43-dev@lists.infradead.org \
--cc=clang-built-linux@googlegroups.com \
--cc=drbd-dev@lists.linbit.com \
--cc=glider@google.com \
--cc=joe@perches.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.