All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org,
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Scott Branden <sbranden@broadcom.com>,
	lukas@wunner.de, Ray Jui <rjui@broadcom.com>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
	"maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." 
	<bcm-kernel-feedback-list@broadcom.com>,
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
	<linux-rpi-kernel@lists.infradead.org>,
	Martin Sperl <kernel@martin.sperl.org>
Subject: Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support
Date: Fri, 5 Jun 2020 11:52:42 +0100	[thread overview]
Message-ID: <20200605105242.GD5413@sirena.org.uk> (raw)
In-Reply-To: <f728f55fe6266718b5041b6f3b1864a673991129.camel@suse.de>

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

On Fri, Jun 05, 2020 at 10:46:57AM +0200, Nicolas Saenz Julienne wrote:

> > -static irqreturn_t bcm2835_spi_interrupt(int irq, void *dev_id)
> > +static inline irqreturn_t bcm2835_spi_interrupt_common(struct spi_controller
> > *ctlr,
> > +						       u32 cs)

> Keep in mind the new 100 character limit.

That's more about stopping people doing awful contortions to shut
checkpatch up than saying that it's a particularly good idea to lengthen
lines.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Scott Branden <sbranden@broadcom.com>,
	Ray Jui <rjui@broadcom.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
	lukas@wunner.de,
	"maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..."
	<bcm-kernel-feedback-list@broadcom.com>,
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
	<linux-rpi-kernel@lists.infradead.org>,
	Martin Sperl <kernel@martin.sperl.org>,
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support
Date: Fri, 5 Jun 2020 11:52:42 +0100	[thread overview]
Message-ID: <20200605105242.GD5413@sirena.org.uk> (raw)
In-Reply-To: <f728f55fe6266718b5041b6f3b1864a673991129.camel@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 453 bytes --]

On Fri, Jun 05, 2020 at 10:46:57AM +0200, Nicolas Saenz Julienne wrote:

> > -static irqreturn_t bcm2835_spi_interrupt(int irq, void *dev_id)
> > +static inline irqreturn_t bcm2835_spi_interrupt_common(struct spi_controller
> > *ctlr,
> > +						       u32 cs)

> Keep in mind the new 100 character limit.

That's more about stopping people doing awful contortions to shut
checkpatch up than saying that it's a particularly good idea to lengthen
lines.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-05 10:52 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 21:28 [PATCH v2] spi: bcm2835: Enable shared interrupt support Florian Fainelli
2020-06-04 21:28 ` Florian Fainelli
2020-06-05  8:46 ` Nicolas Saenz Julienne
2020-06-05  8:46   ` Nicolas Saenz Julienne
2020-06-05 10:52   ` Mark Brown [this message]
2020-06-05 10:52     ` Mark Brown
2020-06-05 10:58   ` Nicolas Saenz Julienne
2020-06-05 10:58     ` Nicolas Saenz Julienne
2020-06-05 10:51 ` Lukas Wunner
2020-06-05 11:14 ` Mark Brown
2020-06-05 11:14   ` Mark Brown
2020-06-05 12:20   ` Mark Brown
2020-06-05 12:20     ` Mark Brown
2020-06-05 11:34 ` Robin Murphy
2020-06-05 11:34   ` Robin Murphy
2020-06-05 13:20   ` Mark Brown
2020-06-05 13:20     ` Mark Brown
2020-06-05 13:46     ` Robin Murphy
2020-06-05 13:46       ` Robin Murphy
2020-06-05 14:41       ` Robin Murphy
2020-06-05 14:41         ` Robin Murphy
2020-06-05 15:27         ` Mark Brown
2020-06-05 15:27           ` Mark Brown
2020-06-05 22:04         ` Florian Fainelli
2020-06-05 22:04           ` Florian Fainelli
2020-06-08 11:11           ` Robin Murphy
2020-06-08 11:11             ` Robin Murphy
2020-06-08 11:28             ` Mark Brown
2020-06-08 11:28               ` Mark Brown
2020-06-15 16:34               ` Florian Fainelli
2020-06-15 16:34                 ` Florian Fainelli
2020-06-15 17:00                 ` Mark Brown
2020-06-15 17:00                   ` Mark Brown
2020-06-15 17:04                   ` Florian Fainelli
2020-06-15 17:04                     ` Florian Fainelli
2020-06-15 17:30                     ` Mark Brown
2020-06-15 17:30                       ` Mark Brown
2020-06-15 17:31                     ` Robin Murphy
2020-06-15 17:31                       ` Robin Murphy
2020-06-15 19:26                       ` Mark Brown
2020-06-15 19:26                         ` Mark Brown
2020-06-08 11:41             ` Lukas Wunner
2020-06-15 19:09               ` Robin Murphy
2020-06-15 19:09                 ` Robin Murphy
2020-06-15 19:42                 ` Florian Fainelli
2020-06-15 19:42                   ` Florian Fainelli
2020-06-15 20:48                   ` Mark Brown
2020-06-15 20:48                     ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2022-07-19 10:53 [PATCH v2] spi: bcm2835: enable " Marc Kleine-Budde
2022-07-26 11:17 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200605105242.GD5413@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@martin.sperl.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=nsaenzjulienne@suse.de \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.