From: Florian Fainelli <f.fainelli@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
lukas@wunner.de,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
linux-kernel@vger.kernel.org,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..."
<bcm-kernel-feedback-list@broadcom.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Martin Sperl <kernel@martin.sperl.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support
Date: Mon, 15 Jun 2020 10:04:46 -0700 [thread overview]
Message-ID: <692bc94e-d574-e07a-d834-c0d569e87bba@gmail.com> (raw)
In-Reply-To: <20200615170031.GA4447@sirena.org.uk>
On 6/15/2020 10:00 AM, Mark Brown wrote:
> On Mon, Jun 15, 2020 at 09:34:58AM -0700, Florian Fainelli wrote:
>
>> OK, so this has been dropped for spi/for-next right? How do we move from
>> there?
>
> Well, I actually have it queued up for applying so unless I pull it
> before my scripts get that far through the stuff I queued over the merge
> window it'll go in (I dropped it due to it not being a bugfix). If it
> were me I'd go with the two instruction hit from checking the flag TBH
> but otherwise I guess __always_inline should work for compilers that
> misoptimize. None of this is getting in the way of the framework so if
> everyone involved in the driver is happy to spend time optimising it
> and dealing with the fragility then it's fine by me.
OK, how about I send you an increment patch (would a fixup be okay?)
that adds __always_inline since we know from this thread that some
compilers may mis-optimize the function inlining?
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
lukas@wunner.de,
"maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..."
<bcm-kernel-feedback-list@broadcom.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Martin Sperl <kernel@martin.sperl.org>,
Robin Murphy <robin.murphy@arm.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support
Date: Mon, 15 Jun 2020 10:04:46 -0700 [thread overview]
Message-ID: <692bc94e-d574-e07a-d834-c0d569e87bba@gmail.com> (raw)
In-Reply-To: <20200615170031.GA4447@sirena.org.uk>
On 6/15/2020 10:00 AM, Mark Brown wrote:
> On Mon, Jun 15, 2020 at 09:34:58AM -0700, Florian Fainelli wrote:
>
>> OK, so this has been dropped for spi/for-next right? How do we move from
>> there?
>
> Well, I actually have it queued up for applying so unless I pull it
> before my scripts get that far through the stuff I queued over the merge
> window it'll go in (I dropped it due to it not being a bugfix). If it
> were me I'd go with the two instruction hit from checking the flag TBH
> but otherwise I guess __always_inline should work for compilers that
> misoptimize. None of this is getting in the way of the framework so if
> everyone involved in the driver is happy to spend time optimising it
> and dealing with the fragility then it's fine by me.
OK, how about I send you an increment patch (would a fixup be okay?)
that adds __always_inline since we know from this thread that some
compilers may mis-optimize the function inlining?
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-15 17:04 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 21:28 [PATCH v2] spi: bcm2835: Enable shared interrupt support Florian Fainelli
2020-06-04 21:28 ` Florian Fainelli
2020-06-05 8:46 ` Nicolas Saenz Julienne
2020-06-05 8:46 ` Nicolas Saenz Julienne
2020-06-05 10:52 ` Mark Brown
2020-06-05 10:52 ` Mark Brown
2020-06-05 10:58 ` Nicolas Saenz Julienne
2020-06-05 10:58 ` Nicolas Saenz Julienne
2020-06-05 10:51 ` Lukas Wunner
2020-06-05 11:14 ` Mark Brown
2020-06-05 11:14 ` Mark Brown
2020-06-05 12:20 ` Mark Brown
2020-06-05 12:20 ` Mark Brown
2020-06-05 11:34 ` Robin Murphy
2020-06-05 11:34 ` Robin Murphy
2020-06-05 13:20 ` Mark Brown
2020-06-05 13:20 ` Mark Brown
2020-06-05 13:46 ` Robin Murphy
2020-06-05 13:46 ` Robin Murphy
2020-06-05 14:41 ` Robin Murphy
2020-06-05 14:41 ` Robin Murphy
2020-06-05 15:27 ` Mark Brown
2020-06-05 15:27 ` Mark Brown
2020-06-05 22:04 ` Florian Fainelli
2020-06-05 22:04 ` Florian Fainelli
2020-06-08 11:11 ` Robin Murphy
2020-06-08 11:11 ` Robin Murphy
2020-06-08 11:28 ` Mark Brown
2020-06-08 11:28 ` Mark Brown
2020-06-15 16:34 ` Florian Fainelli
2020-06-15 16:34 ` Florian Fainelli
2020-06-15 17:00 ` Mark Brown
2020-06-15 17:00 ` Mark Brown
2020-06-15 17:04 ` Florian Fainelli [this message]
2020-06-15 17:04 ` Florian Fainelli
2020-06-15 17:30 ` Mark Brown
2020-06-15 17:30 ` Mark Brown
2020-06-15 17:31 ` Robin Murphy
2020-06-15 17:31 ` Robin Murphy
2020-06-15 19:26 ` Mark Brown
2020-06-15 19:26 ` Mark Brown
2020-06-08 11:41 ` Lukas Wunner
2020-06-15 19:09 ` Robin Murphy
2020-06-15 19:09 ` Robin Murphy
2020-06-15 19:42 ` Florian Fainelli
2020-06-15 19:42 ` Florian Fainelli
2020-06-15 20:48 ` Mark Brown
2020-06-15 20:48 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2022-07-19 10:53 [PATCH v2] spi: bcm2835: enable " Marc Kleine-Budde
2022-07-26 11:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=692bc94e-d574-e07a-d834-c0d569e87bba@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@martin.sperl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.