From: Mark Brown <broonie@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: robh@kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [RFC PATCH 1/2] dt-bindings: tas2562: Add firmware support for tas2563
Date: Wed, 10 Jun 2020 11:29:20 +0100 [thread overview]
Message-ID: <20200610102920.GC5005@sirena.org.uk> (raw)
In-Reply-To: <014b85b5-677b-569a-4eb2-74526d3f00bc@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On Tue, Jun 09, 2020 at 02:20:29PM -0500, Dan Murphy wrote:
> On 6/9/20 1:47 PM, Mark Brown wrote:
> > That's really not very idiomatic for how Linux does stuff and seems to
> > pretty much guarantee issues with hotplugging controls and ordering -
> > you'd need special userspace to start up even if it was just a really
> > simple DSP config doing only speaker correction or something. I'm not
> > sure what the advantage would be - what problem is this solving over
> > static names?
> IMO having a static name is the problem. It is an inflexible design.
> Besides the firmware-name property seems to be used in other drivers to
> declare firmwares for the boards.
> But if no one is complaining or submitting patches within the codecs to be
> more flexible with firmware then I can just hard code the name like other
> drivers do.
I'm not *completely* opposed to having the ability to suggest a name in
firmware, the big problem is making use of the DSP completely dependent
on having a DT property or doing some non-standard dance in userspace.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
robh@kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] dt-bindings: tas2562: Add firmware support for tas2563
Date: Wed, 10 Jun 2020 11:29:20 +0100 [thread overview]
Message-ID: <20200610102920.GC5005@sirena.org.uk> (raw)
In-Reply-To: <014b85b5-677b-569a-4eb2-74526d3f00bc@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On Tue, Jun 09, 2020 at 02:20:29PM -0500, Dan Murphy wrote:
> On 6/9/20 1:47 PM, Mark Brown wrote:
> > That's really not very idiomatic for how Linux does stuff and seems to
> > pretty much guarantee issues with hotplugging controls and ordering -
> > you'd need special userspace to start up even if it was just a really
> > simple DSP config doing only speaker correction or something. I'm not
> > sure what the advantage would be - what problem is this solving over
> > static names?
> IMO having a static name is the problem. It is an inflexible design.
> Besides the firmware-name property seems to be used in other drivers to
> declare firmwares for the boards.
> But if no one is complaining or submitting patches within the codecs to be
> more flexible with firmware then I can just hard code the name like other
> drivers do.
I'm not *completely* opposed to having the ability to suggest a name in
firmware, the big problem is making use of the DSP completely dependent
on having a DT property or doing some non-standard dance in userspace.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-10 10:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 17:28 [RFC PATCH 0/2] TAS2563 DSP Firmware Loader Dan Murphy
2020-06-09 17:28 ` Dan Murphy
2020-06-09 17:28 ` [RFC PATCH 1/2] dt-bindings: tas2562: Add firmware support for tas2563 Dan Murphy
2020-06-09 17:28 ` Dan Murphy
2020-06-09 17:31 ` Mark Brown
2020-06-09 17:31 ` Mark Brown
2020-06-09 17:35 ` Dan Murphy
2020-06-09 17:35 ` Dan Murphy
2020-06-09 17:58 ` Mark Brown
2020-06-09 17:58 ` Mark Brown
2020-06-09 18:06 ` Dan Murphy
2020-06-09 18:06 ` Dan Murphy
2020-06-09 18:47 ` Mark Brown
2020-06-09 18:47 ` Mark Brown
2020-06-09 19:20 ` Dan Murphy
2020-06-09 19:20 ` Dan Murphy
2020-06-10 10:29 ` Mark Brown [this message]
2020-06-10 10:29 ` Mark Brown
2020-06-10 14:12 ` Dan Murphy
2020-06-10 14:12 ` Dan Murphy
2020-06-10 14:28 ` Mark Brown
2020-06-10 14:28 ` Mark Brown
2020-06-17 22:04 ` Rob Herring
2020-06-17 22:04 ` Rob Herring
2020-06-18 10:57 ` Mark Brown
2020-06-18 10:57 ` Mark Brown
2020-06-09 17:28 ` [RFC PATCH 2/2] ASoc: tas2563: DSP Firmware loading support Dan Murphy
2020-06-09 17:28 ` Dan Murphy
2020-06-09 17:50 ` Mark Brown
2020-06-09 17:50 ` Mark Brown
2020-06-12 17:30 ` Dan Murphy
2020-06-12 17:30 ` Dan Murphy
2020-06-12 17:46 ` Mark Brown
2020-06-12 17:46 ` Mark Brown
2020-06-09 17:52 ` [RFC PATCH 0/2] TAS2563 DSP Firmware Loader Mark Brown
2020-06-09 17:52 ` Mark Brown
2020-06-09 18:07 ` Dan Murphy
2020-06-09 18:07 ` Dan Murphy
2020-06-09 18:16 ` Mark Brown
2020-06-09 18:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610102920.GC5005@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.