All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Bernard Zhao <bernard@vivo.com>,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	linux-arm-msm@vger.kernel.org, opensource.kernel@vivo.com,
	linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
	David Airlie <airlied@linux.ie>, Rob Clark <robdclark@gmail.com>,
	Sean Paul <sean@poorly.run>
Subject: Re: [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create()
Date: Fri, 12 Jun 2020 12:02:05 +0200	[thread overview]
Message-ID: <20200612100205.GD3157576@kroah.com> (raw)
In-Reply-To: <acd53f06-845b-75e0-24c5-40c751d12945@web.de>

On Fri, Jun 12, 2020 at 11:37:33AM +0200, Markus Elfring wrote:
> > In fucntin msm_submitqueue_create, the queue is a local
> > variable, in return -EINVAL branch, queue didn`t add to ctx`s
> > list yet, and also didn`t kfree, this maybe bring in potential
> > memleak.
> 
> I suggest to improve also this change description.
> How do you think about a wording variant like the following?
> 
>    Release the GPU submission queue object after an input parameter validation failed.
> 
> 
> Would you like to add the tag “Fixes” to the commit message?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n183
> 
> 
> How do you think about to reorder any statements for this function implementation?
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Sean Paul <sean@poorly.run>,
	opensource.kernel@vivo.com, David Airlie <airlied@linux.ie>,
	Bernard Zhao <bernard@vivo.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create()
Date: Fri, 12 Jun 2020 12:02:05 +0200	[thread overview]
Message-ID: <20200612100205.GD3157576@kroah.com> (raw)
In-Reply-To: <acd53f06-845b-75e0-24c5-40c751d12945@web.de>

On Fri, Jun 12, 2020 at 11:37:33AM +0200, Markus Elfring wrote:
> > In fucntin msm_submitqueue_create, the queue is a local
> > variable, in return -EINVAL branch, queue didn`t add to ctx`s
> > list yet, and also didn`t kfree, this maybe bring in potential
> > memleak.
> 
> I suggest to improve also this change description.
> How do you think about a wording variant like the following?
> 
>    Release the GPU submission queue object after an input parameter validation failed.
> 
> 
> Would you like to add the tag “Fixes” to the commit message?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n183
> 
> 
> How do you think about to reorder any statements for this function implementation?
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-12 10:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12  9:37 [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create() Markus Elfring
2020-06-12  9:37 ` Markus Elfring
2020-06-12 10:02 ` Greg KH [this message]
2020-06-12 10:02   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200612100205.GD3157576@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Markus.Elfring@web.de \
    --cc=airlied@linux.ie \
    --cc=bernard@vivo.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=opensource.kernel@vivo.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.