From: Krzysztof Kozlowski <krzk@kernel.org>
To: wu000273@umn.edu
Cc: kjlu@umn.edu, "Łukasz Stelmach" <l.stelmach@samsung.com>,
"Matt Mackall" <mpm@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Philippe Ombredanne" <pombredanne@nexb.com>,
linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: hw_random: Fix a reference count leak.
Date: Mon, 15 Jun 2020 08:58:46 +0200 [thread overview]
Message-ID: <20200615065846.GA5791@kozik-lap> (raw)
In-Reply-To: <20200613214128.32665-1-wu000273@umn.edu>
On Sat, Jun 13, 2020 at 04:41:28PM -0500, wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
>
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count if pm_runtime_put_sync is not
> called in error handling paths. Thus replace the jump target
> "err_pm_get" by "err_clock".
>
> Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver")
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
1. Cc: <stable@vger.kernel.org>
2. Subject prefix:
hwrng: exynos -
3. Subject title: Fix PM runtime reference count leak
(no need for end stop)
With these changes:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: wu000273@umn.edu
Cc: linux-samsung-soc@vger.kernel.org,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Philippe Ombredanne" <pombredanne@nexb.com>,
"Łukasz Stelmach" <l.stelmach@samsung.com>,
linux-kernel@vger.kernel.org, "Kukjin Kim" <kgene@kernel.org>,
linux-crypto@vger.kernel.org, "Matt Mackall" <mpm@selenic.com>,
kjlu@umn.edu, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] char: hw_random: Fix a reference count leak.
Date: Mon, 15 Jun 2020 08:58:46 +0200 [thread overview]
Message-ID: <20200615065846.GA5791@kozik-lap> (raw)
In-Reply-To: <20200613214128.32665-1-wu000273@umn.edu>
On Sat, Jun 13, 2020 at 04:41:28PM -0500, wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
>
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count if pm_runtime_put_sync is not
> called in error handling paths. Thus replace the jump target
> "err_pm_get" by "err_clock".
>
> Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver")
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
1. Cc: <stable@vger.kernel.org>
2. Subject prefix:
hwrng: exynos -
3. Subject title: Fix PM runtime reference count leak
(no need for end stop)
With these changes:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-15 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200615131915eucas1p2b8f3fa0ceb757e36aa888a4476de034f@eucas1p2.samsung.com>
2020-06-13 21:41 ` [PATCH] char: hw_random: Fix a reference count leak wu000273
2020-06-13 21:41 ` wu000273
2020-06-15 6:58 ` Krzysztof Kozlowski [this message]
2020-06-15 6:58 ` Krzysztof Kozlowski
2020-06-15 13:18 ` Lukasz Stelmach
2020-06-15 13:18 ` Lukasz Stelmach
2020-06-16 7:31 ` Herbert Xu
2020-06-16 7:31 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615065846.GA5791@kozik-lap \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=kgene@kernel.org \
--cc=kjlu@umn.edu \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=pombredanne@nexb.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.