* [PATCH] ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode
@ 2020-06-17 17:33 Fabio Estevam
2020-06-17 17:39 ` Tom Rini
2020-06-23 7:51 ` sbabic at denx.de
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2020-06-17 17:33 UTC (permalink / raw)
To: u-boot
As per kernel commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode)
the correct phy-mode should be "rgmii-id", so fix it accordingly
to fix the Ethernet regression.
This problem has been exposed by commit:
commit 13114f38e2ccea9386726d8b9831dfc310589548
Author: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: Thu May 7 00:11:51 2020 +0200
phy: atheros: Explicitly disable RGMII delays
To eliminate any doubts about the out-of-reset value of the PHY, that
the driver previously relied on.
If bisecting shows that this commit breaks your board you probably have
a wrong PHY interface mode. You probably want the
PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Hi,
Probably syncing with the mainline kernel would help fixing other boards.
I tried this approach and noticed some dtb build breakage as there are some
dtbs that are not in mainline, so to be on the safe side, apply the minimal
fix for the sabresd board to fix the regression for 2020.07.
arch/arm/dts/imx6qdl-sabresd.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/imx6qdl-sabresd.dtsi b/arch/arm/dts/imx6qdl-sabresd.dtsi
index 2cd5a9fbac..eddb390174 100644
--- a/arch/arm/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/dts/imx6qdl-sabresd.dtsi
@@ -204,7 +204,7 @@
&fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode
2020-06-17 17:33 [PATCH] ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode Fabio Estevam
@ 2020-06-17 17:39 ` Tom Rini
2020-06-23 7:51 ` sbabic at denx.de
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-06-17 17:39 UTC (permalink / raw)
To: u-boot
On Wed, Jun 17, 2020 at 02:33:16PM -0300, Fabio Estevam wrote:
> As per kernel commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode)
> the correct phy-mode should be "rgmii-id", so fix it accordingly
> to fix the Ethernet regression.
>
> This problem has been exposed by commit:
>
> commit 13114f38e2ccea9386726d8b9831dfc310589548
> Author: Vladimir Oltean <vladimir.oltean@nxp.com>
> Date: Thu May 7 00:11:51 2020 +0200
>
> phy: atheros: Explicitly disable RGMII delays
>
> To eliminate any doubts about the out-of-reset value of the PHY, that
> the driver previously relied on.
>
> If bisecting shows that this commit breaks your board you probably have
> a wrong PHY interface mode. You probably want the
> PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Hi,
>
> Probably syncing with the mainline kernel would help fixing other boards.
>
> I tried this approach and noticed some dtb build breakage as there are some
> dtbs that are not in mainline, so to be on the safe side, apply the minimal
> fix for the sabresd board to fix the regression for 2020.07.
As part of tracking down the cubox problem yesterday before posting I
found that some parts of your commit 0672d22a1924 in the kernel applied
in U-Boot, mainly, ah, the sabre* boards. Others were already fixed or
absent.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200617/ffac7e94/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode
2020-06-17 17:33 [PATCH] ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode Fabio Estevam
2020-06-17 17:39 ` Tom Rini
@ 2020-06-23 7:51 ` sbabic at denx.de
1 sibling, 0 replies; 3+ messages in thread
From: sbabic at denx.de @ 2020-06-23 7:51 UTC (permalink / raw)
To: u-boot
> As per kernel commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode)
> the correct phy-mode should be "rgmii-id", so fix it accordingly
> to fix the Ethernet regression.
> This problem has been exposed by commit:
> commit 13114f38e2ccea9386726d8b9831dfc310589548
> Author: Vladimir Oltean <vladimir.oltean@nxp.com>
> Date: Thu May 7 00:11:51 2020 +0200
> phy: atheros: Explicitly disable RGMII delays
>
> To eliminate any doubts about the out-of-reset value of the PHY, that
> the driver previously relied on.
>
> If bisecting shows that this commit breaks your board you probably have
> a wrong PHY interface mode. You probably want the
> PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-23 7:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-17 17:33 [PATCH] ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode Fabio Estevam
2020-06-17 17:39 ` Tom Rini
2020-06-23 7:51 ` sbabic at denx.de
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.