All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
To: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Laurent Pinchart
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Frank Rowand
	<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels
Date: Sat, 20 Jun 2020 17:30:12 +0200	[thread overview]
Message-ID: <20200620153012.GA22743@ravnborg.org> (raw)
In-Reply-To: <e77a34c1-3e0b-7f30-25d0-a955ec8d8c86-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hi Dmitry
On Sat, Jun 20, 2020 at 06:05:37PM +0300, Dmitry Osipenko wrote:
> 20.06.2020 17:31, Sam Ravnborg пишет:
> > Hi Dmitry
> > 
> >>
> >> Oops! Good catch!
> > Yep, thanks Laurent. Should have taken a better look before applying.
> > 
> >> Indeed, I blindly set the LVDS type to all these
> >> panels. Please revert this patch, I'll double check each panel and
> >> prepare an updated version of this patch. Thank you very much for the
> >> review!
> > 
> > If you can prepare a fix within a few days then lets wait for that.
> > I will do a better review next time.
> 
> Hello Sam,
> 
> I should be able to make it later today or tomorrow. Could you please
> clarify what do you mean by the fix, do you what it to be as an
> additional patch on top of the applied one or a new version of the patch?
An additional patch on top of the one applied.
It shall carry a proper fixes: tag like this:

Fixes: 94f07917ebe8 ("drm/panel-simple: Add missing connector type for some panels")
Cc: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels
Date: Sat, 20 Jun 2020 17:30:12 +0200	[thread overview]
Message-ID: <20200620153012.GA22743@ravnborg.org> (raw)
In-Reply-To: <e77a34c1-3e0b-7f30-25d0-a955ec8d8c86@gmail.com>

Hi Dmitry
On Sat, Jun 20, 2020 at 06:05:37PM +0300, Dmitry Osipenko wrote:
> 20.06.2020 17:31, Sam Ravnborg пишет:
> > Hi Dmitry
> > 
> >>
> >> Oops! Good catch!
> > Yep, thanks Laurent. Should have taken a better look before applying.
> > 
> >> Indeed, I blindly set the LVDS type to all these
> >> panels. Please revert this patch, I'll double check each panel and
> >> prepare an updated version of this patch. Thank you very much for the
> >> review!
> > 
> > If you can prepare a fix within a few days then lets wait for that.
> > I will do a better review next time.
> 
> Hello Sam,
> 
> I should be able to make it later today or tomorrow. Could you please
> clarify what do you mean by the fix, do you what it to be as an
> additional patch on top of the applied one or a new version of the patch?
An additional patch on top of the one applied.
It shall carry a proper fixes: tag like this:

Fixes: 94f07917ebe8 ("drm/panel-simple: Add missing connector type for some panels")
Cc: Dmitry Osipenko <digetx@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-tegra@vger.kernel.org,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels
Date: Sat, 20 Jun 2020 17:30:12 +0200	[thread overview]
Message-ID: <20200620153012.GA22743@ravnborg.org> (raw)
In-Reply-To: <e77a34c1-3e0b-7f30-25d0-a955ec8d8c86@gmail.com>

Hi Dmitry
On Sat, Jun 20, 2020 at 06:05:37PM +0300, Dmitry Osipenko wrote:
> 20.06.2020 17:31, Sam Ravnborg пишет:
> > Hi Dmitry
> > 
> >>
> >> Oops! Good catch!
> > Yep, thanks Laurent. Should have taken a better look before applying.
> > 
> >> Indeed, I blindly set the LVDS type to all these
> >> panels. Please revert this patch, I'll double check each panel and
> >> prepare an updated version of this patch. Thank you very much for the
> >> review!
> > 
> > If you can prepare a fix within a few days then lets wait for that.
> > I will do a better review next time.
> 
> Hello Sam,
> 
> I should be able to make it later today or tomorrow. Could you please
> clarify what do you mean by the fix, do you what it to be as an
> additional patch on top of the applied one or a new version of the patch?
An additional patch on top of the one applied.
It shall carry a proper fixes: tag like this:

Fixes: 94f07917ebe8 ("drm/panel-simple: Add missing connector type for some panels")
Cc: Dmitry Osipenko <digetx@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-06-20 15:30 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17 22:26 [PATCH v8 0/7] Support DRM bridges on NVIDIA Tegra Dmitry Osipenko
2020-06-17 22:26 ` Dmitry Osipenko
2020-06-17 22:26 ` Dmitry Osipenko
     [not found] ` <20200617222703.17080-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-17 22:26   ` [PATCH v8 1/7] of_graph: add of_graph_presents() Dmitry Osipenko
2020-06-17 22:26     ` Dmitry Osipenko
2020-06-17 22:26     ` Dmitry Osipenko
     [not found]     ` <20200617222703.17080-2-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-29 23:12       ` Rob Herring
2020-06-29 23:12         ` Rob Herring
2020-06-29 23:12         ` Rob Herring
2020-06-30 17:02         ` Dmitry Osipenko
2020-06-30 17:02           ` Dmitry Osipenko
2020-06-30 17:02           ` Dmitry Osipenko
2020-06-17 22:26   ` [PATCH v8 2/7] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence Dmitry Osipenko
2020-06-17 22:26     ` Dmitry Osipenko
2020-06-17 22:26     ` Dmitry Osipenko
2020-06-17 22:26   ` [PATCH v8 3/7] drm/tegra: output: Don't leak OF node on error Dmitry Osipenko
2020-06-17 22:26     ` Dmitry Osipenko
2020-06-17 22:26     ` Dmitry Osipenko
2020-06-17 22:27   ` [PATCH v8 5/7] drm/tegra: output: rgb: Support LVDS encoder bridge Dmitry Osipenko
2020-06-17 22:27     ` Dmitry Osipenko
2020-06-17 22:27     ` Dmitry Osipenko
2020-06-17 22:27   ` [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels Dmitry Osipenko
2020-06-17 22:27     ` Dmitry Osipenko
2020-06-17 22:27     ` Dmitry Osipenko
     [not found]     ` <20200617222703.17080-8-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-20 11:21       ` Sam Ravnborg
2020-06-20 11:21         ` Sam Ravnborg
2020-06-20 11:21         ` Sam Ravnborg
     [not found]         ` <20200620112132.GB16901-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2020-06-20 11:49           ` Laurent Pinchart
2020-06-20 11:49             ` Laurent Pinchart
2020-06-20 11:49             ` Laurent Pinchart
     [not found]             ` <20200620114934.GB5829-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org>
2020-06-20 13:19               ` Dmitry Osipenko
2020-06-20 13:19                 ` Dmitry Osipenko
2020-06-20 13:19                 ` Dmitry Osipenko
     [not found]                 ` <ea421084-a91c-bc03-5997-1723075b7cae-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-20 14:31                   ` Sam Ravnborg
2020-06-20 14:31                     ` Sam Ravnborg
2020-06-20 14:31                     ` Sam Ravnborg
     [not found]                     ` <20200620143114.GA22329-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2020-06-20 15:05                       ` Dmitry Osipenko
2020-06-20 15:05                         ` Dmitry Osipenko
2020-06-20 15:05                         ` Dmitry Osipenko
     [not found]                         ` <e77a34c1-3e0b-7f30-25d0-a955ec8d8c86-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-20 15:30                           ` Sam Ravnborg [this message]
2020-06-20 15:30                             ` Sam Ravnborg
2020-06-20 15:30                             ` Sam Ravnborg
     [not found]                             ` <20200620153012.GA22743-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2020-06-20 16:18                               ` Dmitry Osipenko
2020-06-20 16:18                                 ` Dmitry Osipenko
2020-06-20 16:18                                 ` Dmitry Osipenko
2020-06-17 22:27 ` [PATCH v8 4/7] drm/tegra: output: Support DRM bridges Dmitry Osipenko
2020-06-17 22:27   ` Dmitry Osipenko
2020-06-17 22:27 ` [PATCH v8 6/7] drm/tegra: output: rgb: Wrap directly-connected panel into DRM bridge Dmitry Osipenko
2020-06-17 22:27   ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200620153012.GA22743@ravnborg.org \
    --to=sam-uyr5n9q2vtjg9huczpvpmw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.