From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
jpa@kernelbug.mail.kapsi.fi, Dave Hansen <dave.hansen@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] selftests/fpu: Add an FPU selftest
Date: Tue, 23 Jun 2020 12:28:31 +0200 [thread overview]
Message-ID: <20200623102831.GB32590@zn.tnic> (raw)
In-Reply-To: <B4D00859-000A-4F8C-8CFB-45B9BBCCA16D@amacapital.net>
On Mon, Jun 22, 2020 at 12:37:12PM -0700, Andy Lutomirski wrote:
> It’s this whole mess:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53383
It really is a mess because our option detection doesn't really work. I did:
ifdef CONFIG_CC_IS_GCC
ifeq ($(call cc-option-yn,-mpreferred-stack-boundary=3),y)
dummy := $(error "gcc supports -mpreferred-stack-boundary=3")
endif
...
and doing:
$ make CC=gcc-4.8 HOSTCC=gcc-4.8 V=1 lib/test_fpu.ko
gives
lib/Makefile:110: *** "gcc supports -mpreferred-stack-boundary=3". Stop.
That same compiler, however, says:
$ gcc-4.8 -mpreferred-stack-boundary=3 -c /tmp/foo.c
/tmp/foo.c:1:0: error: -mpreferred-stack-boundary=3 is not between 4 and 12
so I need to dig deep into cc-option* fun.
Or, I can be lazy and simply cut off all compiler versions to >= 8
and be done with it. If people wanna run selftests, they can upgrade
toolchain too...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-06-23 10:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 17:41 [PATCH 0/2] x86/FPU: FPU sanitization for in-kernel use Borislav Petkov
2020-06-19 17:41 ` [PATCH 1/2] x86/fpu: Reset MXCSR to default in kernel_fpu_begin() Borislav Petkov
2020-06-19 18:01 ` Andy Lutomirski
2020-06-22 17:09 ` Borislav Petkov
2020-06-22 18:33 ` Andy Lutomirski
2020-06-22 18:36 ` Petteri Aimonen
2020-06-22 18:38 ` Dave Hansen
2020-06-22 18:40 ` Andy Lutomirski
2020-06-22 18:59 ` Borislav Petkov
2020-06-19 17:41 ` [PATCH 2/2] selftests/fpu: Add an FPU selftest Borislav Petkov
2020-06-19 18:00 ` Andy Lutomirski
2020-06-22 17:12 ` Borislav Petkov
2020-06-22 18:26 ` Andy Lutomirski
2020-06-22 19:01 ` Borislav Petkov
[not found] ` <B4D00859-000A-4F8C-8CFB-45B9BBCCA16D@amacapital.net>
2020-06-23 10:28 ` Borislav Petkov [this message]
2020-06-23 18:22 ` Andy Lutomirski
2020-06-23 18:47 ` Borislav Petkov
2020-06-23 19:07 ` Nick Desaulniers
2020-06-23 19:13 ` Borislav Petkov
2020-06-23 20:58 ` Nick Desaulniers
2020-06-23 21:32 ` Borislav Petkov
2020-06-20 19:55 ` kernel test robot
2020-06-20 19:55 ` kernel test robot
2020-06-22 17:04 ` Borislav Petkov
2020-06-22 17:04 ` Borislav Petkov
2020-06-22 18:15 ` Nick Desaulniers
2020-06-22 18:15 ` Nick Desaulniers
-- strict thread matches above, loose matches on Subject: below --
2020-06-20 10:22 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623102831.GB32590@zn.tnic \
--to=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=jpa@kernelbug.mail.kapsi.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.