From: Borislav Petkov <bp@alien8.de>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
jpa@kernelbug.mail.kapsi.fi, Dave Hansen <dave.hansen@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] selftests/fpu: Add an FPU selftest
Date: Tue, 23 Jun 2020 21:13:36 +0200 [thread overview]
Message-ID: <20200623191336.GK32590@zn.tnic> (raw)
In-Reply-To: <CAKwvOdnt+8RR=1JPjDNaVY8T1K7wmqFjSGM7XNUUGRb=t1hiWQ@mail.gmail.com>
On Tue, Jun 23, 2020 at 12:07:13PM -0700, Nick Desaulniers wrote:
> You already have a conditional below for CC_IS_GCC; just add an else
> and unconditionally add -msse2. You *should* use -msse2 for GCC 7.1+
> IMO.
Why if one can write it more compact with cc-option?
FPU_CFLAGS += $(call cc-option,-msse2,)
> Note that Clang has -mstack-alignment=8 whereas GCC has
> -mpreferred-stack-boundary=3. (Clang is a value in bytes, GCC is 2^X
> bytes)
Sure, the stack boundary setting is GCC only.
> I recommend a version check for GCC < 7.1, or simply disabling the
> self test if the version of GCC used is older than 7.1.
See Andy's suggestion upthread.
And I agree too that using cc-option is better than simply tying it to a
compiler version. Who knows what compiler has what backported. In such
cases a version number means nothing.
> ^ looks familiar ;)
It has been pasted around the kernel, I came to realize today. :-)
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-06-23 19:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 17:41 [PATCH 0/2] x86/FPU: FPU sanitization for in-kernel use Borislav Petkov
2020-06-19 17:41 ` [PATCH 1/2] x86/fpu: Reset MXCSR to default in kernel_fpu_begin() Borislav Petkov
2020-06-19 18:01 ` Andy Lutomirski
2020-06-22 17:09 ` Borislav Petkov
2020-06-22 18:33 ` Andy Lutomirski
2020-06-22 18:36 ` Petteri Aimonen
2020-06-22 18:38 ` Dave Hansen
2020-06-22 18:40 ` Andy Lutomirski
2020-06-22 18:59 ` Borislav Petkov
2020-06-19 17:41 ` [PATCH 2/2] selftests/fpu: Add an FPU selftest Borislav Petkov
2020-06-19 18:00 ` Andy Lutomirski
2020-06-22 17:12 ` Borislav Petkov
2020-06-22 18:26 ` Andy Lutomirski
2020-06-22 19:01 ` Borislav Petkov
[not found] ` <B4D00859-000A-4F8C-8CFB-45B9BBCCA16D@amacapital.net>
2020-06-23 10:28 ` Borislav Petkov
2020-06-23 18:22 ` Andy Lutomirski
2020-06-23 18:47 ` Borislav Petkov
2020-06-23 19:07 ` Nick Desaulniers
2020-06-23 19:13 ` Borislav Petkov [this message]
2020-06-23 20:58 ` Nick Desaulniers
2020-06-23 21:32 ` Borislav Petkov
2020-06-20 19:55 ` kernel test robot
2020-06-20 19:55 ` kernel test robot
2020-06-22 17:04 ` Borislav Petkov
2020-06-22 17:04 ` Borislav Petkov
2020-06-22 18:15 ` Nick Desaulniers
2020-06-22 18:15 ` Nick Desaulniers
-- strict thread matches above, loose matches on Subject: below --
2020-06-20 10:22 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623191336.GK32590@zn.tnic \
--to=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=jpa@kernelbug.mail.kapsi.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=ndesaulniers@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.