All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 9/9] regulator: qcom_smd-regulator: Remove unused 'struct regulator_desc pmi8994_boost'
Date: Fri, 26 Jun 2020 00:19:05 -0700	[thread overview]
Message-ID: <20200626071905.GD388985@builder.lan> (raw)
In-Reply-To: <20200626065738.93412-10-lee.jones@linaro.org>

On Thu 25 Jun 23:57 PDT 2020, Lee Jones wrote:

> This was an upstreaming error.  Remove it as it's not to be used.
> 
> Fixes the following W=1 kernel build warning:
> 
>  drivers/regulator/qcom_smd-regulator.c:477:36: warning: ‘pmi8994_boost’ defined but not used [-Wunused-const-variable=]
> 
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Thanks,
Bjorn

> ---
>  drivers/regulator/qcom_smd-regulator.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 53a64d856926f..4c0a469d8a115 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -474,15 +474,6 @@ static const struct regulator_desc pmi8994_bby = {
>  	.ops = &rpm_bob_ops,
>  };
>  
> -static const struct regulator_desc pmi8994_boost = {
> -	.linear_ranges = (struct linear_range[]) {
> -		REGULATOR_LINEAR_RANGE(4000000, 0, 30, 50000),
> -	},
> -	.n_linear_ranges = 1,
> -	.n_voltages = 31,
> -	.ops = &rpm_smps_ldo_ops,
> -};
> -
>  static const struct regulator_desc pm8998_ftsmps = {
>  	.linear_ranges = (struct linear_range[]) {
>  		REGULATOR_LINEAR_RANGE(320000, 0, 258, 4000),
> -- 
> 2.25.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, broonie@kernel.org,
	lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	Andy Gross <agross@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 9/9] regulator: qcom_smd-regulator: Remove unused 'struct regulator_desc pmi8994_boost'
Date: Fri, 26 Jun 2020 00:19:05 -0700	[thread overview]
Message-ID: <20200626071905.GD388985@builder.lan> (raw)
In-Reply-To: <20200626065738.93412-10-lee.jones@linaro.org>

On Thu 25 Jun 23:57 PDT 2020, Lee Jones wrote:

> This was an upstreaming error.  Remove it as it's not to be used.
> 
> Fixes the following W=1 kernel build warning:
> 
>  drivers/regulator/qcom_smd-regulator.c:477:36: warning: ‘pmi8994_boost’ defined but not used [-Wunused-const-variable=]
> 
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Thanks,
Bjorn

> ---
>  drivers/regulator/qcom_smd-regulator.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 53a64d856926f..4c0a469d8a115 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -474,15 +474,6 @@ static const struct regulator_desc pmi8994_bby = {
>  	.ops = &rpm_bob_ops,
>  };
>  
> -static const struct regulator_desc pmi8994_boost = {
> -	.linear_ranges = (struct linear_range[]) {
> -		REGULATOR_LINEAR_RANGE(4000000, 0, 30, 50000),
> -	},
> -	.n_linear_ranges = 1,
> -	.n_voltages = 31,
> -	.ops = &rpm_smps_ldo_ops,
> -};
> -
>  static const struct regulator_desc pm8998_ftsmps = {
>  	.linear_ranges = (struct linear_range[]) {
>  		REGULATOR_LINEAR_RANGE(320000, 0, 258, 4000),
> -- 
> 2.25.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-26  7:21 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26  6:57 [PATCH 0/9] Fix a bunch more W=1 warnings in Regulator Lee Jones
2020-06-26  6:57 ` Lee Jones
2020-06-26  6:57 ` [PATCH 1/9] regulator: max8998: Staticify internal function max8998_get_current_limit() Lee Jones
2020-06-26  6:57   ` Lee Jones
2020-06-26  6:57 ` [PATCH 2/9] regulator: qcom-rpmh-regulator: Repair dodgy kerneldoc header formatting Lee Jones
2020-06-26  6:57   ` Lee Jones
2020-06-26  7:18   ` Bjorn Andersson
2020-06-26  7:18     ` Bjorn Andersson
2020-06-26  6:57 ` [PATCH 3/9] regulator: pwm-regulator: Demote kerneldoc header to standard comment Lee Jones
2020-06-26  6:57   ` Lee Jones
2020-06-26  6:57 ` [PATCH 4/9] regulator: stpmic1_regulator: Properly document 'struct stpmic1_regulator_cfg' Lee Jones
2020-06-26  6:57   ` Lee Jones
2020-06-26  6:57 ` [PATCH 5/9] regulator: tps65217-regulator: Remove pointless 'is unsigned int <0' check Lee Jones
2020-06-26  6:57   ` Lee Jones
2020-06-26  6:57 ` [PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg_read() Lee Jones
2020-06-26  6:57   ` Lee Jones
2020-06-26 13:33   ` Mark Brown
2020-06-26 13:33     ` Mark Brown
2020-06-26 15:31     ` Lee Jones
2020-06-26 15:31       ` Lee Jones
2020-06-26 15:34       ` Mark Brown
2020-06-26 15:34         ` Mark Brown
2020-06-26  6:57 ` [PATCH 7/9] regulator: tps65218-regulator: Remove pointless 'is unsigned int <0' check Lee Jones
2020-06-26  6:57   ` Lee Jones
2020-06-26  6:57 ` [PATCH 8/9] regulator: wm8400-regulator: Repair dodgy kerneldoc header formatting Lee Jones
2020-06-26  6:57   ` Lee Jones
2020-06-26  9:20   ` Charles Keepax
2020-06-26  9:20     ` Charles Keepax
2020-06-26  6:57 ` [PATCH 9/9] regulator: qcom_smd-regulator: Remove unused 'struct regulator_desc pmi8994_boost' Lee Jones
2020-06-26  6:57   ` Lee Jones
2020-06-26  7:19   ` Bjorn Andersson [this message]
2020-06-26  7:19     ` Bjorn Andersson
2020-06-26 15:21 ` [PATCH 0/9] Fix a bunch more W=1 warnings in Regulator Mark Brown
2020-06-26 15:21   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200626071905.GD388985@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.