From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Russ Dill <Russ.Dill@ti.com>,
Keerthy <j-keerthy@ti.com>, AnilKumar Ch <anilkumar@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg_read()
Date: Fri, 26 Jun 2020 16:31:19 +0100 [thread overview]
Message-ID: <20200626153119.GC177734@dell> (raw)
In-Reply-To: <20200626133304.GB5289@sirena.org.uk>
On Fri, 26 Jun 2020, Mark Brown wrote:
> On Fri, Jun 26, 2020 at 07:57:35AM +0100, Lee Jones wrote:
>
> > Until now the aforementioned return value has been ignored.
>
> This is only aforementioned in the subject.
>
> > /* Store default strobe info */
> > ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val);
> > + if (ret)
> > + return ret;
> > +
>
> We should really be logging an error there rather than just returning,
> that way it's a bit more apparent to someone debugging things what went
> wrong if there is actually a problem.
Would you like me to fix that up subsequently?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Keerthy <j-keerthy@ti.com>,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
Russ Dill <Russ.Dill@ti.com>, AnilKumar Ch <anilkumar@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg_read()
Date: Fri, 26 Jun 2020 16:31:19 +0100 [thread overview]
Message-ID: <20200626153119.GC177734@dell> (raw)
In-Reply-To: <20200626133304.GB5289@sirena.org.uk>
On Fri, 26 Jun 2020, Mark Brown wrote:
> On Fri, Jun 26, 2020 at 07:57:35AM +0100, Lee Jones wrote:
>
> > Until now the aforementioned return value has been ignored.
>
> This is only aforementioned in the subject.
>
> > /* Store default strobe info */
> > ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val);
> > + if (ret)
> > + return ret;
> > +
>
> We should really be logging an error there rather than just returning,
> that way it's a bit more apparent to someone debugging things what went
> wrong if there is actually a problem.
Would you like me to fix that up subsequently?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-26 15:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 6:57 [PATCH 0/9] Fix a bunch more W=1 warnings in Regulator Lee Jones
2020-06-26 6:57 ` Lee Jones
2020-06-26 6:57 ` [PATCH 1/9] regulator: max8998: Staticify internal function max8998_get_current_limit() Lee Jones
2020-06-26 6:57 ` Lee Jones
2020-06-26 6:57 ` [PATCH 2/9] regulator: qcom-rpmh-regulator: Repair dodgy kerneldoc header formatting Lee Jones
2020-06-26 6:57 ` Lee Jones
2020-06-26 7:18 ` Bjorn Andersson
2020-06-26 7:18 ` Bjorn Andersson
2020-06-26 6:57 ` [PATCH 3/9] regulator: pwm-regulator: Demote kerneldoc header to standard comment Lee Jones
2020-06-26 6:57 ` Lee Jones
2020-06-26 6:57 ` [PATCH 4/9] regulator: stpmic1_regulator: Properly document 'struct stpmic1_regulator_cfg' Lee Jones
2020-06-26 6:57 ` Lee Jones
2020-06-26 6:57 ` [PATCH 5/9] regulator: tps65217-regulator: Remove pointless 'is unsigned int <0' check Lee Jones
2020-06-26 6:57 ` Lee Jones
2020-06-26 6:57 ` [PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg_read() Lee Jones
2020-06-26 6:57 ` Lee Jones
2020-06-26 13:33 ` Mark Brown
2020-06-26 13:33 ` Mark Brown
2020-06-26 15:31 ` Lee Jones [this message]
2020-06-26 15:31 ` Lee Jones
2020-06-26 15:34 ` Mark Brown
2020-06-26 15:34 ` Mark Brown
2020-06-26 6:57 ` [PATCH 7/9] regulator: tps65218-regulator: Remove pointless 'is unsigned int <0' check Lee Jones
2020-06-26 6:57 ` Lee Jones
2020-06-26 6:57 ` [PATCH 8/9] regulator: wm8400-regulator: Repair dodgy kerneldoc header formatting Lee Jones
2020-06-26 6:57 ` Lee Jones
2020-06-26 9:20 ` Charles Keepax
2020-06-26 9:20 ` Charles Keepax
2020-06-26 6:57 ` [PATCH 9/9] regulator: qcom_smd-regulator: Remove unused 'struct regulator_desc pmi8994_boost' Lee Jones
2020-06-26 6:57 ` Lee Jones
2020-06-26 7:19 ` Bjorn Andersson
2020-06-26 7:19 ` Bjorn Andersson
2020-06-26 15:21 ` [PATCH 0/9] Fix a bunch more W=1 warnings in Regulator Mark Brown
2020-06-26 15:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626153119.GC177734@dell \
--to=lee.jones@linaro.org \
--cc=Russ.Dill@ti.com \
--cc=anilkumar@ti.com \
--cc=broonie@kernel.org \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.