From: Kees Cook <keescook@chromium.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/10] misc: lkdtm: Always provide prototype for lkdtm_DOUBLE_FAULT()
Date: Fri, 26 Jun 2020 08:23:14 -0700 [thread overview]
Message-ID: <202006260821.0079FA827@keescook> (raw)
In-Reply-To: <20200626130525.389469-6-lee.jones@linaro.org>
On Fri, Jun 26, 2020 at 02:05:20PM +0100, Lee Jones wrote:
> lkdtm_DOUBLE_FAULT() already has internal logic to handle
> !CONFIG_X86_32. Compiling out the prototype actually prevents
> that logic from being useful.
>
> Fixes the following W=1 warning:
>
> drivers/misc/lkdtm/bugs.c: At top level:
> drivers/misc/lkdtm/bugs.c:420:6: warning: no previous prototype for ‘lkdtm_DOUBLE_FAULT’ [-Wmissing-prototypes]
> 420 | void lkdtm_DOUBLE_FAULT(void)
> | ^~~~~~~~~~~~~~~~~~
>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Thanks! This change is actually already part of another
patch and is waiting for Greg to pick up:
https://lore.kernel.org/lkml/20200529200347.2464284-5-keescook@chromium.org/
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/10] misc: lkdtm: Always provide prototype for lkdtm_DOUBLE_FAULT()
Date: Fri, 26 Jun 2020 08:23:14 -0700 [thread overview]
Message-ID: <202006260821.0079FA827@keescook> (raw)
In-Reply-To: <20200626130525.389469-6-lee.jones@linaro.org>
On Fri, Jun 26, 2020 at 02:05:20PM +0100, Lee Jones wrote:
> lkdtm_DOUBLE_FAULT() already has internal logic to handle
> !CONFIG_X86_32. Compiling out the prototype actually prevents
> that logic from being useful.
>
> Fixes the following W=1 warning:
>
> drivers/misc/lkdtm/bugs.c: At top level:
> drivers/misc/lkdtm/bugs.c:420:6: warning: no previous prototype for ‘lkdtm_DOUBLE_FAULT’ [-Wmissing-prototypes]
> 420 | void lkdtm_DOUBLE_FAULT(void)
> | ^~~~~~~~~~~~~~~~~~
>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Thanks! This change is actually already part of another
patch and is waiting for Greg to pick up:
https://lore.kernel.org/lkml/20200529200347.2464284-5-keescook@chromium.org/
--
Kees Cook
next prev parent reply other threads:[~2020-06-26 15:25 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 13:05 [PATCH 00/10] Fix a bunch of W=1 warnings in Misc Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 13:05 ` [PATCH 01/10] misc: c2port: core: Ensure source size does not equal destination size in strncpy() Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 13:15 ` Rodolfo Giometti
2020-06-26 13:15 ` Rodolfo Giometti
2020-07-13 19:10 ` Geert Uytterhoeven
2020-07-13 19:10 ` Geert Uytterhoeven
2020-07-14 7:46 ` Lee Jones
2020-07-14 7:46 ` Lee Jones
2020-07-14 7:52 ` Geert Uytterhoeven
2020-07-14 7:52 ` Geert Uytterhoeven
2020-07-14 8:01 ` Lee Jones
2020-07-14 8:01 ` Lee Jones
2020-07-14 8:02 ` Geert Uytterhoeven
2020-07-14 8:02 ` Geert Uytterhoeven
2020-06-26 13:05 ` [PATCH 02/10] misc: ti-st: st_core: Tidy-up bespoke commentry Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 14:05 ` Arnd Bergmann
2020-06-26 14:05 ` Arnd Bergmann
2020-06-26 13:05 ` [PATCH 03/10] misc: ti-st: st_kim: " Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 14:06 ` Arnd Bergmann
2020-06-26 14:06 ` Arnd Bergmann
2020-06-26 13:05 ` [PATCH 04/10] misc: lkdtm: bugs: At least try to use popuated variable Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 14:37 ` Arnd Bergmann
2020-06-26 14:37 ` Arnd Bergmann
2020-06-26 15:26 ` Kees Cook
2020-06-26 15:26 ` Kees Cook
2020-06-26 13:05 ` [PATCH 05/10] misc: lkdtm: Always provide prototype for lkdtm_DOUBLE_FAULT() Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 14:37 ` Arnd Bergmann
2020-06-26 14:37 ` Arnd Bergmann
2020-06-26 15:23 ` Kees Cook [this message]
2020-06-26 15:23 ` Kees Cook
2020-06-26 13:05 ` [PATCH 06/10] misc: eeprom: eeprom_93cx6: Repair function arg descriptions Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 14:38 ` Arnd Bergmann
2020-06-26 14:38 ` Arnd Bergmann
2020-06-27 20:33 ` Wolfram Sang
2020-06-27 20:33 ` Wolfram Sang
2020-06-29 8:14 ` Lee Jones
2020-06-29 8:14 ` Lee Jones
2020-06-29 8:20 ` Wolfram Sang
2020-06-29 8:20 ` Wolfram Sang
2020-06-29 8:46 ` Lee Jones
2020-06-29 8:46 ` Lee Jones
2020-06-26 13:05 ` [PATCH 07/10] misc: mic: vop: vop_main: Remove set but unused variable 'ret' Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 14:39 ` Arnd Bergmann
2020-06-26 14:39 ` Arnd Bergmann
2020-06-26 15:29 ` Lee Jones
2020-06-26 15:29 ` Lee Jones
2020-06-26 18:38 ` Arnd Bergmann
2020-06-26 18:38 ` Arnd Bergmann
2020-06-26 13:05 ` [PATCH 08/10] misc: cb710: sgbuf2: Add missing documentation for cb710_sg_dwiter_write_next_block()'s 'data' arg Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 14:39 ` Arnd Bergmann
2020-06-26 14:39 ` Arnd Bergmann
2020-06-26 16:46 ` Michał Mirosław
2020-06-26 16:46 ` Michał Mirosław
2020-06-26 13:05 ` [PATCH 09/10] misc: habanalabs: irq: Add missing struct identifier for 'struct hl_eqe_work' Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 13:45 ` Oded Gabbay
2020-06-26 13:45 ` Oded Gabbay
2020-06-26 13:46 ` Oded Gabbay
2020-06-26 13:46 ` Oded Gabbay
2020-06-26 13:05 ` [PATCH 10/10] misc: pti: Fix documentation for bit-rotted function pti_tty_driver_write() Lee Jones
2020-06-26 13:05 ` Lee Jones
2020-06-26 14:40 ` Arnd Bergmann
2020-06-26 14:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006260821.0079FA827@keescook \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.