All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/vc4: call ->post_disable() functions in vc4_dsi_encoder_disable()
@ 2020-06-26 10:34 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-06-26 10:34 UTC (permalink / raw)
  To: Eric Anholt, Boris Brezillon
  Cc: David Airlie, Andrzej Hajda, kernel-janitors, dri-devel

The problem is that the iterator is already at the list head so the
list_for_each_entry_from() loop is a no-op and we don't call the
the iter->funcs->post_disable() functions.  This should be
list_for_each_entry() instead.

Fixes: 033bfe7538a1 ("drm/vc4: dsi: Fix bridge chain handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/vc4/vc4_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
index eaf276978ee7..f92d0e92fa72 100644
--- a/drivers/gpu/drm/vc4/vc4_dsi.c
+++ b/drivers/gpu/drm/vc4/vc4_dsi.c
@@ -754,7 +754,7 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder)
 
 	vc4_dsi_ulps(dsi, true);
 
-	list_for_each_entry_from(iter, &dsi->bridge_chain, chain_node) {
+	list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
 		if (iter->funcs->post_disable)
 			iter->funcs->post_disable(iter);
 	}
-- 
2.27.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] drm/vc4: call ->post_disable() functions in vc4_dsi_encoder_disable()
@ 2020-06-26 10:34 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-06-26 10:34 UTC (permalink / raw)
  To: Eric Anholt, Boris Brezillon
  Cc: David Airlie, Andrzej Hajda, kernel-janitors, dri-devel

The problem is that the iterator is already at the list head so the
list_for_each_entry_from() loop is a no-op and we don't call the
the iter->funcs->post_disable() functions.  This should be
list_for_each_entry() instead.

Fixes: 033bfe7538a1 ("drm/vc4: dsi: Fix bridge chain handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/vc4/vc4_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
index eaf276978ee7..f92d0e92fa72 100644
--- a/drivers/gpu/drm/vc4/vc4_dsi.c
+++ b/drivers/gpu/drm/vc4/vc4_dsi.c
@@ -754,7 +754,7 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder)
 
 	vc4_dsi_ulps(dsi, true);
 
-	list_for_each_entry_from(iter, &dsi->bridge_chain, chain_node) {
+	list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
 		if (iter->funcs->post_disable)
 			iter->funcs->post_disable(iter);
 	}
-- 
2.27.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/vc4: call ->post_disable() functions in vc4_dsi_encoder_disable()
  2020-06-26 10:34 ` Dan Carpenter
@ 2020-06-26 10:35   ` Boris Brezillon
  -1 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2020-06-26 10:35 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Andrzej Hajda, David Airlie, kernel-janitors, dri-devel

On Fri, 26 Jun 2020 13:34:01 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The problem is that the iterator is already at the list head so the
> list_for_each_entry_from() loop is a no-op and we don't call the
> the iter->funcs->post_disable() functions.  This should be
> list_for_each_entry() instead.
> 
> Fixes: 033bfe7538a1 ("drm/vc4: dsi: Fix bridge chain handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/vc4/vc4_dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index eaf276978ee7..f92d0e92fa72 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -754,7 +754,7 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder)
>  
>  	vc4_dsi_ulps(dsi, true);
>  
> -	list_for_each_entry_from(iter, &dsi->bridge_chain, chain_node) {
> +	list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
>  		if (iter->funcs->post_disable)
>  			iter->funcs->post_disable(iter);
>  	}

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/vc4: call ->post_disable() functions in vc4_dsi_encoder_disable()
@ 2020-06-26 10:35   ` Boris Brezillon
  0 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2020-06-26 10:35 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Andrzej Hajda, David Airlie, kernel-janitors, dri-devel

On Fri, 26 Jun 2020 13:34:01 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The problem is that the iterator is already at the list head so the
> list_for_each_entry_from() loop is a no-op and we don't call the
> the iter->funcs->post_disable() functions.  This should be
> list_for_each_entry() instead.
> 
> Fixes: 033bfe7538a1 ("drm/vc4: dsi: Fix bridge chain handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/vc4/vc4_dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index eaf276978ee7..f92d0e92fa72 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -754,7 +754,7 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder)
>  
>  	vc4_dsi_ulps(dsi, true);
>  
> -	list_for_each_entry_from(iter, &dsi->bridge_chain, chain_node) {
> +	list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
>  		if (iter->funcs->post_disable)
>  			iter->funcs->post_disable(iter);
>  	}

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-26 10:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-26 10:34 [PATCH] drm/vc4: call ->post_disable() functions in vc4_dsi_encoder_disable() Dan Carpenter
2020-06-26 10:34 ` Dan Carpenter
2020-06-26 10:35 ` Boris Brezillon
2020-06-26 10:35   ` Boris Brezillon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.