All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v5 2/2] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support
Date: Mon, 29 Jun 2020 10:15:03 +0200	[thread overview]
Message-ID: <20200629101503.5bae21d6@xps13> (raw)
In-Reply-To: <20200628072444.GA8391@pendragon.ideasonboard.com>

Hi Laurent,

[...]

> >  
> > +static const struct display_timing satoz_sat050at40h12r2_timing = {
> > +	.pixelclock = {33300000, 33300000, 50000000},
> > +	.hactive = {800, 800, 800},
> > +	.hfront_porch = {16, 210, 354},
> > +	.hback_porch = {46, 46, 46},
> > +	.hsync_len = {1, 1, 40},
> > +	.vactive = {480, 480, 480},
> > +	.vfront_porch = {7, 22, 147},
> > +	.vback_porch = {23, 23, 23},
> > +	.vsync_len = {1, 1, 20},
> > +};
> > +
> > +static const struct panel_desc satoz_sat050at40h12r2 = {
> > +	.timings = &satoz_sat050at40h12r2_timing,
> > +	.num_timings = 1,
> > +	.bpc = 8,
> > +	.size = {
> > +		.width = 108,
> > +		.height = 65,
> > +	},
> > +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > +	.connector_type = DRM_MODE_CONNECTOR_LVDS,  
> 
> I'm trying to fix inconsistencies in the panel-simple driver, and this
> caught my eyes. MEDIA_BUS_FMT_RGB888_1X24 isn't a correct format for
> LVDS panels. MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> MEDIA_BUS_FMT_RGB888_1X7X4_SPWG or MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA
> should be used instead. As I couldn't find documentation for the panel,
> I can't tell which format is correct. Could you please help ?

Indeed, I got this datasheet under NDA.

We checked with Paul, we think the right format is:
MEDIA_BUS_FMT_RGB888_1X7X4_SPWG.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v5 2/2] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support
Date: Mon, 29 Jun 2020 10:15:03 +0200	[thread overview]
Message-ID: <20200629101503.5bae21d6@xps13> (raw)
In-Reply-To: <20200628072444.GA8391@pendragon.ideasonboard.com>

Hi Laurent,

[...]

> >  
> > +static const struct display_timing satoz_sat050at40h12r2_timing = {
> > +	.pixelclock = {33300000, 33300000, 50000000},
> > +	.hactive = {800, 800, 800},
> > +	.hfront_porch = {16, 210, 354},
> > +	.hback_porch = {46, 46, 46},
> > +	.hsync_len = {1, 1, 40},
> > +	.vactive = {480, 480, 480},
> > +	.vfront_porch = {7, 22, 147},
> > +	.vback_porch = {23, 23, 23},
> > +	.vsync_len = {1, 1, 20},
> > +};
> > +
> > +static const struct panel_desc satoz_sat050at40h12r2 = {
> > +	.timings = &satoz_sat050at40h12r2_timing,
> > +	.num_timings = 1,
> > +	.bpc = 8,
> > +	.size = {
> > +		.width = 108,
> > +		.height = 65,
> > +	},
> > +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > +	.connector_type = DRM_MODE_CONNECTOR_LVDS,  
> 
> I'm trying to fix inconsistencies in the panel-simple driver, and this
> caught my eyes. MEDIA_BUS_FMT_RGB888_1X24 isn't a correct format for
> LVDS panels. MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> MEDIA_BUS_FMT_RGB888_1X7X4_SPWG or MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA
> should be used instead. As I couldn't find documentation for the panel,
> I can't tell which format is correct. Could you please help ?

Indeed, I got this datasheet under NDA.

We checked with Paul, we think the right format is:
MEDIA_BUS_FMT_RGB888_1X7X4_SPWG.

Thanks,
Miquèl
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-29 19:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09 18:40 [PATCH v5 1/2] dt-bindings: display: simple: Add Satoz panel Miquel Raynal
2020-01-09 18:40 ` Miquel Raynal
2020-01-09 18:40 ` [PATCH v5 2/2] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Miquel Raynal
2020-01-09 18:40   ` Miquel Raynal
2020-06-28  7:24   ` Laurent Pinchart
2020-06-28  7:24     ` Laurent Pinchart
2020-06-29  8:15     ` Miquel Raynal [this message]
2020-06-29  8:15       ` Miquel Raynal
2020-01-09 19:32 ` [PATCH v5 1/2] dt-bindings: display: simple: Add Satoz panel Sam Ravnborg
2020-01-09 19:32   ` Sam Ravnborg
2020-01-10  8:00   ` Miquel Raynal
2020-01-10  8:00     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629101503.5bae21d6@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.