From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux FS Devel <linux-fsdevel@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: always expose label 'next_page'
Date: Tue, 30 Jun 2020 13:23:57 -0700 [thread overview]
Message-ID: <20200630202357.GA1396584@google.com> (raw)
In-Reply-To: <020937f3-2947-ca41-c18a-026782216711@infradead.org>
On 06/30, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error when F2FS_FS_COMPRESSION is not set/enabled.
> This label is needed in either case.
>
> ../fs/f2fs/data.c: In function ‘f2fs_mpage_readpages’:
> ../fs/f2fs/data.c:2327:5: error: label ‘next_page’ used but not defined
> goto next_page;
Thank you for the fix. This was actually introduced by the recent testing patch.
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=ff963ad2bf54460431f517b5cae473997a29bf2a
If you don't mind, please let me integrate this into the original patch.
Let me know.
Thanks,
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Cc: Chao Yu <yuchao0@huawei.com>
> Cc: linux-f2fs-devel@lists.sourceforge.net
> ---
> fs/f2fs/data.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-next-20200630.orig/fs/f2fs/data.c
> +++ linux-next-20200630/fs/f2fs/data.c
> @@ -2366,9 +2366,7 @@ set_error_page:
> zero_user_segment(page, 0, PAGE_SIZE);
> unlock_page(page);
> }
> -#ifdef CONFIG_F2FS_FS_COMPRESSION
> next_page:
> -#endif
> if (rac)
> put_page(page);
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Chao Yu <yuchao0@huawei.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: always expose label 'next_page'
Date: Tue, 30 Jun 2020 13:23:57 -0700 [thread overview]
Message-ID: <20200630202357.GA1396584@google.com> (raw)
In-Reply-To: <020937f3-2947-ca41-c18a-026782216711@infradead.org>
On 06/30, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error when F2FS_FS_COMPRESSION is not set/enabled.
> This label is needed in either case.
>
> ../fs/f2fs/data.c: In function ‘f2fs_mpage_readpages’:
> ../fs/f2fs/data.c:2327:5: error: label ‘next_page’ used but not defined
> goto next_page;
Thank you for the fix. This was actually introduced by the recent testing patch.
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=ff963ad2bf54460431f517b5cae473997a29bf2a
If you don't mind, please let me integrate this into the original patch.
Let me know.
Thanks,
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Cc: Chao Yu <yuchao0@huawei.com>
> Cc: linux-f2fs-devel@lists.sourceforge.net
> ---
> fs/f2fs/data.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-next-20200630.orig/fs/f2fs/data.c
> +++ linux-next-20200630/fs/f2fs/data.c
> @@ -2366,9 +2366,7 @@ set_error_page:
> zero_user_segment(page, 0, PAGE_SIZE);
> unlock_page(page);
> }
> -#ifdef CONFIG_F2FS_FS_COMPRESSION
> next_page:
> -#endif
> if (rac)
> put_page(page);
>
next prev parent reply other threads:[~2020-06-30 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 17:09 [f2fs-dev] [PATCH] f2fs: always expose label 'next_page' Randy Dunlap
2020-06-30 17:09 ` Randy Dunlap
2020-06-30 20:23 ` Jaegeuk Kim [this message]
2020-06-30 20:23 ` Jaegeuk Kim
2020-06-30 20:44 ` [f2fs-dev] " Randy Dunlap
2020-06-30 20:44 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630202357.GA1396584@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.