From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
Raj Ashok <ashok.raj@intel.com>, Jonathan Corbet <corbet@lwn.net>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
Alex Williamson <alex.williamson@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v4 3/5] iommu/uapi: Use named union for user data
Date: Wed, 8 Jul 2020 08:18:58 -0700 [thread overview]
Message-ID: <20200708081858.37091f4b@jacob-builder> (raw)
In-Reply-To: <3b36c219-4120-402b-b03e-62b076db865c@linux.intel.com>
On Wed, 8 Jul 2020 10:17:57 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:
> Hi Jacob,
>
> On 7/8/20 7:43 AM, Jacob Pan wrote:
> > IOMMU UAPI data size is filled by the user space which must be
> > validated by ther kernel. To ensure backward compatibility, user
> > data can only be extended by either re-purpose padding bytes or
> > extend the variable sized union at the end. No size change is
> > allowed before the union. Therefore, the minimum size is the offset
> > of the union.
> >
> > To use offsetof() on the union, we must make it named.
> >
> > Link:https://lkml.org/lkml/2020/6/11/834
>
> Please use lore.kernel.org links.
>
OK. will do.
> Best regards,
> baolu
[Jacob Pan]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Yi Liu <yi.l.liu@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>,
Raj Ashok <ashok.raj@intel.com>,
Christoph Hellwig <hch@infradead.org>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
Eric Auger <eric.auger@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v4 3/5] iommu/uapi: Use named union for user data
Date: Wed, 8 Jul 2020 08:18:58 -0700 [thread overview]
Message-ID: <20200708081858.37091f4b@jacob-builder> (raw)
In-Reply-To: <3b36c219-4120-402b-b03e-62b076db865c@linux.intel.com>
On Wed, 8 Jul 2020 10:17:57 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:
> Hi Jacob,
>
> On 7/8/20 7:43 AM, Jacob Pan wrote:
> > IOMMU UAPI data size is filled by the user space which must be
> > validated by ther kernel. To ensure backward compatibility, user
> > data can only be extended by either re-purpose padding bytes or
> > extend the variable sized union at the end. No size change is
> > allowed before the union. Therefore, the minimum size is the offset
> > of the union.
> >
> > To use offsetof() on the union, we must make it named.
> >
> > Link:https://lkml.org/lkml/2020/6/11/834
>
> Please use lore.kernel.org links.
>
OK. will do.
> Best regards,
> baolu
[Jacob Pan]
next prev parent reply other threads:[~2020-07-08 15:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 23:43 [PATCH v4 0/5] IOMMU user API enhancement Jacob Pan
2020-07-07 23:43 ` Jacob Pan
2020-07-07 23:43 ` [PATCH v4 1/5] docs: IOMMU user API Jacob Pan
2020-07-07 23:43 ` Jacob Pan
2020-07-08 2:07 ` Lu Baolu
2020-07-08 2:07 ` Lu Baolu
2020-07-08 15:29 ` Jacob Pan
2020-07-08 15:29 ` Jacob Pan
2020-07-09 0:44 ` Lu Baolu
2020-07-09 0:44 ` Lu Baolu
2020-07-13 22:48 ` Alex Williamson
2020-07-13 22:48 ` Alex Williamson
2020-07-14 5:00 ` Jacob Pan
2020-07-14 5:00 ` Jacob Pan
2020-07-14 19:04 ` Alex Williamson
2020-07-14 19:04 ` Alex Williamson
2020-07-14 23:53 ` Jacob Pan
2020-07-14 23:53 ` Jacob Pan
2020-07-15 22:12 ` Jacob Pan
2020-07-15 22:12 ` Jacob Pan
2020-07-07 23:43 ` [PATCH v4 2/5] iommu/uapi: Add argsz for user filled data Jacob Pan
2020-07-07 23:43 ` Jacob Pan
2020-07-07 23:43 ` [PATCH v4 3/5] iommu/uapi: Use named union for user data Jacob Pan
2020-07-07 23:43 ` Jacob Pan
2020-07-08 2:17 ` Lu Baolu
2020-07-08 2:17 ` Lu Baolu
2020-07-08 15:18 ` Jacob Pan [this message]
2020-07-08 15:18 ` Jacob Pan
2020-07-07 23:43 ` [PATCH v4 4/5] iommu/uapi: Handle data and argsz filled by users Jacob Pan
2020-07-07 23:43 ` Jacob Pan
2020-07-07 23:43 ` [PATCH v4 5/5] iommu/vt-d: Remove UAPI version check Jacob Pan
2020-07-07 23:43 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708081858.37091f4b@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=corbet@lwn.net \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.