All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	Raj Ashok <ashok.raj@intel.com>, Jonathan Corbet <corbet@lwn.net>,
	Jean-Philippe Brucker <jean-philippe@linaro.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	iommu@lists.linux-foundation.org,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v4 1/5] docs: IOMMU user API
Date: Wed, 8 Jul 2020 08:29:05 -0700	[thread overview]
Message-ID: <20200708082905.1b5da847@jacob-builder> (raw)
In-Reply-To: <6d01dac0-aa9d-e22b-9baf-28c2f538871a@linux.intel.com>

On Wed, 8 Jul 2020 10:07:13 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:

> Hi,
> 
> On 7/8/20 7:43 AM, Jacob Pan wrote:
> > +For UAPIs that are shared with in-kernel users, a wrapper function
> > +is provided to distinguish the callers. For example,
> > +
> > +Userspace caller ::
> > +
> > +  int iommu_sva_unbind_gpasid(struct iommu_domain *domain, struct
> > device *dev,
> > +  void __user *udata)
> > +
> > +In-kernel caller ::
> > +
> > +  int __iommu_sva_unbind_gpasid(struct iommu_domain *domain,
> > struct device *dev,
> > +  struct iommu_gpasid_bind_data *data)  
> 
> iommu_page_response() may have the same needs. Can we reach an
> agreement on the naming rules?
> 
Yes iommu_page_response() also has to deal with in-kernel and UAPI
callers. I left it out because I thought the current VFIO and SVA common
code is not ready for PRQ yet, I might be reading old news :) argsz
need to be handled as well.

Perhaps we can wait until this set is settled? Do you have a suggestion
on the naming rules?

> Best regards,
> baolu

[Jacob Pan]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: iommu@lists.linux-foundation.org,
	LKML <linux-kernel@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Yi Liu <yi.l.liu@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>,
	Raj Ashok <ashok.raj@intel.com>,
	Christoph Hellwig <hch@infradead.org>,
	Jean-Philippe Brucker <jean-philippe@linaro.com>,
	Eric Auger <eric.auger@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v4 1/5] docs: IOMMU user API
Date: Wed, 8 Jul 2020 08:29:05 -0700	[thread overview]
Message-ID: <20200708082905.1b5da847@jacob-builder> (raw)
In-Reply-To: <6d01dac0-aa9d-e22b-9baf-28c2f538871a@linux.intel.com>

On Wed, 8 Jul 2020 10:07:13 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:

> Hi,
> 
> On 7/8/20 7:43 AM, Jacob Pan wrote:
> > +For UAPIs that are shared with in-kernel users, a wrapper function
> > +is provided to distinguish the callers. For example,
> > +
> > +Userspace caller ::
> > +
> > +  int iommu_sva_unbind_gpasid(struct iommu_domain *domain, struct
> > device *dev,
> > +  void __user *udata)
> > +
> > +In-kernel caller ::
> > +
> > +  int __iommu_sva_unbind_gpasid(struct iommu_domain *domain,
> > struct device *dev,
> > +  struct iommu_gpasid_bind_data *data)  
> 
> iommu_page_response() may have the same needs. Can we reach an
> agreement on the naming rules?
> 
Yes iommu_page_response() also has to deal with in-kernel and UAPI
callers. I left it out because I thought the current VFIO and SVA common
code is not ready for PRQ yet, I might be reading old news :) argsz
need to be handled as well.

Perhaps we can wait until this set is settled? Do you have a suggestion
on the naming rules?

> Best regards,
> baolu

[Jacob Pan]

  reply	other threads:[~2020-07-08 15:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 23:43 [PATCH v4 0/5] IOMMU user API enhancement Jacob Pan
2020-07-07 23:43 ` Jacob Pan
2020-07-07 23:43 ` [PATCH v4 1/5] docs: IOMMU user API Jacob Pan
2020-07-07 23:43   ` Jacob Pan
2020-07-08  2:07   ` Lu Baolu
2020-07-08  2:07     ` Lu Baolu
2020-07-08 15:29     ` Jacob Pan [this message]
2020-07-08 15:29       ` Jacob Pan
2020-07-09  0:44       ` Lu Baolu
2020-07-09  0:44         ` Lu Baolu
2020-07-13 22:48   ` Alex Williamson
2020-07-13 22:48     ` Alex Williamson
2020-07-14  5:00     ` Jacob Pan
2020-07-14  5:00       ` Jacob Pan
2020-07-14 19:04       ` Alex Williamson
2020-07-14 19:04         ` Alex Williamson
2020-07-14 23:53         ` Jacob Pan
2020-07-14 23:53           ` Jacob Pan
2020-07-15 22:12         ` Jacob Pan
2020-07-15 22:12           ` Jacob Pan
2020-07-07 23:43 ` [PATCH v4 2/5] iommu/uapi: Add argsz for user filled data Jacob Pan
2020-07-07 23:43   ` Jacob Pan
2020-07-07 23:43 ` [PATCH v4 3/5] iommu/uapi: Use named union for user data Jacob Pan
2020-07-07 23:43   ` Jacob Pan
2020-07-08  2:17   ` Lu Baolu
2020-07-08  2:17     ` Lu Baolu
2020-07-08 15:18     ` Jacob Pan
2020-07-08 15:18       ` Jacob Pan
2020-07-07 23:43 ` [PATCH v4 4/5] iommu/uapi: Handle data and argsz filled by users Jacob Pan
2020-07-07 23:43   ` Jacob Pan
2020-07-07 23:43 ` [PATCH v4 5/5] iommu/vt-d: Remove UAPI version check Jacob Pan
2020-07-07 23:43   ` Jacob Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708082905.1b5da847@jacob-builder \
    --to=jacob.jun.pan@linux.intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=dwmw2@infradead.org \
    --cc=hch@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jean-philippe@linaro.com \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.