* [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues
@ 2020-07-18 9:16 B K Karthik
2020-07-18 11:36 ` kernel test robot
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: B K Karthik @ 2020-07-18 9:16 UTC (permalink / raw)
To: Larry Finger, Greg Kroah-Hartman, Michael Straube, devel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 5157 bytes --]
fixed multiple parentheses coding style issues reported by checkpatch.
Signed-off-by: B K Karthik <karthik.bk2000@live.com>
---
drivers/staging/rtl8188eu/include/ieee80211.h | 4 +--
.../staging/rtl8188eu/include/osdep_service.h | 4 +--
drivers/staging/rtl8188eu/include/wifi.h | 34 +++++++++----------
3 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h b/drivers/staging/rtl8188eu/include/ieee80211.h
index 83218e7ec0a9..a872a86f89ab 100644
--- a/drivers/staging/rtl8188eu/include/ieee80211.h
+++ b/drivers/staging/rtl8188eu/include/ieee80211.h
@@ -646,8 +646,8 @@ struct rtw_ieee80211_channel {
"flags:0x%08x" \
#define CHAN_ARG(channel) \
- (channel)->hw_value \
- , (channel)->flags \
+ ((channel)->hw_value \
+ , (channel)->flags)
/* Parsed Information Elements */
struct rtw_ieee802_11_elems {
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h
index 31d897f1d21f..2245cc430981 100644
--- a/drivers/staging/rtl8188eu/include/osdep_service.h
+++ b/drivers/staging/rtl8188eu/include/osdep_service.h
@@ -76,9 +76,9 @@ struct net_device *rtw_alloc_etherdev_with_old_priv(void *old_priv);
void rtw_free_netdev(struct net_device *netdev);
#define FUNC_NDEV_FMT "%s(%s)"
-#define FUNC_NDEV_ARG(ndev) __func__, ndev->name
+#define FUNC_NDEV_ARG(ndev) (__func__, (ndev)->name)
#define FUNC_ADPT_FMT "%s(%s)"
-#define FUNC_ADPT_ARG(adapter) __func__, adapter->pnetdev->name
+#define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name)
/* Macros for handling unaligned memory accesses */
diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/include/wifi.h
index 791f287a546d..677827900607 100644
--- a/drivers/staging/rtl8188eu/include/wifi.h
+++ b/drivers/staging/rtl8188eu/include/wifi.h
@@ -143,57 +143,57 @@ enum WIFI_REG_DOMAIN {
#define _ORDER_ BIT(15)
#define SetToDs(pbuf) \
- *(__le16 *)(pbuf) |= cpu_to_le16(_TO_DS_)
+ (*(__le16 *)(pbuf) |= cpu_to_le16(_TO_DS_))
#define GetToDs(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_TO_DS_)) != 0)
#define ClearToDs(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_TO_DS_))
+ (*(__le16 *)(pbuf) &= (~cpu_to_le16(_TO_DS_)))
#define SetFrDs(pbuf) \
- *(__le16 *)(pbuf) |= cpu_to_le16(_FROM_DS_)
+ (*(__le16 *)(pbuf) |= cpu_to_le16(_FROM_DS_))
#define GetFrDs(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_FROM_DS_)) != 0)
#define ClearFrDs(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_FROM_DS_))
+ (*(__le16 *)(pbuf) &= (~cpu_to_le16(_FROM_DS_)))
#define get_tofr_ds(pframe) ((GetToDs(pframe) << 1) | GetFrDs(pframe))
#define SetMFrag(pbuf) \
- *(__le16 *)(pbuf) |= cpu_to_le16(_MORE_FRAG_)
+ (*(__le16 *)(pbuf) |= cpu_to_le16(_MORE_FRAG_))
#define GetMFrag(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_MORE_FRAG_)) != 0)
#define ClearMFrag(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_MORE_FRAG_))
+ (*(__le16 *)(pbuf) &= (~cpu_to_le16(_MORE_FRAG_)))
#define SetRetry(pbuf) \
- *(__le16 *)(pbuf) |= cpu_to_le16(_RETRY_)
+ (*(__le16 *)(pbuf) |= cpu_to_le16(_RETRY_))
#define GetRetry(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_RETRY_)) != 0)
#define ClearRetry(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_RETRY_))
+ (*(__le16 *)(pbuf) &= (~cpu_to_le16(_RETRY_)))
#define SetPwrMgt(pbuf) \
- *(__le16 *)(pbuf) |= cpu_to_le16(_PWRMGT_)
+ (*(__le16 *)(pbuf) |= cpu_to_le16(_PWRMGT_))
#define GetPwrMgt(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_PWRMGT_)) != 0)
#define ClearPwrMgt(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_PWRMGT_))
+ (*(__le16 *)(pbuf) &= (~cpu_to_le16(_PWRMGT_)))
#define SetMData(pbuf) \
- *(__le16 *)(pbuf) |= cpu_to_le16(_MORE_DATA_)
+ (*(__le16 *)(pbuf) |= cpu_to_le16(_MORE_DATA_))
#define GetMData(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_MORE_DATA_)) != 0)
#define ClearMData(pbuf) \
- *(__le16 *)(pbuf) &= (~cpu_to_le16(_MORE_DATA_))
+ (*(__le16 *)(pbuf) &= (~cpu_to_le16(_MORE_DATA_)))
#define SetPrivacy(pbuf) \
- *(__le16 *)(pbuf) |= cpu_to_le16(_PRIVACY_)
+ (*(__le16 *)(pbuf) |= cpu_to_le16(_PRIVACY_))
#define GetPrivacy(pbuf) \
(((*(__le16 *)(pbuf)) & cpu_to_le16(_PRIVACY_)) != 0)
@@ -228,18 +228,18 @@ enum WIFI_REG_DOMAIN {
} while (0)
#define SetDuration(pbuf, dur) \
- *(__le16 *)((size_t)(pbuf) + 2) = cpu_to_le16(0xffff & (dur))
+ (*(__le16 *)((size_t)(pbuf) + 2) = cpu_to_le16(0xffff & (dur)))
#define SetPriority(pbuf, tid) \
- *(__le16 *)(pbuf) |= cpu_to_le16(tid & 0xf)
+ (*(__le16 *)(pbuf) |= cpu_to_le16(tid & 0xf))
#define GetPriority(pbuf) ((le16_to_cpu(*(__le16 *)(pbuf))) & 0xf)
#define SetEOSP(pbuf, eosp) \
- *(__le16 *)(pbuf) |= cpu_to_le16((eosp & 1) << 4)
+ (*(__le16 *)(pbuf) |= cpu_to_le16((eosp & 1) << 4))
#define SetAckpolicy(pbuf, ack) \
- *(__le16 *)(pbuf) |= cpu_to_le16((ack & 3) << 5)
+ (*(__le16 *)(pbuf) |= cpu_to_le16((ack & 3) << 5))
#define GetAckpolicy(pbuf) (((le16_to_cpu(*(__le16 *)pbuf)) >> 5) & 0x3)
--
2.20.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues 2020-07-18 9:16 [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues B K Karthik @ 2020-07-18 11:36 ` kernel test robot 2020-07-18 16:07 ` kernel test robot 2020-07-19 9:26 ` Greg Kroah-Hartman 2 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2020-07-18 11:36 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 27434 bytes --] Hi K, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/B-K-Karthik/staging-rtl8188eu-include-fixed-multiple-blank-space-coding-style-issues/20200718-172103 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9d5d041eebe3dcf7591ff7004896c329eb841ca6 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from arch/m68k/include/asm/io_mm.h:25, from arch/m68k/include/asm/io.h:8, from include/linux/scatterlist.h:9, from include/linux/dma-mapping.h:11, from include/linux/skbuff.h:31, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_ap.c:9: arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb': arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable] 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8' 430 | rom_out_8(port, *buf++); | ^~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw': arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16' 448 | rom_out_be16(port, *buf++); | ^~~~~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw': arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_ap.c:9: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from include/linux/seqlock.h:36, from include/linux/time.h:6, from include/linux/skbuff.h:15, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_ap.c:9: include/linux/dma-mapping.h: In function 'dma_map_resource': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE' 144 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid' 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid' 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) | ^~~~~~~~~ In file included from include/linux/kernel.h:15, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_ap.c:9: drivers/staging/rtl8188eu/core/rtw_ap.c: In function 'rtw_sta_flush': drivers/staging/rtl8188eu/include/osdep_service.h:79:38: warning: left-hand operand of comma expression has no effect [-Wunused-value] 79 | #define FUNC_NDEV_ARG(ndev) (__func__, (ndev)->name) | ^ include/linux/printk.h:368:34: note: in definition of macro 'pr_info' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_ap.c:1606:2: note: in expansion of macro 'DBG_88E' 1606 | DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_ap.c:1606:29: note: in expansion of macro 'FUNC_NDEV_ARG' 1606 | DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); | ^~~~~~~~~~~~~ In file included from include/linux/printk.h:7, from include/linux/kernel.h:15, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_ap.c:9: >> include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:368:9: note: in expansion of macro 'KERN_INFO' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:4: note: in expansion of macro 'pr_info' 70 | pr_info(DRIVER_PREFIX __VA_ARGS__); \ | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_ap.c:1606:2: note: in expansion of macro 'DBG_88E' 1606 | DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); | ^~~~~~~ In file included from drivers/staging/rtl8188eu/core/rtw_ap.c:11: drivers/staging/rtl8188eu/include/osdep_service.h:78:28: note: format string is defined here 78 | #define FUNC_NDEV_FMT "%s(%s)" | ~^ | | | char * In file included from drivers/staging/rtl8188eu/include/drv_types.h:41, from drivers/staging/rtl8188eu/core/rtw_ap.c:12: At top level: drivers/staging/rtl8188eu/include/rtw_mlme_ext.h:177:3: warning: 'channel_table' defined but not used [-Wunused-const-variable=] 177 | } channel_table[] = { { RT_CHANNEL_DOMAIN_FCC, "US" }, | ^~~~~~~~~~~~~ In file included from drivers/staging/rtl8188eu/include/drv_types.h:26, from drivers/staging/rtl8188eu/core/rtw_ap.c:12: drivers/staging/rtl8188eu/include/rtw_security.h:260:28: warning: 'K' defined but not used [-Wunused-const-variable=] 260 | static const unsigned long K[64] = { | ^ -- In file included from arch/m68k/include/asm/io_mm.h:25, from arch/m68k/include/asm/io.h:8, from include/linux/scatterlist.h:9, from include/linux/dma-mapping.h:11, from include/linux/skbuff.h:31, from include/linux/if_ether.h:19, from include/uapi/linux/ethtool.h:19, from include/linux/ethtool.h:18, from include/linux/netdevice.h:37, from drivers/staging/rtl8188eu/include/osdep_service.h:23, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb': arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable] 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8' 430 | rom_out_8(port, *buf++); | ^~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw': arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16' 448 | rom_out_be16(port, *buf++); | ^~~~~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw': arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/preempt.h:11, from include/linux/spinlock.h:51, from drivers/staging/rtl8188eu/include/osdep_service.h:16, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from drivers/staging/rtl8188eu/include/osdep_service.h:16, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: include/linux/dma-mapping.h: In function 'dma_map_resource': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE' 144 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid' 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid' 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) | ^~~~~~~~~ In file included from include/linux/kernel.h:15, from include/linux/list.h:9, from include/linux/preempt.h:11, from include/linux/spinlock.h:51, from drivers/staging/rtl8188eu/include/osdep_service.h:16, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: drivers/staging/rtl8188eu/core/rtw_ioctl_set.c: In function 'rtw_set_802_11_bssid_list_scan': drivers/staging/rtl8188eu/include/osdep_service.h:81:41: warning: left-hand operand of comma expression has no effect [-Wunused-value] 81 | #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) | ^ include/linux/printk.h:368:34: note: in definition of macro 'pr_info' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:427:4: note: in expansion of macro 'DBG_88E' 427 | DBG_88E(FUNC_ADPT_FMT": scan deny\n", FUNC_ADPT_ARG(padapter)); | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:427:42: note: in expansion of macro 'FUNC_ADPT_ARG' 427 | DBG_88E(FUNC_ADPT_FMT": scan deny\n", FUNC_ADPT_ARG(padapter)); | ^~~~~~~~~~~~~ In file included from include/linux/printk.h:7, from include/linux/kernel.h:15, from include/linux/list.h:9, from include/linux/preempt.h:11, from include/linux/spinlock.h:51, from drivers/staging/rtl8188eu/include/osdep_service.h:16, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: >> include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:368:9: note: in expansion of macro 'KERN_INFO' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:4: note: in expansion of macro 'pr_info' 70 | pr_info(DRIVER_PREFIX __VA_ARGS__); \ | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:427:4: note: in expansion of macro 'DBG_88E' 427 | DBG_88E(FUNC_ADPT_FMT": scan deny\n", FUNC_ADPT_ARG(padapter)); | ^~~~~~~ In file included from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: drivers/staging/rtl8188eu/include/osdep_service.h:80:28: note: format string is defined here 80 | #define FUNC_ADPT_FMT "%s(%s)" | ~^ | | | char * In file included from drivers/staging/rtl8188eu/include/drv_types.h:26, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:10: At top level: drivers/staging/rtl8188eu/include/rtw_security.h:260:28: warning: 'K' defined but not used [-Wunused-const-variable=] 260 | static const unsigned long K[64] = { | ^ -- In file included from arch/m68k/include/asm/io_mm.h:25, from arch/m68k/include/asm/io.h:8, from include/linux/scatterlist.h:9, from include/linux/dma-mapping.h:11, from include/linux/skbuff.h:31, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb': arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable] 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8' 430 | rom_out_8(port, *buf++); | ^~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw': arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16' 448 | rom_out_be16(port, *buf++); | ^~~~~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw': arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from include/linux/seqlock.h:36, from include/linux/time.h:6, from include/linux/skbuff.h:15, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: include/linux/dma-mapping.h: In function 'dma_map_resource': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE' 144 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid' 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid' 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) | ^~~~~~~~~ In file included from include/linux/kernel.h:15, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: drivers/staging/rtl8188eu/core/rtw_mlme.c: In function 'rtw_scan_timeout_handler': drivers/staging/rtl8188eu/include/osdep_service.h:81:41: warning: left-hand operand of comma expression has no effect [-Wunused-value] 81 | #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) | ^ include/linux/printk.h:368:34: note: in definition of macro 'pr_info' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:2: note: in expansion of macro 'DBG_88E' 1345 | DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:41: note: in expansion of macro 'FUNC_ADPT_ARG' 1345 | DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); | ^~~~~~~~~~~~~ In file included from include/linux/printk.h:7, from include/linux/kernel.h:15, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: >> include/linux/kern_levels.h:5:18: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:368:9: note: in expansion of macro 'KERN_INFO' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:4: note: in expansion of macro 'pr_info' 70 | pr_info(DRIVER_PREFIX __VA_ARGS__); \ | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:2: note: in expansion of macro 'DBG_88E' 1345 | DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); | ^~~~~~~ In file included from drivers/staging/rtl8188eu/core/rtw_mlme.c:11: drivers/staging/rtl8188eu/include/osdep_service.h:80:28: note: format string is defined here 80 | #define FUNC_ADPT_FMT "%s(%s)" | ~^ | | | char * | %d In file included from include/linux/printk.h:7, from include/linux/kernel.h:15, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: >> include/linux/kern_levels.h:5:18: warning: format '%x' expects a matching 'unsigned int' argument [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:368:9: note: in expansion of macro 'KERN_INFO' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:4: note: in expansion of macro 'pr_info' 70 | pr_info(DRIVER_PREFIX __VA_ARGS__); \ | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:2: note: in expansion of macro 'DBG_88E' 1345 | DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:35: note: format string is defined here 1345 | DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); | ~^ | | | unsigned int In file included from drivers/staging/rtl8188eu/include/drv_types.h:41, from drivers/staging/rtl8188eu/core/rtw_mlme.c:12: At top level: drivers/staging/rtl8188eu/include/rtw_mlme_ext.h:177:3: warning: 'channel_table' defined but not used [-Wunused-const-variable=] 177 | } channel_table[] = { { RT_CHANNEL_DOMAIN_FCC, "US" }, | ^~~~~~~~~~~~~ In file included from drivers/staging/rtl8188eu/include/drv_types.h:26, from drivers/staging/rtl8188eu/core/rtw_mlme.c:12: drivers/staging/rtl8188eu/include/rtw_security.h:260:28: warning: 'K' defined but not used [-Wunused-const-variable=] 260 | static const unsigned long K[64] = { | ^ .. vim +5 include/linux/kern_levels.h 314ba3520e513a Joe Perches 2012-07-30 4 04d2c8c83d0e3a Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c83d0e3a Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c83d0e3a Joe Perches 2012-07-30 7 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 57301 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues @ 2020-07-18 11:36 ` kernel test robot 0 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2020-07-18 11:36 UTC (permalink / raw) To: B K Karthik, Larry Finger, Greg Kroah-Hartman, Michael Straube, devel, linux-kernel Cc: kbuild-all [-- Attachment #1: Type: text/plain, Size: 26986 bytes --] Hi K, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/B-K-Karthik/staging-rtl8188eu-include-fixed-multiple-blank-space-coding-style-issues/20200718-172103 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9d5d041eebe3dcf7591ff7004896c329eb841ca6 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from arch/m68k/include/asm/io_mm.h:25, from arch/m68k/include/asm/io.h:8, from include/linux/scatterlist.h:9, from include/linux/dma-mapping.h:11, from include/linux/skbuff.h:31, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_ap.c:9: arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb': arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable] 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8' 430 | rom_out_8(port, *buf++); | ^~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw': arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16' 448 | rom_out_be16(port, *buf++); | ^~~~~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw': arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_ap.c:9: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from include/linux/seqlock.h:36, from include/linux/time.h:6, from include/linux/skbuff.h:15, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_ap.c:9: include/linux/dma-mapping.h: In function 'dma_map_resource': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE' 144 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid' 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid' 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) | ^~~~~~~~~ In file included from include/linux/kernel.h:15, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_ap.c:9: drivers/staging/rtl8188eu/core/rtw_ap.c: In function 'rtw_sta_flush': drivers/staging/rtl8188eu/include/osdep_service.h:79:38: warning: left-hand operand of comma expression has no effect [-Wunused-value] 79 | #define FUNC_NDEV_ARG(ndev) (__func__, (ndev)->name) | ^ include/linux/printk.h:368:34: note: in definition of macro 'pr_info' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_ap.c:1606:2: note: in expansion of macro 'DBG_88E' 1606 | DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_ap.c:1606:29: note: in expansion of macro 'FUNC_NDEV_ARG' 1606 | DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); | ^~~~~~~~~~~~~ In file included from include/linux/printk.h:7, from include/linux/kernel.h:15, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_ap.c:9: >> include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:368:9: note: in expansion of macro 'KERN_INFO' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:4: note: in expansion of macro 'pr_info' 70 | pr_info(DRIVER_PREFIX __VA_ARGS__); \ | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_ap.c:1606:2: note: in expansion of macro 'DBG_88E' 1606 | DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); | ^~~~~~~ In file included from drivers/staging/rtl8188eu/core/rtw_ap.c:11: drivers/staging/rtl8188eu/include/osdep_service.h:78:28: note: format string is defined here 78 | #define FUNC_NDEV_FMT "%s(%s)" | ~^ | | | char * In file included from drivers/staging/rtl8188eu/include/drv_types.h:41, from drivers/staging/rtl8188eu/core/rtw_ap.c:12: At top level: drivers/staging/rtl8188eu/include/rtw_mlme_ext.h:177:3: warning: 'channel_table' defined but not used [-Wunused-const-variable=] 177 | } channel_table[] = { { RT_CHANNEL_DOMAIN_FCC, "US" }, | ^~~~~~~~~~~~~ In file included from drivers/staging/rtl8188eu/include/drv_types.h:26, from drivers/staging/rtl8188eu/core/rtw_ap.c:12: drivers/staging/rtl8188eu/include/rtw_security.h:260:28: warning: 'K' defined but not used [-Wunused-const-variable=] 260 | static const unsigned long K[64] = { | ^ -- In file included from arch/m68k/include/asm/io_mm.h:25, from arch/m68k/include/asm/io.h:8, from include/linux/scatterlist.h:9, from include/linux/dma-mapping.h:11, from include/linux/skbuff.h:31, from include/linux/if_ether.h:19, from include/uapi/linux/ethtool.h:19, from include/linux/ethtool.h:18, from include/linux/netdevice.h:37, from drivers/staging/rtl8188eu/include/osdep_service.h:23, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb': arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable] 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8' 430 | rom_out_8(port, *buf++); | ^~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw': arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16' 448 | rom_out_be16(port, *buf++); | ^~~~~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw': arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/preempt.h:11, from include/linux/spinlock.h:51, from drivers/staging/rtl8188eu/include/osdep_service.h:16, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from drivers/staging/rtl8188eu/include/osdep_service.h:16, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: include/linux/dma-mapping.h: In function 'dma_map_resource': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE' 144 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid' 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid' 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) | ^~~~~~~~~ In file included from include/linux/kernel.h:15, from include/linux/list.h:9, from include/linux/preempt.h:11, from include/linux/spinlock.h:51, from drivers/staging/rtl8188eu/include/osdep_service.h:16, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: drivers/staging/rtl8188eu/core/rtw_ioctl_set.c: In function 'rtw_set_802_11_bssid_list_scan': drivers/staging/rtl8188eu/include/osdep_service.h:81:41: warning: left-hand operand of comma expression has no effect [-Wunused-value] 81 | #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) | ^ include/linux/printk.h:368:34: note: in definition of macro 'pr_info' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:427:4: note: in expansion of macro 'DBG_88E' 427 | DBG_88E(FUNC_ADPT_FMT": scan deny\n", FUNC_ADPT_ARG(padapter)); | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:427:42: note: in expansion of macro 'FUNC_ADPT_ARG' 427 | DBG_88E(FUNC_ADPT_FMT": scan deny\n", FUNC_ADPT_ARG(padapter)); | ^~~~~~~~~~~~~ In file included from include/linux/printk.h:7, from include/linux/kernel.h:15, from include/linux/list.h:9, from include/linux/preempt.h:11, from include/linux/spinlock.h:51, from drivers/staging/rtl8188eu/include/osdep_service.h:16, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: >> include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:368:9: note: in expansion of macro 'KERN_INFO' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:4: note: in expansion of macro 'pr_info' 70 | pr_info(DRIVER_PREFIX __VA_ARGS__); \ | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:427:4: note: in expansion of macro 'DBG_88E' 427 | DBG_88E(FUNC_ADPT_FMT": scan deny\n", FUNC_ADPT_ARG(padapter)); | ^~~~~~~ In file included from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:9: drivers/staging/rtl8188eu/include/osdep_service.h:80:28: note: format string is defined here 80 | #define FUNC_ADPT_FMT "%s(%s)" | ~^ | | | char * In file included from drivers/staging/rtl8188eu/include/drv_types.h:26, from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:10: At top level: drivers/staging/rtl8188eu/include/rtw_security.h:260:28: warning: 'K' defined but not used [-Wunused-const-variable=] 260 | static const unsigned long K[64] = { | ^ -- In file included from arch/m68k/include/asm/io_mm.h:25, from arch/m68k/include/asm/io.h:8, from include/linux/scatterlist.h:9, from include/linux/dma-mapping.h:11, from include/linux/skbuff.h:31, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb': arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable] 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8' 430 | rom_out_8(port, *buf++); | ^~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw': arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16' 448 | rom_out_be16(port, *buf++); | ^~~~~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw': arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from include/linux/seqlock.h:36, from include/linux/time.h:6, from include/linux/skbuff.h:15, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: include/linux/dma-mapping.h: In function 'dma_map_resource': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/asm-generic/bug.h:144:27: note: in definition of macro 'WARN_ON_ONCE' 144 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid' 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid' 352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) | ^~~~~~~~~ In file included from include/linux/kernel.h:15, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: drivers/staging/rtl8188eu/core/rtw_mlme.c: In function 'rtw_scan_timeout_handler': drivers/staging/rtl8188eu/include/osdep_service.h:81:41: warning: left-hand operand of comma expression has no effect [-Wunused-value] 81 | #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) | ^ include/linux/printk.h:368:34: note: in definition of macro 'pr_info' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:2: note: in expansion of macro 'DBG_88E' 1345 | DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:41: note: in expansion of macro 'FUNC_ADPT_ARG' 1345 | DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); | ^~~~~~~~~~~~~ In file included from include/linux/printk.h:7, from include/linux/kernel.h:15, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: >> include/linux/kern_levels.h:5:18: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:368:9: note: in expansion of macro 'KERN_INFO' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:4: note: in expansion of macro 'pr_info' 70 | pr_info(DRIVER_PREFIX __VA_ARGS__); \ | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:2: note: in expansion of macro 'DBG_88E' 1345 | DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); | ^~~~~~~ In file included from drivers/staging/rtl8188eu/core/rtw_mlme.c:11: drivers/staging/rtl8188eu/include/osdep_service.h:80:28: note: format string is defined here 80 | #define FUNC_ADPT_FMT "%s(%s)" | ~^ | | | char * | %d In file included from include/linux/printk.h:7, from include/linux/kernel.h:15, from include/linux/skbuff.h:13, from include/linux/if_ether.h:19, from include/linux/ieee80211.h:19, from drivers/staging/rtl8188eu/core/rtw_mlme.c:9: >> include/linux/kern_levels.h:5:18: warning: format '%x' expects a matching 'unsigned int' argument [-Wformat=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' 14 | #define KERN_INFO KERN_SOH "6" /* informational */ | ^~~~~~~~ include/linux/printk.h:368:9: note: in expansion of macro 'KERN_INFO' 368 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:4: note: in expansion of macro 'pr_info' 70 | pr_info(DRIVER_PREFIX __VA_ARGS__); \ | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:2: note: in expansion of macro 'DBG_88E' 1345 | DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); | ^~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:35: note: format string is defined here 1345 | DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); | ~^ | | | unsigned int In file included from drivers/staging/rtl8188eu/include/drv_types.h:41, from drivers/staging/rtl8188eu/core/rtw_mlme.c:12: At top level: drivers/staging/rtl8188eu/include/rtw_mlme_ext.h:177:3: warning: 'channel_table' defined but not used [-Wunused-const-variable=] 177 | } channel_table[] = { { RT_CHANNEL_DOMAIN_FCC, "US" }, | ^~~~~~~~~~~~~ In file included from drivers/staging/rtl8188eu/include/drv_types.h:26, from drivers/staging/rtl8188eu/core/rtw_mlme.c:12: drivers/staging/rtl8188eu/include/rtw_security.h:260:28: warning: 'K' defined but not used [-Wunused-const-variable=] 260 | static const unsigned long K[64] = { | ^ .. vim +5 include/linux/kern_levels.h 314ba3520e513a Joe Perches 2012-07-30 4 04d2c8c83d0e3a Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c83d0e3a Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c83d0e3a Joe Perches 2012-07-30 7 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 57301 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues 2020-07-18 9:16 [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues B K Karthik @ 2020-07-18 16:07 ` kernel test robot 2020-07-18 16:07 ` kernel test robot 2020-07-19 9:26 ` Greg Kroah-Hartman 2 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2020-07-18 16:07 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 37681 bytes --] Hi K, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/B-K-Karthik/staging-rtl8188eu-include-fixed-multiple-blank-space-coding-style-issues/20200718-172103 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9d5d041eebe3dcf7591ff7004896c329eb841ca6 config: x86_64-allyesconfig (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ed6b578040a85977026c93bf4188f996148f3218) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/staging/rtl8188eu/core/rtw_ap.c:1606:29: warning: expression result unused [-Wunused-value] DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:79:30: note: expanded from macro 'FUNC_NDEV_ARG' #define FUNC_NDEV_ARG(ndev) (__func__, (ndev)->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_ap.c:1606:10: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); ^~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:78:28: note: expanded from macro 'FUNC_NDEV_FMT' #define FUNC_NDEV_FMT "%s(%s)" ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ 2 warnings generated. -- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:427:42: warning: expression result unused [-Wunused-value] DBG_88E(FUNC_ADPT_FMT": scan deny\n", FUNC_ADPT_ARG(padapter)); ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:427:12: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT": scan deny\n", FUNC_ADPT_ARG(padapter)); ^~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:80:28: note: expanded from macro 'FUNC_ADPT_FMT' #define FUNC_ADPT_FMT "%s(%s)" ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ 2 warnings generated. -- drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:41: warning: expression result unused [-Wunused-value] DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); ^~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:65: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat] DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); ~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:35: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ 3 warnings generated. -- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:720:5: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(padapter), da, rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:720:34: warning: format specifies type 'void *' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] FUNC_ADPT_ARG(padapter), da, rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:721:5: warning: format specifies type 'unsigned int' but the argument has type 'char *' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:721:39: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:719:54: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT" to %pM, ch:%u%s, %d/%d in %u ms\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:725:5: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(padapter), rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:725:30: warning: format specifies type 'char *' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] FUNC_ADPT_ARG(padapter), rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:726:5: warning: format specifies type 'unsigned int' but the argument has type 'char *' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:726:39: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:724:47: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT", ch:%u%s, %d/%d in %u ms\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1289:5: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(padapter), da, rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1289:34: warning: format specifies type 'void *' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] FUNC_ADPT_ARG(padapter), da, rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1290:5: warning: format specifies type 'unsigned int' but the argument has type 'char *' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1290:39: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1288:54: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT" to %pM, ch:%u%s, %d/%d in %u ms\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1294:5: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(padapter), rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) -- ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1531:5: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(padapter), rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1531:30: warning: format specifies type 'char *' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] FUNC_ADPT_ARG(padapter), rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1532:5: warning: format specifies type 'unsigned int' but the argument has type 'char *' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1532:39: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1530:47: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT", ch:%u%s, %d/%d in %u ms\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3536:29: warning: expression result unused [-Wunused-value] DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:79:30: note: expanded from macro 'FUNC_NDEV_ARG' #define FUNC_NDEV_ARG(ndev) (__func__, (ndev)->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3536:10: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); ^~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:78:28: note: expanded from macro 'FUNC_NDEV_FMT' #define FUNC_NDEV_FMT "%s(%s)" ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3669:6: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(adapter), seq_ctrl, mlmeext->action_public_rxseq, token); ^~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3669:30: warning: format specifies type 'char *' but the argument has type 'u16' (aka 'unsigned short') [-Wformat] FUNC_ADPT_ARG(adapter), seq_ctrl, mlmeext->action_public_rxseq, token); ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3668:66: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT" seq_ctrl = 0x%x, rxseq = 0x%x, token:%d\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3675:6: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(adapter), seq_ctrl, mlmeext->action_public_rxseq); ^~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3675:30: warning: format specifies type 'char *' but the argument has type 'u16' (aka 'unsigned short') [-Wformat] FUNC_ADPT_ARG(adapter), seq_ctrl, mlmeext->action_public_rxseq); ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3674:56: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT" seq_ctrl = 0x%x, rxseq = 0x%x\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4692:34: warning: more '%' conversions than data arguments [-Wformat] DBG_88E_LEVEL(_drv_always_, FUNC_ADPT_FMT" disconnect or roaming\n", ^~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:80:28: note: expanded from macro 'FUNC_ADPT_FMT' #define FUNC_ADPT_FMT "%s(%s)" ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:64:26: note: expanded from macro 'DBG_88E_LEVEL' pr_info(DRIVER_PREFIX fmt, ##arg); \ ^~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5451:3: warning: expression result unused [-Wunused-value] FUNC_NDEV_ARG(padapter->pnetdev), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:79:30: note: expanded from macro 'FUNC_NDEV_ARG' #define FUNC_NDEV_ARG(ndev) (__func__, (ndev)->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5452:3: warning: format specifies type 'char *' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] set_ch_parm->ch, set_ch_parm->bw, set_ch_parm->ch_offset); ^~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5450:50: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_NDEV_FMT" ch:%u, bw:%u, ch_offset:%u\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt vim +1606 drivers/staging/rtl8188eu/core/rtw_ap.c 9a7fe54ddc3a70 Larry Finger 2013-08-21 1596 9a7fe54ddc3a70 Larry Finger 2013-08-21 1597 int rtw_sta_flush(struct adapter *padapter) 9a7fe54ddc3a70 Larry Finger 2013-08-21 1598 { 9a7fe54ddc3a70 Larry Finger 2013-08-21 1599 struct list_head *phead, *plist; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1600 struct sta_info *psta = NULL; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1601 struct sta_priv *pstapriv = &padapter->stapriv; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1602 struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; 8943880eff435a Scott Matheina 2017-01-05 1603 struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1604 u8 bc_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1605 9a7fe54ddc3a70 Larry Finger 2013-08-21 @1606 DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1607 9a7fe54ddc3a70 Larry Finger 2013-08-21 1608 if ((pmlmeinfo->state & 0x03) != WIFI_FW_AP_STATE) 9cc56fa8276520 Heena Sirwani 2014-10-06 1609 return 0; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1610 7057dcb3afa294 Larry Finger 2013-12-19 1611 spin_lock_bh(&pstapriv->asoc_list_lock); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1612 phead = &pstapriv->asoc_list; c44e5e39c3d168 Larry Finger 2014-02-09 1613 plist = phead->next; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1614 9a7fe54ddc3a70 Larry Finger 2013-08-21 1615 /* free sta asoc_queue */ 84660700807cbc navin patidar 2014-06-22 1616 while (phead != plist) { bea8810043b9a6 Larry Finger 2014-02-09 1617 psta = container_of(plist, struct sta_info, asoc_list); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1618 c44e5e39c3d168 Larry Finger 2014-02-09 1619 plist = plist->next; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1620 8d5bdece42d9cb navin patidar 2014-06-22 1621 list_del_init(&psta->asoc_list); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1622 pstapriv->asoc_list_cnt--; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1623 9a7fe54ddc3a70 Larry Finger 2013-08-21 1624 ap_free_sta(padapter, psta, true, WLAN_REASON_DEAUTH_LEAVING); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1625 } e02bcf6126fa59 Larry Finger 2013-12-19 1626 spin_unlock_bh(&pstapriv->asoc_list_lock); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1627 9a7fe54ddc3a70 Larry Finger 2013-08-21 1628 issue_deauth(padapter, bc_addr, WLAN_REASON_DEAUTH_LEAVING); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1629 9a7fe54ddc3a70 Larry Finger 2013-08-21 1630 associated_clients_update(padapter, true); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1631 9cc56fa8276520 Heena Sirwani 2014-10-06 1632 return 0; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1633 } 9a7fe54ddc3a70 Larry Finger 2013-08-21 1634 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 75379 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues @ 2020-07-18 16:07 ` kernel test robot 0 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2020-07-18 16:07 UTC (permalink / raw) To: B K Karthik, Larry Finger, Greg Kroah-Hartman, Michael Straube, devel, linux-kernel Cc: kbuild-all, clang-built-linux [-- Attachment #1: Type: text/plain, Size: 37151 bytes --] Hi K, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/B-K-Karthik/staging-rtl8188eu-include-fixed-multiple-blank-space-coding-style-issues/20200718-172103 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9d5d041eebe3dcf7591ff7004896c329eb841ca6 config: x86_64-allyesconfig (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ed6b578040a85977026c93bf4188f996148f3218) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/staging/rtl8188eu/core/rtw_ap.c:1606:29: warning: expression result unused [-Wunused-value] DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:79:30: note: expanded from macro 'FUNC_NDEV_ARG' #define FUNC_NDEV_ARG(ndev) (__func__, (ndev)->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_ap.c:1606:10: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); ^~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:78:28: note: expanded from macro 'FUNC_NDEV_FMT' #define FUNC_NDEV_FMT "%s(%s)" ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ 2 warnings generated. -- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:427:42: warning: expression result unused [-Wunused-value] DBG_88E(FUNC_ADPT_FMT": scan deny\n", FUNC_ADPT_ARG(padapter)); ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_ioctl_set.c:427:12: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT": scan deny\n", FUNC_ADPT_ARG(padapter)); ^~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:80:28: note: expanded from macro 'FUNC_ADPT_FMT' #define FUNC_ADPT_FMT "%s(%s)" ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ 2 warnings generated. -- drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:41: warning: expression result unused [-Wunused-value] DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); ^~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:65: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat] DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); ~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme.c:1345:35: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT" fw_state=%x\n", FUNC_ADPT_ARG(adapter), get_fwstate(pmlmepriv)); ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ 3 warnings generated. -- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:720:5: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(padapter), da, rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:720:34: warning: format specifies type 'void *' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] FUNC_ADPT_ARG(padapter), da, rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:721:5: warning: format specifies type 'unsigned int' but the argument has type 'char *' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:721:39: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:719:54: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT" to %pM, ch:%u%s, %d/%d in %u ms\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:725:5: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(padapter), rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:725:30: warning: format specifies type 'char *' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] FUNC_ADPT_ARG(padapter), rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:726:5: warning: format specifies type 'unsigned int' but the argument has type 'char *' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:726:39: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:724:47: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT", ch:%u%s, %d/%d in %u ms\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1289:5: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(padapter), da, rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1289:34: warning: format specifies type 'void *' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] FUNC_ADPT_ARG(padapter), da, rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1290:5: warning: format specifies type 'unsigned int' but the argument has type 'char *' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1290:39: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1288:54: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT" to %pM, ch:%u%s, %d/%d in %u ms\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1294:5: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(padapter), rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) -- ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1531:5: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(padapter), rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1531:30: warning: format specifies type 'char *' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] FUNC_ADPT_ARG(padapter), rtw_get_oper_ch(padapter), ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1532:5: warning: format specifies type 'unsigned int' but the argument has type 'char *' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1532:39: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat] ret == _SUCCESS ? ", acked" : "", i, try_cnt, ^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1530:47: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT", ch:%u%s, %d/%d in %u ms\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3536:29: warning: expression result unused [-Wunused-value] DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:79:30: note: expanded from macro 'FUNC_NDEV_ARG' #define FUNC_NDEV_ARG(ndev) (__func__, (ndev)->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3536:10: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); ^~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:78:28: note: expanded from macro 'FUNC_NDEV_FMT' #define FUNC_NDEV_FMT "%s(%s)" ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3669:6: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(adapter), seq_ctrl, mlmeext->action_public_rxseq, token); ^~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3669:30: warning: format specifies type 'char *' but the argument has type 'u16' (aka 'unsigned short') [-Wformat] FUNC_ADPT_ARG(adapter), seq_ctrl, mlmeext->action_public_rxseq, token); ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3668:66: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT" seq_ctrl = 0x%x, rxseq = 0x%x, token:%d\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3675:6: warning: expression result unused [-Wunused-value] FUNC_ADPT_ARG(adapter), seq_ctrl, mlmeext->action_public_rxseq); ^~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:81:33: note: expanded from macro 'FUNC_ADPT_ARG' #define FUNC_ADPT_ARG(adapter) (__func__, (adapter)->pnetdev->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3675:30: warning: format specifies type 'char *' but the argument has type 'u16' (aka 'unsigned short') [-Wformat] FUNC_ADPT_ARG(adapter), seq_ctrl, mlmeext->action_public_rxseq); ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3674:56: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_ADPT_FMT" seq_ctrl = 0x%x, rxseq = 0x%x\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4692:34: warning: more '%' conversions than data arguments [-Wformat] DBG_88E_LEVEL(_drv_always_, FUNC_ADPT_FMT" disconnect or roaming\n", ^~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:80:28: note: expanded from macro 'FUNC_ADPT_FMT' #define FUNC_ADPT_FMT "%s(%s)" ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:64:26: note: expanded from macro 'DBG_88E_LEVEL' pr_info(DRIVER_PREFIX fmt, ##arg); \ ^~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5451:3: warning: expression result unused [-Wunused-value] FUNC_NDEV_ARG(padapter->pnetdev), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/osdep_service.h:79:30: note: expanded from macro 'FUNC_NDEV_ARG' #define FUNC_NDEV_ARG(ndev) (__func__, (ndev)->name) ^~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5452:3: warning: format specifies type 'char *' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] set_ch_parm->ch, set_ch_parm->bw, set_ch_parm->ch_offset); ^~~~~~~~~~~~~~~ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5450:50: warning: more '%' conversions than data arguments [-Wformat] DBG_88E(FUNC_NDEV_FMT" ch:%u, bw:%u, ch_offset:%u\n", ~^ drivers/staging/rtl8188eu/include/rtw_debug.h:70:26: note: expanded from macro 'DBG_88E' pr_info(DRIVER_PREFIX __VA_ARGS__); \ ^~~~~~~~~~~ include/linux/printk.h:368:26: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~ include/linux/printk.h:296:21: note: expanded from macro 'pr_fmt' #define pr_fmt(fmt) fmt vim +1606 drivers/staging/rtl8188eu/core/rtw_ap.c 9a7fe54ddc3a70 Larry Finger 2013-08-21 1596 9a7fe54ddc3a70 Larry Finger 2013-08-21 1597 int rtw_sta_flush(struct adapter *padapter) 9a7fe54ddc3a70 Larry Finger 2013-08-21 1598 { 9a7fe54ddc3a70 Larry Finger 2013-08-21 1599 struct list_head *phead, *plist; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1600 struct sta_info *psta = NULL; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1601 struct sta_priv *pstapriv = &padapter->stapriv; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1602 struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; 8943880eff435a Scott Matheina 2017-01-05 1603 struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1604 u8 bc_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1605 9a7fe54ddc3a70 Larry Finger 2013-08-21 @1606 DBG_88E(FUNC_NDEV_FMT"\n", FUNC_NDEV_ARG(padapter->pnetdev)); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1607 9a7fe54ddc3a70 Larry Finger 2013-08-21 1608 if ((pmlmeinfo->state & 0x03) != WIFI_FW_AP_STATE) 9cc56fa8276520 Heena Sirwani 2014-10-06 1609 return 0; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1610 7057dcb3afa294 Larry Finger 2013-12-19 1611 spin_lock_bh(&pstapriv->asoc_list_lock); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1612 phead = &pstapriv->asoc_list; c44e5e39c3d168 Larry Finger 2014-02-09 1613 plist = phead->next; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1614 9a7fe54ddc3a70 Larry Finger 2013-08-21 1615 /* free sta asoc_queue */ 84660700807cbc navin patidar 2014-06-22 1616 while (phead != plist) { bea8810043b9a6 Larry Finger 2014-02-09 1617 psta = container_of(plist, struct sta_info, asoc_list); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1618 c44e5e39c3d168 Larry Finger 2014-02-09 1619 plist = plist->next; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1620 8d5bdece42d9cb navin patidar 2014-06-22 1621 list_del_init(&psta->asoc_list); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1622 pstapriv->asoc_list_cnt--; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1623 9a7fe54ddc3a70 Larry Finger 2013-08-21 1624 ap_free_sta(padapter, psta, true, WLAN_REASON_DEAUTH_LEAVING); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1625 } e02bcf6126fa59 Larry Finger 2013-12-19 1626 spin_unlock_bh(&pstapriv->asoc_list_lock); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1627 9a7fe54ddc3a70 Larry Finger 2013-08-21 1628 issue_deauth(padapter, bc_addr, WLAN_REASON_DEAUTH_LEAVING); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1629 9a7fe54ddc3a70 Larry Finger 2013-08-21 1630 associated_clients_update(padapter, true); 9a7fe54ddc3a70 Larry Finger 2013-08-21 1631 9cc56fa8276520 Heena Sirwani 2014-10-06 1632 return 0; 9a7fe54ddc3a70 Larry Finger 2013-08-21 1633 } 9a7fe54ddc3a70 Larry Finger 2013-08-21 1634 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 75379 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues 2020-07-18 9:16 [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues B K Karthik 2020-07-18 11:36 ` kernel test robot 2020-07-18 16:07 ` kernel test robot @ 2020-07-19 9:26 ` Greg Kroah-Hartman 2020-07-19 9:35 ` B K Karthik 2 siblings, 1 reply; 8+ messages in thread From: Greg Kroah-Hartman @ 2020-07-19 9:26 UTC (permalink / raw) To: B K Karthik; +Cc: Larry Finger, Michael Straube, devel, linux-kernel On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote: > fixed multiple parentheses coding style issues reported by checkpatch. > > Signed-off-by: B K Karthik <karthik.bk2000@live.com> > --- > drivers/staging/rtl8188eu/include/ieee80211.h | 4 +-- > .../staging/rtl8188eu/include/osdep_service.h | 4 +-- > drivers/staging/rtl8188eu/include/wifi.h | 34 +++++++++---------- > 3 files changed, 21 insertions(+), 21 deletions(-) You can never add warnings to the build, like this patch did. Always test-build your patches at the very least... greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues 2020-07-19 9:26 ` Greg Kroah-Hartman @ 2020-07-19 9:35 ` B K Karthik 2020-07-19 11:04 ` Greg Kroah-Hartman 0 siblings, 1 reply; 8+ messages in thread From: B K Karthik @ 2020-07-19 9:35 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Larry Finger, Michael Straube, devel, linux-kernel On Sun, Jul 19, 2020 at 5:26 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote: > > fixed multiple parentheses coding style issues reported by checkpatch. > > > > Signed-off-by: B K Karthik <karthik.bk2000@live.com> > > --- > > drivers/staging/rtl8188eu/include/ieee80211.h | 4 +-- > > .../staging/rtl8188eu/include/osdep_service.h | 4 +-- > > drivers/staging/rtl8188eu/include/wifi.h | 34 +++++++++---------- > > 3 files changed, 21 insertions(+), 21 deletions(-) > > You can never add warnings to the build, like this patch did. Always > test-build your patches at the very least... understood, I will definitely do that. but these warnings are (mostly) [-Wunused-value] and [-Wformat]. that should not have (?) occurred due to the usage of parentheses. anyways, I will try to fix these up and send a v2. sorry if i wasted your time karthik ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues 2020-07-19 9:35 ` B K Karthik @ 2020-07-19 11:04 ` Greg Kroah-Hartman 0 siblings, 0 replies; 8+ messages in thread From: Greg Kroah-Hartman @ 2020-07-19 11:04 UTC (permalink / raw) To: B K Karthik; +Cc: devel, linux-kernel, Larry Finger On Sun, Jul 19, 2020 at 05:35:04AM -0400, B K Karthik wrote: > On Sun, Jul 19, 2020 at 5:26 AM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote: > > > fixed multiple parentheses coding style issues reported by checkpatch. > > > > > > Signed-off-by: B K Karthik <karthik.bk2000@live.com> > > > --- > > > drivers/staging/rtl8188eu/include/ieee80211.h | 4 +-- > > > .../staging/rtl8188eu/include/osdep_service.h | 4 +-- > > > drivers/staging/rtl8188eu/include/wifi.h | 34 +++++++++---------- > > > 3 files changed, 21 insertions(+), 21 deletions(-) > > > > You can never add warnings to the build, like this patch did. Always > > test-build your patches at the very least... > > understood, I will definitely do that. > but these warnings are (mostly) [-Wunused-value] and [-Wformat]. > that should not have (?) occurred due to the usage of parentheses. They are not there _before_ your patch, and only show up _after_ your patch, so perhaps your patch is wrong? :) thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-07-19 11:04 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-07-18 9:16 [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues B K Karthik 2020-07-18 11:36 ` kernel test robot 2020-07-18 11:36 ` kernel test robot 2020-07-18 16:07 ` kernel test robot 2020-07-18 16:07 ` kernel test robot 2020-07-19 9:26 ` Greg Kroah-Hartman 2020-07-19 9:35 ` B K Karthik 2020-07-19 11:04 ` Greg Kroah-Hartman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.