From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-arch@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, io-uring@vger.kernel.org
Subject: io_uring vs in_compat_syscall()
Date: Mon, 20 Jul 2020 08:10:46 +0200 [thread overview]
Message-ID: <20200720061046.GA10678@lst.de> (raw)
Hi Jens,
I just found a (so far theoretical) issue with the io_uring submission
offloading to workqueues or threads. We have lots of places using
in_compat_syscall() to check if a syscall needs compat treatmenet.
While the biggest users is iocttl(), we also have a fair amount of
places using in_compat_task() in read and write methods, and these
will not do the wrong thing when used with io_uring under certain
conditions. I'm not sure how to best fix this, except for making sure
in_compat_syscall() returns true one way or another for these cases.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
io-uring-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: io_uring vs in_compat_syscall()
Date: Mon, 20 Jul 2020 08:10:46 +0200 [thread overview]
Message-ID: <20200720061046.GA10678@lst.de> (raw)
Hi Jens,
I just found a (so far theoretical) issue with the io_uring submission
offloading to workqueues or threads. We have lots of places using
in_compat_syscall() to check if a syscall needs compat treatmenet.
While the biggest users is iocttl(), we also have a fair amount of
places using in_compat_task() in read and write methods, and these
will not do the wrong thing when used with io_uring under certain
conditions. I'm not sure how to best fix this, except for making sure
in_compat_syscall() returns true one way or another for these cases.
next reply other threads:[~2020-07-20 6:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 6:10 Christoph Hellwig [this message]
2020-07-20 6:10 ` io_uring vs in_compat_syscall() Christoph Hellwig
2020-07-20 16:36 ` Jens Axboe
2020-07-20 16:58 ` Andy Lutomirski
2020-07-20 17:02 ` Jens Axboe
2020-07-20 17:02 ` Jens Axboe
2020-07-20 17:28 ` Andy Lutomirski
2020-07-21 7:07 ` Christoph Hellwig
2020-07-21 14:31 ` Andy Lutomirski
2020-07-21 14:31 ` Andy Lutomirski
2020-07-21 14:34 ` Christoph Hellwig
2020-07-21 14:34 ` Christoph Hellwig
2020-07-21 17:25 ` Andy Lutomirski
2020-07-21 17:25 ` Andy Lutomirski
2020-07-22 6:30 ` Christoph Hellwig
2020-07-22 6:30 ` Christoph Hellwig
2020-07-22 8:39 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720061046.GA10678@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.