From: Christoph Hellwig <hch@lst.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-arch <linux-arch@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
io-uring@vger.kernel.org
Subject: Re: io_uring vs in_compat_syscall()
Date: Tue, 21 Jul 2020 16:34:12 +0200 [thread overview]
Message-ID: <20200721143412.GA8099@lst.de> (raw)
In-Reply-To: <CALCETrXWZBXZuCeRYvYY8AWG51e_P3bOeNeqc8zXPLOTDTHY0g@mail.gmail.com>
On Tue, Jul 21, 2020 at 07:31:02AM -0700, Andy Lutomirski wrote:
> > What do you mean with "properly wired up". Do you really want to spread
> > ->compat_foo methods everywhere, including read and write? I found
> > in_compat_syscall() a lot small and easier to maintain than all the
> > separate compat cruft.
>
> I was imagining using a flag. Some of the net code uses
> MSG_CMSG_COMPAT for this purpose.
Killing that nightmarish monster is what actually got me into looking
io_uring and starting this thread.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Andy Lutomirski <luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
linux-arch <linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
io-uring-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: io_uring vs in_compat_syscall()
Date: Tue, 21 Jul 2020 16:34:12 +0200 [thread overview]
Message-ID: <20200721143412.GA8099@lst.de> (raw)
In-Reply-To: <CALCETrXWZBXZuCeRYvYY8AWG51e_P3bOeNeqc8zXPLOTDTHY0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, Jul 21, 2020 at 07:31:02AM -0700, Andy Lutomirski wrote:
> > What do you mean with "properly wired up". Do you really want to spread
> > ->compat_foo methods everywhere, including read and write? I found
> > in_compat_syscall() a lot small and easier to maintain than all the
> > separate compat cruft.
>
> I was imagining using a flag. Some of the net code uses
> MSG_CMSG_COMPAT for this purpose.
Killing that nightmarish monster is what actually got me into looking
io_uring and starting this thread.
next prev parent reply other threads:[~2020-07-21 14:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 6:10 io_uring vs in_compat_syscall() Christoph Hellwig
2020-07-20 6:10 ` Christoph Hellwig
2020-07-20 16:36 ` Jens Axboe
2020-07-20 16:58 ` Andy Lutomirski
2020-07-20 17:02 ` Jens Axboe
2020-07-20 17:02 ` Jens Axboe
2020-07-20 17:28 ` Andy Lutomirski
2020-07-21 7:07 ` Christoph Hellwig
2020-07-21 14:31 ` Andy Lutomirski
2020-07-21 14:31 ` Andy Lutomirski
2020-07-21 14:34 ` Christoph Hellwig [this message]
2020-07-21 14:34 ` Christoph Hellwig
2020-07-21 17:25 ` Andy Lutomirski
2020-07-21 17:25 ` Andy Lutomirski
2020-07-22 6:30 ` Christoph Hellwig
2020-07-22 6:30 ` Christoph Hellwig
2020-07-22 8:39 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721143412.GA8099@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.