All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	Stephen Bates <sbates@raithlin.com>, Jens Axboe <axboe@fb.com>,
	Keith Busch <kbusch@kernel.org>, Max Gurtovoy <maxg@mellanox.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v15 5/9] nvme-core: Introduce nvme_ctrl_get_by_path()
Date: Mon, 20 Jul 2020 16:09:08 +0200	[thread overview]
Message-ID: <20200720140908.GE4627@lst.de> (raw)
In-Reply-To: <20200716203319.16022-6-logang@deltatee.com>

On Thu, Jul 16, 2020 at 02:33:15PM -0600, Logan Gunthorpe wrote:
> nvme_ctrl_get_by_path() is analagous to blkdev_get_by_path() except it
> gets a struct nvme_ctrl from the path to its char dev (/dev/nvme0).
> It makes use of filp_open() to open the file and uses the private
> data to obtain a pointer to the struct nvme_ctrl. If the fops of the
> file do not match, -EINVAL is returned.
> 
> The purpose of this function is to support NVMe-OF target passthru.

This looks generally good.  However since the early days of this
patchset we've grown symbol namespaces, and the EXPORT_SYMBOL_NS_GPL
macro, which are what we really should use here and for the other
exports.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	Max Gurtovoy <maxg@mellanox.com>,
	Stephen Bates <sbates@raithlin.com>
Subject: Re: [PATCH v15 5/9] nvme-core: Introduce nvme_ctrl_get_by_path()
Date: Mon, 20 Jul 2020 16:09:08 +0200	[thread overview]
Message-ID: <20200720140908.GE4627@lst.de> (raw)
In-Reply-To: <20200716203319.16022-6-logang@deltatee.com>

On Thu, Jul 16, 2020 at 02:33:15PM -0600, Logan Gunthorpe wrote:
> nvme_ctrl_get_by_path() is analagous to blkdev_get_by_path() except it
> gets a struct nvme_ctrl from the path to its char dev (/dev/nvme0).
> It makes use of filp_open() to open the file and uses the private
> data to obtain a pointer to the struct nvme_ctrl. If the fops of the
> file do not match, -EINVAL is returned.
> 
> The purpose of this function is to support NVMe-OF target passthru.

This looks generally good.  However since the early days of this
patchset we've grown symbol namespaces, and the EXPORT_SYMBOL_NS_GPL
macro, which are what we really should use here and for the other
exports.

  reply	other threads:[~2020-07-20 14:09 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 20:33 [PATCH v15 0/9] nvmet: add target passthru commands support Logan Gunthorpe
2020-07-16 20:33 ` Logan Gunthorpe
2020-07-16 20:33 ` [PATCH v15 1/9] nvme-core: Clear any SGL flags in passthru commands Logan Gunthorpe
2020-07-16 20:33   ` Logan Gunthorpe
2020-07-20 14:01   ` Christoph Hellwig
2020-07-20 14:01     ` Christoph Hellwig
2020-07-16 20:33 ` [PATCH v15 2/9] nvme: Create helper function to obtain command effects Logan Gunthorpe
2020-07-16 20:33   ` Logan Gunthorpe
2020-07-20 14:04   ` Christoph Hellwig
2020-07-20 14:04     ` Christoph Hellwig
2020-07-16 20:33 ` [PATCH v15 3/9] nvme: Move nvme_passthru_[start|end]() calls to common helper Logan Gunthorpe
2020-07-16 20:33   ` Logan Gunthorpe
2020-07-20 14:06   ` Christoph Hellwig
2020-07-20 14:06     ` Christoph Hellwig
2020-07-16 20:33 ` [PATCH v15 4/9] nvmet-passthru: Introduce NVMet passthru Kconfig option Logan Gunthorpe
2020-07-16 20:33   ` Logan Gunthorpe
2020-07-20 14:06   ` Christoph Hellwig
2020-07-20 14:06     ` Christoph Hellwig
2020-07-16 20:33 ` [PATCH v15 5/9] nvme-core: Introduce nvme_ctrl_get_by_path() Logan Gunthorpe
2020-07-16 20:33   ` Logan Gunthorpe
2020-07-20 14:09   ` Christoph Hellwig [this message]
2020-07-20 14:09     ` Christoph Hellwig
2020-07-16 20:33 ` [PATCH v15 6/9] nvme: Export existing nvme core functions Logan Gunthorpe
2020-07-16 20:33   ` Logan Gunthorpe
2020-07-16 20:33 ` [PATCH v15 7/9] nvmet-passthru: Add passthru code to process commands Logan Gunthorpe
2020-07-16 20:33   ` Logan Gunthorpe
2020-07-20 14:16   ` Christoph Hellwig
2020-07-20 14:16     ` Christoph Hellwig
2020-07-20 19:35     ` Sagi Grimberg
2020-07-20 19:35       ` Sagi Grimberg
2020-07-20 21:41       ` Logan Gunthorpe
2020-07-20 21:41         ` Logan Gunthorpe
2020-07-20 21:58         ` Chaitanya Kulkarni
2020-07-20 21:58           ` Chaitanya Kulkarni
2020-07-20 22:35         ` Sagi Grimberg
2020-07-20 22:35           ` Sagi Grimberg
2020-07-20 23:01           ` Logan Gunthorpe
2020-07-20 23:01             ` Logan Gunthorpe
2020-07-20 23:15             ` Sagi Grimberg
2020-07-20 23:15               ` Sagi Grimberg
2020-07-20 23:17             ` Keith Busch
2020-07-20 23:17               ` Keith Busch
2020-07-20 23:28               ` Sagi Grimberg
2020-07-20 23:28                 ` Sagi Grimberg
2020-07-21  0:06                 ` Keith Busch
2020-07-21  0:06                   ` Keith Busch
2020-07-21  0:39                   ` Sagi Grimberg
2020-07-21  0:39                     ` Sagi Grimberg
2020-07-22 21:09           ` Logan Gunthorpe
2020-07-22 21:09             ` Logan Gunthorpe
2020-07-22 22:31             ` Sagi Grimberg
2020-07-22 22:31               ` Sagi Grimberg
2020-07-16 20:33 ` [PATCH v15 8/9] nvmet-passthru: Add enable/disable helpers Logan Gunthorpe
2020-07-16 20:33   ` Logan Gunthorpe
2020-07-16 20:33 ` [PATCH v15 9/9] nvmet-configfs: Introduce passthru configfs interface Logan Gunthorpe
2020-07-16 20:33   ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720140908.GE4627@lst.de \
    --to=hch@lst.de \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@fb.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=logang@deltatee.com \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    --cc=sbates@raithlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.