All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org
Subject: Re: rmk build: 54 warnings 0 failures (rmk/v5.8-rc3-11-g48b8eed3a337d)
Date: Tue, 21 Jul 2020 16:14:17 +0100	[thread overview]
Message-ID: <20200721151417.GU1605@shell.armlinux.org.uk> (raw)
In-Reply-To: <5f16fd81.1c69fb81.6bf0b.4e31@mx.google.com>

A build of my tree by Olof's autobuilder revealed a problem concerning
a couple of platforms - this is based on v5.8-rc3:

On Tue, Jul 21, 2020 at 07:36:48AM -0700, Olof's autobuilder wrote:
> 	arm.mps2_defconfig:
> net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef]
> 
> 	arm.xcep_defconfig:
> net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef]
> net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef]

The issue is that as the #if concerned is used to determine whether
code that calls flush_dcache_page() (and therefore ensures data
integrity) is omitted - and in the above cases it will be omitted.

On ARM, we define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE to 1 in
asm/cacheflush.h, but for some reason, it seems that
net/sunrpc/svcsock.c is not seeing that.

Maybe net/sunrpc/svcsock.c needs to include asm/cacheflush.h to
ensure it picks up the definition of this preprocessor symbol?

It looks like this was introduced by:

commit ca07eda33e01eafa7a26ec06974f7eacee6a89c8
Author: Chuck Lever <chuck.lever@oracle.com>
Date:   Wed May 20 17:30:12 2020 -0400

    SUNRPC: Refactor svc_recvfrom()

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: rmk build: 54 warnings 0 failures (rmk/v5.8-rc3-11-g48b8eed3a337d)
Date: Tue, 21 Jul 2020 16:14:17 +0100	[thread overview]
Message-ID: <20200721151417.GU1605@shell.armlinux.org.uk> (raw)
In-Reply-To: <5f16fd81.1c69fb81.6bf0b.4e31@mx.google.com>

A build of my tree by Olof's autobuilder revealed a problem concerning
a couple of platforms - this is based on v5.8-rc3:

On Tue, Jul 21, 2020 at 07:36:48AM -0700, Olof's autobuilder wrote:
> 	arm.mps2_defconfig:
> net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef]
> 
> 	arm.xcep_defconfig:
> net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef]
> net/sunrpc/svcsock.c:226:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined, evaluates to 0 [-Wundef]

The issue is that as the #if concerned is used to determine whether
code that calls flush_dcache_page() (and therefore ensures data
integrity) is omitted - and in the above cases it will be omitted.

On ARM, we define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE to 1 in
asm/cacheflush.h, but for some reason, it seems that
net/sunrpc/svcsock.c is not seeing that.

Maybe net/sunrpc/svcsock.c needs to include asm/cacheflush.h to
ensure it picks up the definition of this preprocessor symbol?

It looks like this was introduced by:

commit ca07eda33e01eafa7a26ec06974f7eacee6a89c8
Author: Chuck Lever <chuck.lever@oracle.com>
Date:   Wed May 20 17:30:12 2020 -0400

    SUNRPC: Refactor svc_recvfrom()

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

       reply	other threads:[~2020-07-21 15:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5f16fd81.1c69fb81.6bf0b.4e31@mx.google.com>
2020-07-21 15:14 ` Russell King - ARM Linux admin [this message]
2020-07-21 15:14   ` rmk build: 54 warnings 0 failures (rmk/v5.8-rc3-11-g48b8eed3a337d) Russell King - ARM Linux admin
2020-07-21 15:18   ` Chuck Lever
2020-07-21 15:18     ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200721151417.GU1605@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=chuck.lever@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.