From: Peter Zijlstra <peterz@infradead.org>
To: Alex Belits <abelits@marvell.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@kernel.org" <mingo@kernel.org>,
Prasun Kapoor <pkapoor@marvell.com>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"frederic@kernel.org" <frederic@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v4 00/13] "Task_isolation" mode
Date: Thu, 23 Jul 2020 17:48:20 +0200 [thread overview]
Message-ID: <20200723154820.GA709@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <670609a91be23ebb4f179850601439fbed844479.camel@marvell.com>
On Thu, Jul 23, 2020 at 03:41:46PM +0000, Alex Belits wrote:
>
> On Thu, 2020-07-23 at 16:29 +0200, Peter Zijlstra wrote:
> > .
> >
> > This.. as presented it is an absolutely unreviewable pile of junk. It
> > presents code witout any coherent problem description and analysis.
> > And
> > the patches are not split sanely either.
>
> There is a more complete and slightly outdated description in the
> previous version of the patch at
> https://lore.kernel.org/lkml/07c25c246c55012981ec0296eee23e68c719333a.camel@marvell.com/
Not the point, you're mixing far too many things in one go. You also
have the patches split like 'generic / arch-1 / arch-2' which is wrong
per definition, as patches should be split per change and not care about
sily boundaries.
Also, if you want generic entry code, there's patches for that here:
https://lkml.kernel.org/r/20200722215954.464281930@linutronix.de
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Alex Belits <abelits@marvell.com>
Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
Prasun Kapoor <pkapoor@marvell.com>,
"frederic@kernel.org" <frederic@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"will@kernel.org" <will@kernel.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v4 00/13] "Task_isolation" mode
Date: Thu, 23 Jul 2020 17:48:20 +0200 [thread overview]
Message-ID: <20200723154820.GA709@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <670609a91be23ebb4f179850601439fbed844479.camel@marvell.com>
On Thu, Jul 23, 2020 at 03:41:46PM +0000, Alex Belits wrote:
>
> On Thu, 2020-07-23 at 16:29 +0200, Peter Zijlstra wrote:
> > .
> >
> > This.. as presented it is an absolutely unreviewable pile of junk. It
> > presents code witout any coherent problem description and analysis.
> > And
> > the patches are not split sanely either.
>
> There is a more complete and slightly outdated description in the
> previous version of the patch at
> https://lore.kernel.org/lkml/07c25c246c55012981ec0296eee23e68c719333a.camel@marvell.com/
Not the point, you're mixing far too many things in one go. You also
have the patches split like 'generic / arch-1 / arch-2' which is wrong
per definition, as patches should be split per change and not care about
sily boundaries.
Also, if you want generic entry code, there's patches for that here:
https://lkml.kernel.org/r/20200722215954.464281930@linutronix.de
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-23 15:48 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 14:44 [PATCH v4 00/13] "Task_isolation" mode Alex Belits
2020-07-22 14:44 ` Alex Belits
2020-07-22 14:47 ` [PATCH v4 01/13] task_isolation: vmstat: add quiet_vmstat_sync function Alex Belits
2020-07-22 14:47 ` Alex Belits
2020-07-22 14:47 ` Alex Belits
2020-07-22 14:48 ` [PATCH v4 02/13] task_isolation: vmstat: add vmstat_idle function Alex Belits
2020-07-22 14:48 ` Alex Belits
2020-07-22 14:49 ` [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel Alex Belits
2020-07-22 14:49 ` Alex Belits
2020-10-01 13:56 ` Frederic Weisbecker
2020-10-01 13:56 ` Frederic Weisbecker
2020-10-04 14:44 ` [EXT] " Alex Belits
2020-10-04 14:44 ` Alex Belits
2020-10-04 23:14 ` Frederic Weisbecker
2020-10-04 23:14 ` Frederic Weisbecker
2020-10-05 18:52 ` Nitesh Narayan Lal
2020-10-05 18:52 ` Nitesh Narayan Lal
2020-10-06 10:35 ` Frederic Weisbecker
2020-10-06 10:35 ` Frederic Weisbecker
2020-10-17 1:13 ` Alex Belits
2020-10-17 1:13 ` Alex Belits
2020-10-17 1:08 ` Alex Belits
2020-10-17 1:08 ` Alex Belits
2020-10-17 16:08 ` Thomas Gleixner
2020-10-17 16:08 ` Thomas Gleixner
2020-10-17 16:15 ` Alex Belits
2020-10-17 16:15 ` Alex Belits
2020-10-17 20:03 ` Thomas Gleixner
2020-10-17 20:03 ` Thomas Gleixner
2020-10-06 11:01 ` Alex Belits
2020-10-06 11:01 ` Alex Belits
2020-10-01 14:40 ` Frederic Weisbecker
2020-10-01 14:40 ` Frederic Weisbecker
2020-10-04 15:01 ` [EXT] " Alex Belits
2020-10-04 15:01 ` Alex Belits
2020-07-22 14:51 ` [PATCH v4 04/13] task_isolation: Add task isolation hooks to arch-independent code Alex Belits
2020-07-22 14:51 ` Alex Belits
2020-07-22 14:51 ` Alex Belits
2020-07-22 14:51 ` [PATCH v4 05/13] task_isolation: Add xen-specific hook Alex Belits
2020-07-22 14:51 ` Alex Belits
2020-07-22 14:53 ` [PATCH 06/13] task_isolation: Add driver-specific hooks Alex Belits
2020-07-22 14:53 ` Alex Belits
2020-07-22 14:54 ` [PATCH v4 07/13] task_isolation: arch/x86: enable task isolation functionality Alex Belits
2020-07-22 14:54 ` Alex Belits
2020-07-22 14:55 ` [PATCH 08/13] task_isolation: arch/arm64: " Alex Belits
2020-07-22 14:55 ` Alex Belits
2020-07-22 14:55 ` Alex Belits
2020-07-22 14:56 ` [PATCH v4 09/13] task_isolation: arch/arm: " Alex Belits
2020-07-22 14:56 ` Alex Belits
2020-07-22 14:56 ` Alex Belits
2020-07-22 14:57 ` [PATCH v4 10/13] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu() Alex Belits
2020-07-22 14:57 ` Alex Belits
2020-10-01 14:44 ` Frederic Weisbecker
2020-10-01 14:44 ` Frederic Weisbecker
2020-10-04 15:22 ` [EXT] " Alex Belits
2020-10-04 15:22 ` Alex Belits
2020-10-06 21:41 ` Frederic Weisbecker
2020-10-06 21:41 ` Frederic Weisbecker
2020-10-17 0:17 ` Alex Belits
2020-10-17 0:17 ` Alex Belits
2020-07-22 14:58 ` [PATCH v4 11/13] task_isolation: net: don't flush backlog on CPUs running isolated tasks Alex Belits
2020-07-22 14:58 ` Alex Belits
2020-07-22 14:58 ` Alex Belits
2020-10-01 14:47 ` Frederic Weisbecker
2020-10-01 14:47 ` Frederic Weisbecker
2020-10-04 17:12 ` [EXT] " Alex Belits
2020-10-04 17:12 ` Alex Belits
2021-01-22 14:13 ` Marcelo Tosatti
2021-01-22 14:13 ` Marcelo Tosatti
2021-01-22 16:13 ` Paolo Abeni
2021-01-22 16:13 ` Paolo Abeni
2020-07-22 14:59 ` [PATCH v4 12/13] task_isolation: ringbuffer: don't interrupt CPUs running isolated tasks on buffer resize Alex Belits
2020-07-22 14:59 ` Alex Belits
2020-07-22 14:59 ` [PATCH 13/13] task_isolation: kick_all_cpus_sync: don't kick isolated cpus Alex Belits
2020-07-22 14:59 ` Alex Belits
2020-07-22 14:59 ` Alex Belits
2020-07-23 13:17 ` [PATCH v4 00/13] "Task_isolation" mode Thomas Gleixner
2020-07-23 13:17 ` Thomas Gleixner
2020-07-23 13:17 ` Thomas Gleixner
2020-07-23 14:26 ` Peter Zijlstra
2020-07-23 14:26 ` Peter Zijlstra
2020-07-23 14:53 ` Thomas Gleixner
2020-07-23 14:53 ` Thomas Gleixner
2020-07-23 14:53 ` Thomas Gleixner
2020-07-23 14:29 ` Peter Zijlstra
2020-07-23 14:29 ` Peter Zijlstra
2020-07-23 15:41 ` [EXT] " Alex Belits
2020-07-23 15:41 ` Alex Belits
2020-07-23 15:48 ` Peter Zijlstra [this message]
2020-07-23 15:48 ` Peter Zijlstra
2020-07-23 16:19 ` Alex Belits
2020-07-23 16:19 ` Alex Belits
2020-07-23 15:18 ` Alex Belits
2020-07-23 15:18 ` Alex Belits
2020-07-23 15:49 ` Peter Zijlstra
2020-07-23 15:49 ` Peter Zijlstra
2020-07-23 15:49 ` Peter Zijlstra
2020-07-23 16:50 ` Alex Belits
2020-07-23 16:50 ` Alex Belits
2020-07-23 21:44 ` Thomas Gleixner
2020-07-23 21:44 ` Thomas Gleixner
2020-07-23 21:44 ` Thomas Gleixner
2020-07-24 3:00 ` [EXT] " Alex Belits
2020-07-24 3:00 ` Alex Belits
2020-07-24 16:08 ` Thomas Gleixner
2020-07-24 16:08 ` Thomas Gleixner
2020-07-24 16:08 ` Thomas Gleixner
2020-07-23 21:31 ` Thomas Gleixner
2020-07-23 21:31 ` Thomas Gleixner
2020-07-23 21:31 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723154820.GA709@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=abelits@marvell.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=frederic@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkapoor@marvell.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.