All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Karol Herbst <kherbst@redhat.com>
Cc: Patrick Volkerding <volkerdi@gmail.com>,
	Lyude Paul <lyude@redhat.com>, Bjorn Helgaas <helgaas@kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>,
	Ben Skeggs <bskeggs@redhat.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	nouveau <nouveau@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Sasha Levin <sashal@kernel.org>
Subject: Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"
Date: Fri, 24 Jul 2020 12:57:51 +0300	[thread overview]
Message-ID: <20200724095751.GU1375436@lahna.fi.intel.com> (raw)
In-Reply-To: <CACO55tsv63VP93F7xJ3nfZ7SkOk0c6WkgvuP+8fY14gypmn4Fg@mail.gmail.com>

On Thu, Jul 23, 2020 at 10:30:58PM +0200, Karol Herbst wrote:
> On Wed, Jul 22, 2020 at 11:25 AM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > On Tue, Jul 21, 2020 at 01:37:12PM -0500, Patrick Volkerding wrote:
> > > On 7/21/20 10:27 AM, Mika Westerberg wrote:
> > > > On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote:
> > > >> Sure thing. Also, feel free to let me know if you'd like access to one of the
> > > >> systems we saw breaking with this patch - I'm fairly sure I've got one of them
> > > >> locally at my apartment and don't mind setting up AMT/KVM/SSH
> > > > Probably no need for remote access (thanks for the offer, though). I
> > > > attached a test patch to the bug report:
> > > >
> > > >   https://bugzilla.kernel.org/show_bug.cgi?id=208597
> > > >
> > > > that tries to work it around (based on the ->pm_cap == 0). I wonder if
> > > > anyone would have time to try it out.
> > >
> > >
> > > Hi Mika,
> > >
> > > I can confirm that this patch applied to 5.4.52 fixes the issue with
> > > hybrid graphics on the Thinkpad X1 Extreme gen2.
> >
> > Great, thanks for testing!
> >
> 
> yeah, works on the P1G2 as well.

Thanks for testing!

Since we have the revert queued for this release cycle, I think I will
send an updated version of "PCI/PM: Assume ports without DLL Link Active
train links in 100 ms" after v5.9-rc1 is released that has this
workaround in place.

(I'm continuing my vacation so will be offline next week).

WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Karol Herbst <kherbst@redhat.com>
Cc: Sasha Levin <sashal@kernel.org>,
	Patrick Volkerding <volkerdi@gmail.com>,
	Linux PCI <linux-pci@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Ben Skeggs <bskeggs@redhat.com>,
	nouveau <nouveau@lists.freedesktop.org>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"
Date: Fri, 24 Jul 2020 12:57:51 +0300	[thread overview]
Message-ID: <20200724095751.GU1375436@lahna.fi.intel.com> (raw)
In-Reply-To: <CACO55tsv63VP93F7xJ3nfZ7SkOk0c6WkgvuP+8fY14gypmn4Fg@mail.gmail.com>

On Thu, Jul 23, 2020 at 10:30:58PM +0200, Karol Herbst wrote:
> On Wed, Jul 22, 2020 at 11:25 AM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > On Tue, Jul 21, 2020 at 01:37:12PM -0500, Patrick Volkerding wrote:
> > > On 7/21/20 10:27 AM, Mika Westerberg wrote:
> > > > On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote:
> > > >> Sure thing. Also, feel free to let me know if you'd like access to one of the
> > > >> systems we saw breaking with this patch - I'm fairly sure I've got one of them
> > > >> locally at my apartment and don't mind setting up AMT/KVM/SSH
> > > > Probably no need for remote access (thanks for the offer, though). I
> > > > attached a test patch to the bug report:
> > > >
> > > >   https://bugzilla.kernel.org/show_bug.cgi?id=208597
> > > >
> > > > that tries to work it around (based on the ->pm_cap == 0). I wonder if
> > > > anyone would have time to try it out.
> > >
> > >
> > > Hi Mika,
> > >
> > > I can confirm that this patch applied to 5.4.52 fixes the issue with
> > > hybrid graphics on the Thinkpad X1 Extreme gen2.
> >
> > Great, thanks for testing!
> >
> 
> yeah, works on the P1G2 as well.

Thanks for testing!

Since we have the revert queued for this release cycle, I think I will
send an updated version of "PCI/PM: Assume ports without DLL Link Active
train links in 100 ms" after v5.9-rc1 is released that has this
workaround in place.

(I'm continuing my vacation so will be offline next week).
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-07-24  9:57 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 19:30 nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms" Karol Herbst
2020-07-16 22:10 ` Karol Herbst
2020-07-16 22:10   ` Karol Herbst
2020-07-16 23:54   ` Bjorn Helgaas
2020-07-16 23:54     ` Bjorn Helgaas
2020-07-17  0:43     ` Karol Herbst
2020-07-17  0:43       ` Karol Herbst
2020-07-17  0:43       ` Karol Herbst
2020-07-17 11:32       ` Karol Herbst
2020-07-17 11:32         ` Karol Herbst
2020-07-21 12:22         ` Mika Westerberg
2020-07-21 12:22           ` Mika Westerberg
2020-07-21 15:01           ` Lyude Paul
2020-07-21 15:01             ` Lyude Paul
2020-07-21 15:27             ` Mika Westerberg
2020-07-21 15:27               ` Mika Westerberg
2020-07-21 16:00               ` Lyude Paul
2020-07-21 16:00                 ` Lyude Paul
2020-07-21 18:24                 ` Lyude Paul
2020-07-21 18:24                   ` Lyude Paul
2020-07-21 18:24                   ` Lyude Paul
2020-07-22  9:23                   ` Mika Westerberg
2020-07-22  9:23                     ` Mika Westerberg
2020-07-21 18:37               ` Patrick Volkerding
2020-07-21 18:37                 ` Patrick Volkerding
2020-07-22  9:25                 ` Mika Westerberg
2020-07-22  9:25                   ` Mika Westerberg
2020-07-22  9:25                   ` Mika Westerberg
2020-07-23 20:30                   ` Karol Herbst
2020-07-23 20:30                     ` Karol Herbst
2020-07-24  9:57                     ` Mika Westerberg [this message]
2020-07-24  9:57                       ` Mika Westerberg
2020-07-24 14:35                       ` Bjorn Helgaas
2020-07-24 14:35                         ` Bjorn Helgaas
2020-07-17 14:43       ` Sasha Levin
2020-07-17 14:43         ` Sasha Levin
2020-07-17 22:59         ` Bjorn Helgaas
2020-07-17 22:59           ` Bjorn Helgaas
2020-07-17 19:04     ` Lyude Paul
2020-07-17 19:04       ` Lyude Paul
2020-07-17 19:04       ` Lyude Paul
2020-07-17 19:52       ` Lukas Wunner
2020-07-17 19:52         ` Lukas Wunner
2020-07-21 13:08         ` Mika Westerberg
2020-07-21 13:08           ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724095751.GU1375436@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=helgaas@kernel.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=kherbst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=sashal@kernel.org \
    --cc=volkerdi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.