From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linuxppc-dev@lists.ozlabs.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: fsl_sai: Clean code for synchronize mode
Date: Tue, 4 Aug 2020 01:13:34 -0700 [thread overview]
Message-ID: <20200804081333.GA664@Asurada-Nvidia> (raw)
In-Reply-To: <CAA+D8ANodghXDbUVOqpf9uq8A5FVbDFEFkf4dWdyMUNDTPaJ7A@mail.gmail.com>
On Tue, Aug 04, 2020 at 03:53:51PM +0800, Shengjiu Wang wrote:
> > > /* Check if the opposite FRDE is also disabled */
> > > regmap_read(sai->regmap, FSL_SAI_xCSR(!tx, ofs), &xcsr);
> > > + if (sai->synchronous[tx] && !sai->synchronous[!tx] && !(xcsr & FSL_SAI_CSR_FRDE))
> > > + fsl_sai_config_disable(sai, !tx);
> >
> > > + if (sai->synchronous[tx] || !sai->synchronous[!tx] || !(xcsr & FSL_SAI_CSR_FRDE))
> > > + fsl_sai_config_disable(sai, tx);
> >
> > The first "||" should probably be "&&".
>
> No. it is !(!sai->synchronous[tx] && sai->synchronous[!tx] && (xcsr &
> FSL_SAI_CSR_FRDE))
> so then convert to
> (sai->synchronous[tx] || !sai->synchronous[!tx] || !(xcsr & FSL_SAI_CSR_FRDE))
>
> if change to &&, then it won't work for:
> sai->synchronous[tx] = false, sai->synchronous[!tx]=false.
Ahh..probably should be
if (!(sync[dir] && !sync[adir]) || !frde)
I have a (seemingly) correct version in my sample code.
And...please untangle the logic using the given example -- adding
helper function(s) and comments. And, though the driver does have
places using array[tx] and array[!tx], better not to use any more
boolean type variable as an array index, as it's hard to read.
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
linuxppc-dev@lists.ozlabs.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: fsl_sai: Clean code for synchronize mode
Date: Tue, 4 Aug 2020 01:13:34 -0700 [thread overview]
Message-ID: <20200804081333.GA664@Asurada-Nvidia> (raw)
In-Reply-To: <CAA+D8ANodghXDbUVOqpf9uq8A5FVbDFEFkf4dWdyMUNDTPaJ7A@mail.gmail.com>
On Tue, Aug 04, 2020 at 03:53:51PM +0800, Shengjiu Wang wrote:
> > > /* Check if the opposite FRDE is also disabled */
> > > regmap_read(sai->regmap, FSL_SAI_xCSR(!tx, ofs), &xcsr);
> > > + if (sai->synchronous[tx] && !sai->synchronous[!tx] && !(xcsr & FSL_SAI_CSR_FRDE))
> > > + fsl_sai_config_disable(sai, !tx);
> >
> > > + if (sai->synchronous[tx] || !sai->synchronous[!tx] || !(xcsr & FSL_SAI_CSR_FRDE))
> > > + fsl_sai_config_disable(sai, tx);
> >
> > The first "||" should probably be "&&".
>
> No. it is !(!sai->synchronous[tx] && sai->synchronous[!tx] && (xcsr &
> FSL_SAI_CSR_FRDE))
> so then convert to
> (sai->synchronous[tx] || !sai->synchronous[!tx] || !(xcsr & FSL_SAI_CSR_FRDE))
>
> if change to &&, then it won't work for:
> sai->synchronous[tx] = false, sai->synchronous[!tx]=false.
Ahh..probably should be
if (!(sync[dir] && !sync[adir]) || !frde)
I have a (seemingly) correct version in my sample code.
And...please untangle the logic using the given example -- adding
helper function(s) and comments. And, though the driver does have
places using array[tx] and array[!tx], better not to use any more
boolean type variable as an array index, as it's hard to read.
next prev parent reply other threads:[~2020-08-04 8:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 3:17 [PATCH] ASoC: fsl_sai: Clean code for synchronize mode Shengjiu Wang
2020-08-03 5:40 ` Nicolin Chen
2020-08-03 5:40 ` Nicolin Chen
2020-08-03 5:40 ` Nicolin Chen
2020-08-03 8:04 ` Shengjiu Wang
2020-08-03 8:04 ` Shengjiu Wang
2020-08-03 21:57 ` Nicolin Chen
2020-08-03 21:57 ` Nicolin Chen
2020-08-04 1:39 ` Shengjiu Wang
2020-08-04 1:39 ` Shengjiu Wang
2020-08-04 2:11 ` Nicolin Chen
2020-08-04 2:11 ` Nicolin Chen
2020-08-04 2:35 ` Shengjiu Wang
2020-08-04 2:35 ` Shengjiu Wang
2020-08-04 3:00 ` Nicolin Chen
2020-08-04 3:00 ` Nicolin Chen
2020-08-04 3:23 ` Shengjiu Wang
2020-08-04 3:23 ` Shengjiu Wang
2020-08-04 4:22 ` Shengjiu Wang
2020-08-04 4:22 ` Shengjiu Wang
2020-08-04 7:03 ` Nicolin Chen
2020-08-04 7:03 ` Nicolin Chen
2020-08-04 7:08 ` Nicolin Chen
2020-08-04 7:08 ` Nicolin Chen
2020-08-04 7:53 ` Shengjiu Wang
2020-08-04 7:53 ` Shengjiu Wang
2020-08-04 8:13 ` Nicolin Chen [this message]
2020-08-04 8:13 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804081333.GA664@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.