All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>,
	Tomoya MORINAGA <tomoya.rohm@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 1/2] i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume
Date: Mon, 10 Aug 2020 16:01:35 +0200	[thread overview]
Message-ID: <20200810140135.GA3923@kunai> (raw)
In-Reply-To: <20200805193616.384313-2-vaibhavgupta40@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

On Thu, Aug 06, 2020 at 01:06:15AM +0530, Vaibhav Gupta wrote:
> The driver calls pci_enable_wake(...., false) in pch_i2c_suspend() as well
> as pch_i2c_resume(). Either it should enable-wake the device in .suspend()
> or should not invoke pci_enable_wake() at all.
> 
> Concluding that this driver doesn't support enable-wake and PCI core calls
> pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
> .suspend() and .resume().
> 
> Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Tomoya MORINAGA <tomoya.rohm@gmail.com>,
	linux-kernel@vger.kernel.org,
	Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	Bjorn Helgaas <helgaas@kernel.org>,
	linux-i2c@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2 1/2] i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume
Date: Mon, 10 Aug 2020 16:01:35 +0200	[thread overview]
Message-ID: <20200810140135.GA3923@kunai> (raw)
In-Reply-To: <20200805193616.384313-2-vaibhavgupta40@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 600 bytes --]

On Thu, Aug 06, 2020 at 01:06:15AM +0530, Vaibhav Gupta wrote:
> The driver calls pci_enable_wake(...., false) in pch_i2c_suspend() as well
> as pch_i2c_resume(). Either it should enable-wake the device in .suspend()
> or should not invoke pci_enable_wake() at all.
> 
> Concluding that this driver doesn't support enable-wake and PCI core calls
> pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
> .suspend() and .resume().
> 
> Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>

Applied to for-next, thanks!


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2020-08-10 14:01 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 14:00 [PATCH v1] i2c: eg20t: use generic power management Vaibhav Gupta
2020-07-20 14:00 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-05  9:16 ` Wolfram Sang
2020-08-05  9:16   ` [Linux-kernel-mentees] " Wolfram Sang
2020-08-05 15:23 ` Bjorn Helgaas
2020-08-05 15:23   ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-08-05 15:28   ` Bjorn Helgaas
2020-08-05 15:28     ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-08-05 16:21     ` Vaibhav Gupta
2020-08-05 16:21       ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-05 16:56       ` Bjorn Helgaas
2020-08-05 16:56         ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-08-05 17:19         ` Vaibhav Gupta
2020-08-05 17:19           ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-05 19:36         ` [PATCH v2 0/2] i2c: eg20t: Power management upgrade and clean-ups Vaibhav Gupta
2020-08-05 19:36           ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-05 19:36           ` [PATCH v2 1/2] i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume Vaibhav Gupta
2020-08-05 19:36             ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-10 14:01             ` Wolfram Sang [this message]
2020-08-10 14:01               ` Wolfram Sang
2020-08-05 19:36           ` [PATCH v2 2/2] i2c: eg20t: use generic power management Vaibhav Gupta
2020-08-05 19:36             ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-07 20:23             ` Bjorn Helgaas
2020-08-07 20:23               ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-08-10  9:18               ` Vaibhav Gupta
2020-08-10  9:18                 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-25  9:53               ` Jean Delvare
2020-08-25  9:53                 ` [Linux-kernel-mentees] " Jean Delvare
2020-08-25 15:16                 ` Bjorn Helgaas
2020-08-25 15:16                   ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-08-10 14:01             ` Wolfram Sang
2020-08-10 14:01               ` [Linux-kernel-mentees] " Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200810140135.GA3923@kunai \
    --to=wsa@kernel.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tomoya-linux@dsn.okisemi.com \
    --cc=tomoya.rohm@gmail.com \
    --cc=vaibhav.varodek@gmail.com \
    --cc=vaibhavgupta40@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.