All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>,
	Tomoya MORINAGA <tomoya.rohm@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Shuah Khan <skhan@linuxfoundation.org>,
	Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH v2 2/2] i2c: eg20t: use generic power management
Date: Tue, 25 Aug 2020 10:16:55 -0500	[thread overview]
Message-ID: <20200825151655.GA1913382@bjorn-Precision-5520> (raw)
In-Reply-To: <20200825115342.16ab9004@endymion>

On Tue, Aug 25, 2020 at 11:53:42AM +0200, Jean Delvare wrote:
> Hi Bjorn, Vaibhav,
> 
> On Fri, 07 Aug 2020 15:23:21 -0500, Bjorn Helgaas wrote:
> > Also, i801_suspend() looks suspicious because it writes SMBHSTCFG, but
> > I don't see anything corresponding in i801_resume().
> 
> You're right, it's buggy. Volker Rümelin's patch at:
> 
> https://patchwork.ozlabs.org/project/linux-i2c/patch/a2fc5a6d-a3bf-eaf0-bb75-1521be346333@googlemail.com/
> 
> should fix it. I was supposed to review it but did not, shame on me.
> I'll do it today.

Always nice when the fix is already there :)  Thanks for following up
on this!

Bjorn

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Jean Delvare <jdelvare@suse.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Tomoya MORINAGA <tomoya.rohm@gmail.com>,
	linux-kernel@vger.kernel.org,
	Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	linux-i2c@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2 2/2] i2c: eg20t: use generic power management
Date: Tue, 25 Aug 2020 10:16:55 -0500	[thread overview]
Message-ID: <20200825151655.GA1913382@bjorn-Precision-5520> (raw)
In-Reply-To: <20200825115342.16ab9004@endymion>

On Tue, Aug 25, 2020 at 11:53:42AM +0200, Jean Delvare wrote:
> Hi Bjorn, Vaibhav,
> 
> On Fri, 07 Aug 2020 15:23:21 -0500, Bjorn Helgaas wrote:
> > Also, i801_suspend() looks suspicious because it writes SMBHSTCFG, but
> > I don't see anything corresponding in i801_resume().
> 
> You're right, it's buggy. Volker Rümelin's patch at:
> 
> https://patchwork.ozlabs.org/project/linux-i2c/patch/a2fc5a6d-a3bf-eaf0-bb75-1521be346333@googlemail.com/
> 
> should fix it. I was supposed to review it but did not, shame on me.
> I'll do it today.

Always nice when the fix is already there :)  Thanks for following up
on this!

Bjorn
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2020-08-25 15:17 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 14:00 [PATCH v1] i2c: eg20t: use generic power management Vaibhav Gupta
2020-07-20 14:00 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-05  9:16 ` Wolfram Sang
2020-08-05  9:16   ` [Linux-kernel-mentees] " Wolfram Sang
2020-08-05 15:23 ` Bjorn Helgaas
2020-08-05 15:23   ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-08-05 15:28   ` Bjorn Helgaas
2020-08-05 15:28     ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-08-05 16:21     ` Vaibhav Gupta
2020-08-05 16:21       ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-05 16:56       ` Bjorn Helgaas
2020-08-05 16:56         ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-08-05 17:19         ` Vaibhav Gupta
2020-08-05 17:19           ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-05 19:36         ` [PATCH v2 0/2] i2c: eg20t: Power management upgrade and clean-ups Vaibhav Gupta
2020-08-05 19:36           ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-05 19:36           ` [PATCH v2 1/2] i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume Vaibhav Gupta
2020-08-05 19:36             ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-10 14:01             ` Wolfram Sang
2020-08-10 14:01               ` [Linux-kernel-mentees] " Wolfram Sang
2020-08-05 19:36           ` [PATCH v2 2/2] i2c: eg20t: use generic power management Vaibhav Gupta
2020-08-05 19:36             ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-07 20:23             ` Bjorn Helgaas
2020-08-07 20:23               ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-08-10  9:18               ` Vaibhav Gupta
2020-08-10  9:18                 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-25  9:53               ` Jean Delvare
2020-08-25  9:53                 ` [Linux-kernel-mentees] " Jean Delvare
2020-08-25 15:16                 ` Bjorn Helgaas [this message]
2020-08-25 15:16                   ` Bjorn Helgaas
2020-08-10 14:01             ` Wolfram Sang
2020-08-10 14:01               ` [Linux-kernel-mentees] " Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825151655.GA1913382@bjorn-Precision-5520 \
    --to=helgaas@kernel.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=bhelgaas@google.com \
    --cc=jdelvare@suse.com \
    --cc=jdelvare@suse.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tomoya-linux@dsn.okisemi.com \
    --cc=tomoya.rohm@gmail.com \
    --cc=vaibhav.varodek@gmail.com \
    --cc=vaibhavgupta40@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.