From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Zhang Chen" <chen.zhang@intel.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
qemu-riscv@nongnu.org, "David Hildenbrand" <david@redhat.com>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Stefan Berger" <stefanb@linux.ibm.com>,
"Juan Quintela" <quintela@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
qemu-ppc@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Li Zhijian" <lizhijian@cn.fujitsu.com>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
qemu-block@nongnu.org, "Roman Bolshakov" <r.bolshakov@yadro.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Cameron Esfahani" <dirty@apple.com>
Subject: [PULL 2/9] scripts/tracetool: Use void pointer for vcpu
Date: Thu, 13 Aug 2020 06:22:50 +0100 [thread overview]
Message-ID: <20200813052257.226142-3-stefanha@redhat.com> (raw)
In-Reply-To: <20200813052257.226142-1-stefanha@redhat.com>
From: Roman Bolshakov <r.bolshakov@yadro.com>
dtrace on macOS complains that CPUState * is used for a few probes:
dtrace: failed to compile script trace-dtrace-root.dtrace: line 130: syntax error near "CPUState"
A comment in scripts/tracetool/__init__.py mentions that:
We only want to allow standard C types or fixed sized
integer types. We don't want QEMU specific types
as we can't assume trace backends can resolve all the
typedefs
Fixes: 3d211d9f4dbee ("trace: Add 'vcpu' event property to trace guest vCPU")
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Message-id: 20200717093517.73397-3-r.bolshakov@yadro.com
Cc: Cameron Esfahani <dirty@apple.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
scripts/tracetool/vcpu.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/tracetool/vcpu.py b/scripts/tracetool/vcpu.py
index b54e4f4e7a..868b4cb04c 100644
--- a/scripts/tracetool/vcpu.py
+++ b/scripts/tracetool/vcpu.py
@@ -24,7 +24,7 @@ def transform_event(event):
assert "tcg-trans" not in event.properties
assert "tcg-exec" not in event.properties
- event.args = Arguments([("CPUState *", "__cpu"), event.args])
+ event.args = Arguments([("void *", "__cpu"), event.args])
if "tcg" in event.properties:
fmt = "\"cpu=%p \""
event.fmt = [fmt + event.fmt[0],
--
2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Li Zhijian" <lizhijian@cn.fujitsu.com>,
qemu-block@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Cameron Esfahani" <dirty@apple.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Kevin Wolf" <kwolf@redhat.com>,
qemu-riscv@nongnu.org,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Roman Bolshakov" <r.bolshakov@yadro.com>,
"Max Reitz" <mreitz@redhat.com>,
"Zhang Chen" <chen.zhang@intel.com>,
qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: [PULL 2/9] scripts/tracetool: Use void pointer for vcpu
Date: Thu, 13 Aug 2020 06:22:50 +0100 [thread overview]
Message-ID: <20200813052257.226142-3-stefanha@redhat.com> (raw)
In-Reply-To: <20200813052257.226142-1-stefanha@redhat.com>
From: Roman Bolshakov <r.bolshakov@yadro.com>
dtrace on macOS complains that CPUState * is used for a few probes:
dtrace: failed to compile script trace-dtrace-root.dtrace: line 130: syntax error near "CPUState"
A comment in scripts/tracetool/__init__.py mentions that:
We only want to allow standard C types or fixed sized
integer types. We don't want QEMU specific types
as we can't assume trace backends can resolve all the
typedefs
Fixes: 3d211d9f4dbee ("trace: Add 'vcpu' event property to trace guest vCPU")
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Message-id: 20200717093517.73397-3-r.bolshakov@yadro.com
Cc: Cameron Esfahani <dirty@apple.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
scripts/tracetool/vcpu.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/tracetool/vcpu.py b/scripts/tracetool/vcpu.py
index b54e4f4e7a..868b4cb04c 100644
--- a/scripts/tracetool/vcpu.py
+++ b/scripts/tracetool/vcpu.py
@@ -24,7 +24,7 @@ def transform_event(event):
assert "tcg-trans" not in event.properties
assert "tcg-exec" not in event.properties
- event.args = Arguments([("CPUState *", "__cpu"), event.args])
+ event.args = Arguments([("void *", "__cpu"), event.args])
if "tcg" in event.properties:
fmt = "\"cpu=%p \""
event.fmt = [fmt + event.fmt[0],
--
2.26.2
next prev parent reply other threads:[~2020-08-13 7:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 5:22 [PULL 0/9] Tracing patches Stefan Hajnoczi
2020-08-13 5:22 ` Stefan Hajnoczi
2020-08-13 5:22 ` [PULL 1/9] scripts/tracetool: Fix dtrace generation for macOS Stefan Hajnoczi
2020-08-13 5:22 ` Stefan Hajnoczi
2020-08-13 5:22 ` Stefan Hajnoczi [this message]
2020-08-13 5:22 ` [PULL 2/9] scripts/tracetool: Use void pointer for vcpu Stefan Hajnoczi
2020-08-13 5:22 ` [PULL 3/9] build: Don't make object files for dtrace on macOS Stefan Hajnoczi
2020-08-13 5:22 ` Stefan Hajnoczi
2020-08-13 5:22 ` [PULL 4/9] net/colo: Match is-enabled probe to tracepoint Stefan Hajnoczi
2020-08-13 5:22 ` Stefan Hajnoczi
2020-08-13 5:22 ` [PULL 5/9] softmmu: Add missing trace-events file Stefan Hajnoczi
2020-08-13 5:22 ` Stefan Hajnoczi
2020-08-13 5:22 ` [PULL 6/9] scripts/cleanup-trace-events: Fix for vcpu property Stefan Hajnoczi
2020-08-13 5:22 ` Stefan Hajnoczi
2020-08-13 5:22 ` [PULL 7/9] scripts/cleanup-trace-events: Emit files in alphabetical order Stefan Hajnoczi
2020-08-13 5:22 ` Stefan Hajnoczi
2020-08-13 5:22 ` [PULL 8/9] trace-events: Delete unused trace points Stefan Hajnoczi
2020-08-13 5:22 ` Stefan Hajnoczi
2020-08-13 5:22 ` [PULL 9/9] trace-events: Fix attribution of trace points to source Stefan Hajnoczi
2020-08-13 5:22 ` Stefan Hajnoczi
2020-08-13 10:31 ` [PULL 0/9] Tracing patches no-reply
2020-08-13 10:31 ` no-reply
2020-08-13 10:47 ` no-reply
2020-08-13 10:47 ` no-reply
2020-08-13 12:17 ` Stefan Hajnoczi
2020-08-13 12:17 ` Stefan Hajnoczi
2020-08-21 16:25 ` Peter Maydell
2020-08-21 16:25 ` Peter Maydell
2020-09-09 10:20 ` Stefan Hajnoczi
2020-09-09 10:20 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813052257.226142-3-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.williamson@redhat.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=chen.zhang@intel.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dirty@apple.com \
--cc=jasowang@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=quintela@redhat.com \
--cc=r.bolshakov@yadro.com \
--cc=sagark@eecs.berkeley.edu \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.