All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Zhang Chen" <chen.zhang@intel.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	qemu-riscv@nongnu.org, "David Hildenbrand" <david@redhat.com>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Stefan Berger" <stefanb@linux.ibm.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	qemu-ppc@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Li Zhijian" <lizhijian@cn.fujitsu.com>,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>
Subject: [PULL 6/9] scripts/cleanup-trace-events: Fix for vcpu property
Date: Thu, 13 Aug 2020 06:22:54 +0100	[thread overview]
Message-ID: <20200813052257.226142-7-stefanha@redhat.com> (raw)
In-Reply-To: <20200813052257.226142-1-stefanha@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

Commit a44cf524f8 "scripts/cleanup-trace-events: Update for current
practice" limited search to the input file's directory.  That's wrong
for events with the vcpu property, because these can only be defined
in root directory.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 20200806141334.3646302-2-armbru@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 scripts/cleanup-trace-events.pl | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/scripts/cleanup-trace-events.pl b/scripts/cleanup-trace-events.pl
index d4f0e4cab5..6c3767bd6a 100755
--- a/scripts/cleanup-trace-events.pl
+++ b/scripts/cleanup-trace-events.pl
@@ -31,10 +31,12 @@ open(IN, $in) or die "open $in: $!";
 chdir($dir) or die "chdir $dir: $!";
 
 while (<IN>) {
-    if (/^(disable |(tcg) |vcpu )*([a-z_0-9]+)\(/i) {
-        my $pat = "trace_$3";
-        $pat .= '_tcg' if (defined $2);
-        open GREP, '-|', 'git', 'grep', '-lw', '--max-depth', '1', $pat
+    if (/^(disable |(tcg) |(vcpu) )*([a-z_0-9]+)\(/i) {
+        my $pat = "trace_$4";
+        $pat .= '_tcg' if defined $2;
+        open GREP, '-|', 'git', 'grep', '-lw',
+	    defined $3 ? () : ('--max-depth', '1'),
+	    $pat
             or die "run git grep: $!";
         while (my $fname = <GREP>) {
             chomp $fname;
-- 
2.26.2


WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Li Zhijian" <lizhijian@cn.fujitsu.com>,
	qemu-block@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Kevin Wolf" <kwolf@redhat.com>,
	qemu-riscv@nongnu.org,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Max Reitz" <mreitz@redhat.com>,
	"Zhang Chen" <chen.zhang@intel.com>,
	qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Stefan Berger" <stefanb@linux.ibm.com>
Subject: [PULL 6/9] scripts/cleanup-trace-events: Fix for vcpu property
Date: Thu, 13 Aug 2020 06:22:54 +0100	[thread overview]
Message-ID: <20200813052257.226142-7-stefanha@redhat.com> (raw)
In-Reply-To: <20200813052257.226142-1-stefanha@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

Commit a44cf524f8 "scripts/cleanup-trace-events: Update for current
practice" limited search to the input file's directory.  That's wrong
for events with the vcpu property, because these can only be defined
in root directory.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 20200806141334.3646302-2-armbru@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 scripts/cleanup-trace-events.pl | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/scripts/cleanup-trace-events.pl b/scripts/cleanup-trace-events.pl
index d4f0e4cab5..6c3767bd6a 100755
--- a/scripts/cleanup-trace-events.pl
+++ b/scripts/cleanup-trace-events.pl
@@ -31,10 +31,12 @@ open(IN, $in) or die "open $in: $!";
 chdir($dir) or die "chdir $dir: $!";
 
 while (<IN>) {
-    if (/^(disable |(tcg) |vcpu )*([a-z_0-9]+)\(/i) {
-        my $pat = "trace_$3";
-        $pat .= '_tcg' if (defined $2);
-        open GREP, '-|', 'git', 'grep', '-lw', '--max-depth', '1', $pat
+    if (/^(disable |(tcg) |(vcpu) )*([a-z_0-9]+)\(/i) {
+        my $pat = "trace_$4";
+        $pat .= '_tcg' if defined $2;
+        open GREP, '-|', 'git', 'grep', '-lw',
+	    defined $3 ? () : ('--max-depth', '1'),
+	    $pat
             or die "run git grep: $!";
         while (my $fname = <GREP>) {
             chomp $fname;
-- 
2.26.2


  parent reply	other threads:[~2020-08-13  7:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13  5:22 [PULL 0/9] Tracing patches Stefan Hajnoczi
2020-08-13  5:22 ` Stefan Hajnoczi
2020-08-13  5:22 ` [PULL 1/9] scripts/tracetool: Fix dtrace generation for macOS Stefan Hajnoczi
2020-08-13  5:22   ` Stefan Hajnoczi
2020-08-13  5:22 ` [PULL 2/9] scripts/tracetool: Use void pointer for vcpu Stefan Hajnoczi
2020-08-13  5:22   ` Stefan Hajnoczi
2020-08-13  5:22 ` [PULL 3/9] build: Don't make object files for dtrace on macOS Stefan Hajnoczi
2020-08-13  5:22   ` Stefan Hajnoczi
2020-08-13  5:22 ` [PULL 4/9] net/colo: Match is-enabled probe to tracepoint Stefan Hajnoczi
2020-08-13  5:22   ` Stefan Hajnoczi
2020-08-13  5:22 ` [PULL 5/9] softmmu: Add missing trace-events file Stefan Hajnoczi
2020-08-13  5:22   ` Stefan Hajnoczi
2020-08-13  5:22 ` Stefan Hajnoczi [this message]
2020-08-13  5:22   ` [PULL 6/9] scripts/cleanup-trace-events: Fix for vcpu property Stefan Hajnoczi
2020-08-13  5:22 ` [PULL 7/9] scripts/cleanup-trace-events: Emit files in alphabetical order Stefan Hajnoczi
2020-08-13  5:22   ` Stefan Hajnoczi
2020-08-13  5:22 ` [PULL 8/9] trace-events: Delete unused trace points Stefan Hajnoczi
2020-08-13  5:22   ` Stefan Hajnoczi
2020-08-13  5:22 ` [PULL 9/9] trace-events: Fix attribution of trace points to source Stefan Hajnoczi
2020-08-13  5:22   ` Stefan Hajnoczi
2020-08-13 10:31 ` [PULL 0/9] Tracing patches no-reply
2020-08-13 10:31   ` no-reply
2020-08-13 10:47 ` no-reply
2020-08-13 10:47   ` no-reply
2020-08-13 12:17   ` Stefan Hajnoczi
2020-08-13 12:17     ` Stefan Hajnoczi
2020-08-21 16:25 ` Peter Maydell
2020-08-21 16:25   ` Peter Maydell
2020-09-09 10:20   ` Stefan Hajnoczi
2020-09-09 10:20     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813052257.226142-7-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=chen.zhang@intel.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=sagark@eecs.berkeley.edu \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.