[Intel-gfx] [PATCH 1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1

[Intel-gfx] [PATCH 1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1

[Nischal Varide]

---
 drivers/gpu/drm/i915/display/intel_cdclk.c | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index 9d6cacbdb691..1cd0ab5b36d2 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -1926,7 +1926,11 @@ intel_set_cdclk_pre_plane_update(struct intel_atomic_state *state)
 		intel_atomic_get_old_cdclk_state(state);
 	const struct intel_cdclk_state *new_cdclk_state =
 		intel_atomic_get_new_cdclk_state(state);
-	enum pipe pipe = new_cdclk_state->pipe;
+	enum pipe pipe;
+
+	if (!(old_cdclk_state && new_cdclk_state))
+		return
+	(void)(pipe = new_cdclk_state->pipe);
 
 	if (!intel_cdclk_changed(&old_cdclk_state->actual,
 				 &new_cdclk_state->actual))
@@ -1955,7 +1959,13 @@ intel_set_cdclk_post_plane_update(struct intel_atomic_state *state)
 		intel_atomic_get_old_cdclk_state(state);
 	const struct intel_cdclk_state *new_cdclk_state =
 		intel_atomic_get_new_cdclk_state(state);
-	enum pipe pipe = new_cdclk_state->pipe;
+	enum pipe pipe;
+
+	if (!(old_cdclk_state && new_cdclk_state))
+		return
+	(void)(pipe = new_cdclk_state->pipe);
+
+
 
 	if (!intel_cdclk_changed(&old_cdclk_state->actual,
 				 &new_cdclk_state->actual))
@@ -2484,6 +2494,9 @@ int intel_modeset_calc_cdclk(struct intel_atomic_state *state)
 
 	old_cdclk_state = intel_atomic_get_old_cdclk_state(state);
 
+	if (!(old_cdclk_state && new_cdclk_state))
+		return
+
 	new_cdclk_state->active_pipes =
 		intel_calc_active_pipes(state, old_cdclk_state->active_pipes);
 
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/8] Critical KlockWork Error - Fixes - intel_atomic.c - Possible NullPointerDereference1

[Nischal Varide]

---
 drivers/gpu/drm/i915/display/intel_atomic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c
index 630f49b7aa01..49ca65b207df 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic.c
@@ -192,6 +192,8 @@ intel_connector_needs_modeset(struct intel_atomic_state *state,
 
 	old_conn_state = drm_atomic_get_old_connector_state(&state->base, connector);
 	new_conn_state = drm_atomic_get_new_connector_state(&state->base, connector);
+	if (!(old_conn_state && new_conn_state))
+		return 0;
 
 	return old_conn_state->crtc != new_conn_state->crtc ||
 	       (new_conn_state->crtc &&
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 3/8] Critical KlockWork Error - Fixes - intel_fbdev.c - Possible NullPointerDereference1

[Nischal Varide]

---
 drivers/gpu/drm/i915/display/intel_fbdev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index bd39eb6a21b8..ec4f82559fc1 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -595,9 +595,11 @@ void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous
 	 * been restored from swap. If the object is stolen however, it will be
 	 * full of whatever garbage was left in there.
 	 */
-	if (state == FBINFO_STATE_RUNNING &&
-	    intel_fb_obj(&ifbdev->fb->base)->stolen)
+	if (ifbdev->fb && intel_fb_obj(&ifbdev->fb->base)) {
+	    if (state == FBINFO_STATE_RUNNING &&
+		    intel_fb_obj(&ifbdev->fb->base)->stolen)
 		memset_io(info->screen_base, 0, info->screen_size);
+	}
 
 	drm_fb_helper_set_suspend(&ifbdev->helper, state);
 	console_unlock();
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 4/8] Critical KlockWork Error - Fixes - intel_display.c - Possible NullPointerDereference1

[Nischal Varide]

---
 drivers/gpu/drm/i915/display/intel_display.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 2ddabf92adde..30d189094e97 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -2265,9 +2265,9 @@ intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
 	pinctl = 0;
 	if (HAS_GMCH(dev_priv))
 		pinctl |= PIN_MAPPABLE;
-
-	vma = i915_gem_object_pin_to_display_plane(obj,
-						   alignment, view, pinctl);
+	if (obj)
+	    vma = i915_gem_object_pin_to_display_plane(obj,
+		    alignment, view, pinctl);
 	if (IS_ERR(vma))
 		goto err;
 
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 5/8] Critical KlockWork Error - Fixes - intel_sdvo.c - Possible NullPointerDereference1

[Nischal Varide]

---
 drivers/gpu/drm/i915/display/intel_sdvo.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index 2da4388e1540..279b2be958bb 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -2505,6 +2505,9 @@ static int intel_sdvo_atomic_check(struct drm_connector *conn,
 	struct intel_sdvo_connector_state *new_state =
 		to_intel_sdvo_connector_state(new_conn_state);
 
+	if (!(new_conn_state && old_conn_state && old_state && new_state))
+	    return 0;
+
 	if (new_conn_state->crtc &&
 	    (memcmp(&old_state->tv, &new_state->tv, sizeof(old_state->tv)) ||
 	     memcmp(&old_conn_state->tv, &new_conn_state->tv, sizeof(old_conn_state->tv)))) {
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 6/8] Critical KlockWork Error - Fixes - intel_tv.c - Possible NullPointerDereference1

[Nischal Varide]

---
 drivers/gpu/drm/i915/display/intel_tv.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c
index 777032d9697b..862ea94ffdae 100644
--- a/drivers/gpu/drm/i915/display/intel_tv.c
+++ b/drivers/gpu/drm/i915/display/intel_tv.c
@@ -1842,14 +1842,17 @@ static int intel_tv_atomic_check(struct drm_connector *connector,
 	old_state = drm_atomic_get_old_connector_state(state, connector);
 	new_crtc_state = drm_atomic_get_new_crtc_state(state, new_state->crtc);
 
-	if (old_state->tv.mode != new_state->tv.mode ||
-	    old_state->tv.margins.left != new_state->tv.margins.left ||
-	    old_state->tv.margins.right != new_state->tv.margins.right ||
-	    old_state->tv.margins.top != new_state->tv.margins.top ||
-	    old_state->tv.margins.bottom != new_state->tv.margins.bottom) {
+	if (old_state && new_state && new_crtc_state) {
+
+	    if (old_state->tv.mode != new_state->tv.mode ||
+		    old_state->tv.margins.left != new_state->tv.margins.left ||
+		    old_state->tv.margins.right != new_state->tv.margins.right ||
+		    old_state->tv.margins.top != new_state->tv.margins.top ||
+		    old_state->tv.margins.bottom != new_state->tv.margins.bottom) {
 		/* Force a modeset. */
 
 		new_crtc_state->connectors_changed = true;
+	    }
 	}
 
 	return 0;
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 7/8] Critical KlockWork Error - Fixes - intel_display_power.c - Possible NullPointerDereference2

[Nischal Varide]

---
 drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 7946c6af4b1e..9530f6e0b10c 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -601,6 +601,9 @@ icl_tc_phy_aux_power_well_enable(struct drm_i915_private *dev_priv,
 	bool timeout_expected;
 	u32 val;
 
+	if (!dig_port) 
+	    return;
+
 	icl_tc_port_assert_ref_held(dev_priv, power_well, dig_port);
 
 	val = intel_de_read(dev_priv, DP_AUX_CH_CTL(aux_ch));
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 8/8] Critical KlockWork Error - Fixes - intel_combo_phy.c Uninitialized Variable-1

[Nischal Varide]

---
 drivers/gpu/drm/i915/display/intel_combo_phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
index eccaa79cb4a9..6e721b8ed611 100644
--- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
@@ -258,7 +258,7 @@ static bool phy_is_master(struct drm_i915_private *dev_priv, enum phy phy)
 static bool icl_combo_phy_verify_state(struct drm_i915_private *dev_priv,
 				       enum phy phy)
 {
-	bool ret;
+	bool ret = 1;
 	u32 expected_val = 0;
 
 	if (!icl_combo_phy_enabled(dev_priv, phy))
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 8/8] Critical KlockWork Error - Fixes - intel_combo_phy.c Uninitialized Variable-1

[Anshuman Gupta]

On 2020-08-14 at 08:19:50 +0530, Nischal Varide wrote:
> ---
>  drivers/gpu/drm/i915/display/intel_combo_phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> index eccaa79cb4a9..6e721b8ed611 100644
> --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> @@ -258,7 +258,7 @@ static bool phy_is_master(struct drm_i915_private *dev_priv, enum phy phy)
>  static bool icl_combo_phy_verify_state(struct drm_i915_private *dev_priv,
>  				       enum phy phy)
>  {
> -	bool ret;
> +	bool ret = 1;
IMHO in this function in each code flow ret is assigned with some value,
so i have not noticed any case ret could return any garbag value here.
It seems a false alarm to me.
Thanks,
Anshuman Gupta.
>  	u32 expected_val = 0;
>  
>  	if (!icl_combo_phy_enabled(dev_priv, phy))
> -- 
> 2.26.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1

[Patchwork]

== Series Details ==

Series: series starting with [1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1
URL   : https://patchwork.freedesktop.org/series/80622/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b5bd9c17f5da Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:36: CHECK:LINE_SPACING: Please don't use multiple blank lines
#36: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1968:
+
+

-:49: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 1 checks, 35 lines checked
40f6a6747f32 Critical KlockWork Error - Fixes - intel_atomic.c - Possible NullPointerDereference1
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:20: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 8 lines checked
72231b698a7d Critical KlockWork Error - Fixes - intel_fbdev.c - Possible NullPointerDereference1
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:18: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#18: FILE: drivers/gpu/drm/i915/display/intel_fbdev.c:598:
+	if (ifbdev->fb && intel_fb_obj(&ifbdev->fb->base)) {
+	    if (state == FBINFO_STATE_RUNNING &&

-:19: WARNING:TABSTOP: Statements should start on a tabstop
#19: FILE: drivers/gpu/drm/i915/display/intel_fbdev.c:599:
+	    if (state == FBINFO_STATE_RUNNING &&

-:20: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#20: FILE: drivers/gpu/drm/i915/display/intel_fbdev.c:600:
+	    if (state == FBINFO_STATE_RUNNING &&
+		    intel_fb_obj(&ifbdev->fb->base)->stolen)

-:25: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 3 warnings, 1 checks, 13 lines checked
f2f5b020a8e8 Critical KlockWork Error - Fixes - intel_display.c - Possible NullPointerDereference1
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:19: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#19: FILE: drivers/gpu/drm/i915/display/intel_display.c:2268:
+	if (obj)
+	    vma = i915_gem_object_pin_to_display_plane(obj,

-:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#21: FILE: drivers/gpu/drm/i915/display/intel_display.c:2270:
+	    vma = i915_gem_object_pin_to_display_plane(obj,
+		    alignment, view, pinctl);

-:24: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 2 warnings, 1 checks, 12 lines checked
ad3c9fa781ce Critical KlockWork Error - Fixes - intel_sdvo.c - Possible NullPointerDereference1
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:16: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#16: FILE: drivers/gpu/drm/i915/display/intel_sdvo.c:2508:
+	if (!(new_conn_state && old_conn_state && old_state && new_state))
+	    return 0;

-:17: WARNING:TABSTOP: Statements should start on a tabstop
#17: FILE: drivers/gpu/drm/i915/display/intel_sdvo.c:2509:
+	    return 0;

-:21: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 3 warnings, 0 checks, 9 lines checked
35e611290838 Critical KlockWork Error - Fixes - intel_tv.c - Possible NullPointerDereference1
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:21: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#21: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1845:
+	if (old_state && new_state && new_crtc_state) {
[...]
+	    if (old_state->tv.mode != new_state->tv.mode ||

-:22: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#22: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1846:
+	if (old_state && new_state && new_crtc_state) {
+

-:23: WARNING:TABSTOP: Statements should start on a tabstop
#23: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1847:
+	    if (old_state->tv.mode != new_state->tv.mode ||

-:24: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#24: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1848:
+	    if (old_state->tv.mode != new_state->tv.mode ||
+		    old_state->tv.margins.left != new_state->tv.margins.left ||

-:31: WARNING:TABSTOP: Statements should start on a tabstop
#31: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1855:
+	    }

-:34: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 4 warnings, 2 checks, 22 lines checked
b91c796bdad7 Critical KlockWork Error - Fixes - intel_display_power.c - Possible NullPointerDereference2
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:16: ERROR:TRAILING_WHITESPACE: trailing whitespace
#16: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:604:
+^Iif (!dig_port) $

-:16: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#16: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:604:
+	if (!dig_port) 
+	    return;

-:17: WARNING:TABSTOP: Statements should start on a tabstop
#17: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:605:
+	    return;

-:21: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 3 warnings, 0 checks, 9 lines checked
aae7f8d354af Critical KlockWork Error - Fixes - intel_combo_phy.c Uninitialized Variable-1
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:20: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 8 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1

[Shankar, Uma]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Patchwork
> Sent: Friday, August 14, 2020 3:44 PM
> To: Varide, Nischal <nischal.varide@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8]
> Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1
> 
> == Series Details ==
> 
> Series: series starting with [1/8] Critical KlockWork Error - Fixes - intel_cdclk.c -
> Possible NullPointerDereference1
> URL   : https://patchwork.freedesktop.org/series/80622/
> State : warning

Please fix the checkpatch warnings and resend.

> == Summary ==
> 
> $ dim checkpatch origin/drm-tip
> b5bd9c17f5da Critical KlockWork Error - Fixes - intel_cdclk.c - Possible
> NullPointerDereference1
> -:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> appropriate one
> 
> -:36: CHECK:LINE_SPACING: Please don't use multiple blank lines
> #36: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1968:
> +
> +
> 
> -:49: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
> 
> total: 1 errors, 1 warnings, 1 checks, 35 lines checked
> 40f6a6747f32 Critical KlockWork Error - Fixes - intel_atomic.c - Possible
> NullPointerDereference1
> -:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> appropriate one
> 
> -:20: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
> 
> total: 1 errors, 1 warnings, 0 checks, 8 lines checked 72231b698a7d Critical
> KlockWork Error - Fixes - intel_fbdev.c - Possible NullPointerDereference1
> -:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> appropriate one
> 
> -:18: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional
> statements (8, 12)
> #18: FILE: drivers/gpu/drm/i915/display/intel_fbdev.c:598:
> +	if (ifbdev->fb && intel_fb_obj(&ifbdev->fb->base)) {
> +	    if (state == FBINFO_STATE_RUNNING &&
> 
> -:19: WARNING:TABSTOP: Statements should start on a tabstop
> #19: FILE: drivers/gpu/drm/i915/display/intel_fbdev.c:599:
> +	    if (state == FBINFO_STATE_RUNNING &&
> 
> -:20: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open
> parenthesis
> #20: FILE: drivers/gpu/drm/i915/display/intel_fbdev.c:600:
> +	    if (state == FBINFO_STATE_RUNNING &&
> +		    intel_fb_obj(&ifbdev->fb->base)->stolen)
> 
> -:25: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
> 
> total: 1 errors, 3 warnings, 1 checks, 13 lines checked
> f2f5b020a8e8 Critical KlockWork Error - Fixes - intel_display.c - Possible
> NullPointerDereference1
> -:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> appropriate one
> 
> -:19: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional
> statements (8, 12)
> #19: FILE: drivers/gpu/drm/i915/display/intel_display.c:2268:
> +	if (obj)
> +	    vma = i915_gem_object_pin_to_display_plane(obj,
> 
> -:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open
> parenthesis
> #21: FILE: drivers/gpu/drm/i915/display/intel_display.c:2270:
> +	    vma = i915_gem_object_pin_to_display_plane(obj,
> +		    alignment, view, pinctl);
> 
> -:24: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
> 
> total: 1 errors, 2 warnings, 1 checks, 12 lines checked ad3c9fa781ce Critical
> KlockWork Error - Fixes - intel_sdvo.c - Possible NullPointerDereference1
> -:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> appropriate one
> 
> -:16: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional
> statements (8, 12)
> #16: FILE: drivers/gpu/drm/i915/display/intel_sdvo.c:2508:
> +	if (!(new_conn_state && old_conn_state && old_state && new_state))
> +	    return 0;
> 
> -:17: WARNING:TABSTOP: Statements should start on a tabstop
> #17: FILE: drivers/gpu/drm/i915/display/intel_sdvo.c:2509:
> +	    return 0;
> 
> -:21: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
> 
> total: 1 errors, 3 warnings, 0 checks, 9 lines checked
> 35e611290838 Critical KlockWork Error - Fixes - intel_tv.c - Possible
> NullPointerDereference1
> -:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> appropriate one
> 
> -:21: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional
> statements (8, 12)
> #21: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1845:
> +	if (old_state && new_state && new_crtc_state) {
> [...]
> +	    if (old_state->tv.mode != new_state->tv.mode ||
> 
> -:22: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
> #22: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1846:
> +	if (old_state && new_state && new_crtc_state) {
> +
> 
> -:23: WARNING:TABSTOP: Statements should start on a tabstop
> #23: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1847:
> +	    if (old_state->tv.mode != new_state->tv.mode ||
> 
> -:24: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open
> parenthesis
> #24: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1848:
> +	    if (old_state->tv.mode != new_state->tv.mode ||
> +		    old_state->tv.margins.left != new_state->tv.margins.left ||
> 
> -:31: WARNING:TABSTOP: Statements should start on a tabstop
> #31: FILE: drivers/gpu/drm/i915/display/intel_tv.c:1855:
> +	    }
> 
> -:34: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
> 
> total: 1 errors, 4 warnings, 2 checks, 22 lines checked
> b91c796bdad7 Critical KlockWork Error - Fixes - intel_display_power.c - Possible
> NullPointerDereference2
> -:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> appropriate one
> 
> -:16: ERROR:TRAILING_WHITESPACE: trailing whitespace
> #16: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:604:
> +^Iif (!dig_port) $
> 
> -:16: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional
> statements (8, 12)
> #16: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:604:
> +	if (!dig_port)
> +	    return;
> 
> -:17: WARNING:TABSTOP: Statements should start on a tabstop
> #17: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:605:
> +	    return;
> 
> -:21: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
> 
> total: 2 errors, 3 warnings, 0 checks, 9 lines checked aae7f8d354af Critical
> KlockWork Error - Fixes - intel_combo_phy.c Uninitialized Variable-1
> -:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> appropriate one
> 
> -:20: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
> 
> total: 1 errors, 1 warnings, 0 checks, 8 lines checked
> 
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1

[Patchwork]

== Series Details ==

Series: series starting with [1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1
URL   : https://patchwork.freedesktop.org/series/80622/
State : warning

== Summary ==

$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_cdclk.c:1933:10: error: return expression in void function
+drivers/gpu/drm/i915/display/intel_cdclk.c:1966:10: error: return expression in void function


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 11450 bytes --]

== Series Details ==

Series: series starting with [1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1
URL   : https://patchwork.freedesktop.org/series/80622/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8882 -> Patchwork_18357
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_18357 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_18357, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_18357:

### IGT changes ###

#### Possible regressions ####

  * igt@runner@aborted:
    - fi-bsw-kefka:       NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-bsw-kefka/igt@runner@aborted.html
    - fi-byt-j1900:       NOTRUN -> [FAIL][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-byt-j1900/igt@runner@aborted.html

  
#### Warnings ####

  * igt@runner@aborted:
    - fi-tgl-u2:          [FAIL][3] ([i915#1233] / [i915#2110]) -> [FAIL][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-tgl-u2/igt@runner@aborted.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-tgl-u2/igt@runner@aborted.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@runner@aborted:
    - {fi-tgl-dsi}:       NOTRUN -> [FAIL][5]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-tgl-dsi/igt@runner@aborted.html
    - {fi-ehl-1}:         NOTRUN -> [FAIL][6]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-ehl-1/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in Patchwork_18357 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-r:           [PASS][7] -> [DMESG-WARN][8] ([i915#93] / [i915#95]) +37 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html
    - fi-apl-guc:         [PASS][9] -> [INCOMPLETE][10] ([i915#1242] / [i915#1635])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-apl-guc/igt@gem_exec_suspend@basic-s0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-apl-guc/igt@gem_exec_suspend@basic-s0.html
    - fi-bxt-dsi:         [PASS][11] -> [INCOMPLETE][12] ([i915#1242] / [i915#1635])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-bxt-dsi/igt@gem_exec_suspend@basic-s0.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-bxt-dsi/igt@gem_exec_suspend@basic-s0.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-bsw-kefka:       [PASS][13] -> [DMESG-WARN][14] ([i915#89]) +11 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
    - fi-bsw-n3050:       [PASS][15] -> [DMESG-WARN][16] ([i915#89]) +20 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-bsw-n3050/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-bsw-n3050/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html

  * igt@kms_flip@basic-flip-vs-dpms@a-edp1:
    - fi-bsw-kefka:       [PASS][17] -> [INCOMPLETE][18] ([i915#1250] / [i915#1436])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-bsw-kefka/igt@kms_flip@basic-flip-vs-dpms@a-edp1.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-bsw-kefka/igt@kms_flip@basic-flip-vs-dpms@a-edp1.html

  * igt@kms_flip@basic-flip-vs-dpms@a-vga1:
    - fi-byt-j1900:       [PASS][19] -> [INCOMPLETE][20] ([i915#1436] / [i915#258])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-byt-j1900/igt@kms_flip@basic-flip-vs-dpms@a-vga1.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-byt-j1900/igt@kms_flip@basic-flip-vs-dpms@a-vga1.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-bsw-n3050:       [PASS][21] -> [DMESG-FAIL][22] ([i915#49] / [i915#89])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-bsw-n3050/igt@kms_frontbuffer_tracking@basic.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-bsw-n3050/igt@kms_frontbuffer_tracking@basic.html
    - fi-skl-6600u:       [PASS][23] -> [DMESG-FAIL][24] ([i915#49] / [i915#88])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-skl-6600u/igt@kms_frontbuffer_tracking@basic.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-skl-6600u/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
    - fi-skl-6600u:       [PASS][25] -> [DMESG-WARN][26] ([i915#88]) +37 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-skl-6600u/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-skl-6600u/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html

  * igt@kms_psr@cursor_plane_move:
    - fi-kbl-r:           [PASS][27] -> [SKIP][28] ([fdo#109271] / [i915#668]) +3 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-kbl-r/igt@kms_psr@cursor_plane_move.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-kbl-r/igt@kms_psr@cursor_plane_move.html

  * igt@kms_psr@primary_page_flip:
    - fi-skl-6600u:       [PASS][29] -> [SKIP][30] ([fdo#109271] / [i915#668]) +3 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

  
#### Warnings ####

  * igt@i915_pm_rpm@module-reload:
    - fi-kbl-guc:         [DMESG-WARN][31] ([i915#2203]) -> [DMESG-FAIL][32] ([i915#2203])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-bsw-n3050:       [DMESG-WARN][33] ([i915#1982]) -> [DMESG-WARN][34] ([i915#1982] / [i915#89])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
    - fi-kbl-r:           [DMESG-WARN][35] ([i915#1982]) -> [DMESG-WARN][36] ([i915#93] / [i915#95])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-kbl-r/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-kbl-r/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_force_connector_basic@force-edid:
    - fi-kbl-x1275:       [DMESG-WARN][37] ([i915#62] / [i915#92]) -> [DMESG-WARN][38] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html

  * igt@prime_vgem@basic-fence-flip:
    - fi-kbl-x1275:       [DMESG-WARN][39] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][40] ([i915#62] / [i915#92]) +3 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8882/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233
  [i915#1242]: https://gitlab.freedesktop.org/drm/intel/issues/1242
  [i915#1250]: https://gitlab.freedesktop.org/drm/intel/issues/1250
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
  [i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
  [i915#258]: https://gitlab.freedesktop.org/drm/intel/issues/258
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
  [i915#88]: https://gitlab.freedesktop.org/drm/intel/issues/88
  [i915#89]: https://gitlab.freedesktop.org/drm/intel/issues/89
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (44 -> 37)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_8882 -> Patchwork_18357

  CI-20190529: 20190529
  CI_DRM_8882: bc285974fbc945765c176218aba7a003b687eea9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_18357: aae7f8d354af91c9b64f787a9e69a8dc8b949ead @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

aae7f8d354af Critical KlockWork Error - Fixes - intel_combo_phy.c Uninitialized Variable-1
b91c796bdad7 Critical KlockWork Error - Fixes - intel_display_power.c - Possible NullPointerDereference2
35e611290838 Critical KlockWork Error - Fixes - intel_tv.c - Possible NullPointerDereference1
ad3c9fa781ce Critical KlockWork Error - Fixes - intel_sdvo.c - Possible NullPointerDereference1
f2f5b020a8e8 Critical KlockWork Error - Fixes - intel_display.c - Possible NullPointerDereference1
72231b698a7d Critical KlockWork Error - Fixes - intel_fbdev.c - Possible NullPointerDereference1
40f6a6747f32 Critical KlockWork Error - Fixes - intel_atomic.c - Possible NullPointerDereference1
b5bd9c17f5da Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18357/index.html

[-- Attachment #1.2: Type: text/html, Size: 14128 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/8] Critical KlockWork Error - Fixes - intel_cdclk.c - Possible NullPointerDereference1

[Shankar, Uma]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Nischal
> Varide
> Sent: Friday, August 14, 2020 8:20 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Varide, Nischal <nischal.varide@intel.com>
> Subject: [Intel-gfx] [PATCH 1/8] Critical KlockWork Error - Fixes - intel_cdclk.c -
> Possible NullPointerDereference1

Add some commit description explaining the clockwork warning.

Also append all display patches (in display folder) with "drm/i915/display :"
in the commit headers. For generic path have "drm/i915:" as prefix.
Please check the format used in patches already merged to tree.

> ---
>  drivers/gpu/drm/i915/display/intel_cdclk.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c
> b/drivers/gpu/drm/i915/display/intel_cdclk.c
> index 9d6cacbdb691..1cd0ab5b36d2 100644
> --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> @@ -1926,7 +1926,11 @@ intel_set_cdclk_pre_plane_update(struct
> intel_atomic_state *state)
>  		intel_atomic_get_old_cdclk_state(state);
>  	const struct intel_cdclk_state *new_cdclk_state =
>  		intel_atomic_get_new_cdclk_state(state);
> -	enum pipe pipe = new_cdclk_state->pipe;
> +	enum pipe pipe;
> +
> +	if (!(old_cdclk_state && new_cdclk_state))
> +		return
> +	(void)(pipe = new_cdclk_state->pipe);

Is this typecast really needed ?

> 
>  	if (!intel_cdclk_changed(&old_cdclk_state->actual,
>  				 &new_cdclk_state->actual))
> @@ -1955,7 +1959,13 @@ intel_set_cdclk_post_plane_update(struct
> intel_atomic_state *state)
>  		intel_atomic_get_old_cdclk_state(state);
>  	const struct intel_cdclk_state *new_cdclk_state =
>  		intel_atomic_get_new_cdclk_state(state);
> -	enum pipe pipe = new_cdclk_state->pipe;
> +	enum pipe pipe;
> +
> +	if (!(old_cdclk_state && new_cdclk_state))
> +		return
> +	(void)(pipe = new_cdclk_state->pipe);

Same here.

> +
> +
> 
>  	if (!intel_cdclk_changed(&old_cdclk_state->actual,
>  				 &new_cdclk_state->actual))
> @@ -2484,6 +2494,9 @@ int intel_modeset_calc_cdclk(struct intel_atomic_state
> *state)
> 
>  	old_cdclk_state = intel_atomic_get_old_cdclk_state(state);
> 
> +	if (!(old_cdclk_state && new_cdclk_state))
> +		return
> +
>  	new_cdclk_state->active_pipes =
>  		intel_calc_active_pipes(state, old_cdclk_state->active_pipes);
> 
> --
> 2.26.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx