All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	od@zcrc.me, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] drm/panel: novatek, nt39016: Reorder calls in probe
Date: Thu, 20 Aug 2020 17:53:02 +0200	[thread overview]
Message-ID: <20200820155302.GA194134@ravnborg.org> (raw)
In-Reply-To: <20200820121256.32037-2-paul@crapouillou.net>

On Thu, Aug 20, 2020 at 02:12:55PM +0200, Paul Cercueil wrote:
> The drm_panel_of_backlight() function must be called after
> drm_panel_init(), according to the function's documentation; otherwise
> the backlight won't be properly initialized.
> 
> v2: New patch
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  drivers/gpu/drm/panel/panel-novatek-nt39016.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c b/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> index 39f7be679da5..daa583030246 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> @@ -285,6 +285,9 @@ static int nt39016_probe(struct spi_device *spi)
>  		return PTR_ERR(panel->map);
>  	}
>  
> +	drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs,
> +		       DRM_MODE_CONNECTOR_DPI);
> +
>  	err = drm_panel_of_backlight(&panel->drm_panel);
>  	if (err) {
>  		if (err != -EPROBE_DEFER)
> @@ -292,9 +295,6 @@ static int nt39016_probe(struct spi_device *spi)
>  		return err;
>  	}
>  
> -	drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs,
> -		       DRM_MODE_CONNECTOR_DPI);
> -
>  	drm_panel_add(&panel->drm_panel);
>  
>  	return 0;
> -- 
> 2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	od@zcrc.me, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] drm/panel: novatek,nt39016: Reorder calls in probe
Date: Thu, 20 Aug 2020 17:53:02 +0200	[thread overview]
Message-ID: <20200820155302.GA194134@ravnborg.org> (raw)
In-Reply-To: <20200820121256.32037-2-paul@crapouillou.net>

On Thu, Aug 20, 2020 at 02:12:55PM +0200, Paul Cercueil wrote:
> The drm_panel_of_backlight() function must be called after
> drm_panel_init(), according to the function's documentation; otherwise
> the backlight won't be properly initialized.
> 
> v2: New patch
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  drivers/gpu/drm/panel/panel-novatek-nt39016.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c b/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> index 39f7be679da5..daa583030246 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt39016.c
> @@ -285,6 +285,9 @@ static int nt39016_probe(struct spi_device *spi)
>  		return PTR_ERR(panel->map);
>  	}
>  
> +	drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs,
> +		       DRM_MODE_CONNECTOR_DPI);
> +
>  	err = drm_panel_of_backlight(&panel->drm_panel);
>  	if (err) {
>  		if (err != -EPROBE_DEFER)
> @@ -292,9 +295,6 @@ static int nt39016_probe(struct spi_device *spi)
>  		return err;
>  	}
>  
> -	drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs,
> -		       DRM_MODE_CONNECTOR_DPI);
> -
>  	drm_panel_add(&panel->drm_panel);
>  
>  	return 0;
> -- 
> 2.28.0

  reply	other threads:[~2020-08-20 15:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 12:12 [PATCH v2 0/2] NT39016 cleanup Paul Cercueil
2020-08-20 12:12 ` Paul Cercueil
2020-08-20 12:12 ` [PATCH v2 1/2] drm/panel: novatek,nt39016: Reorder calls in probe Paul Cercueil
2020-08-20 12:12   ` Paul Cercueil
2020-08-20 15:53   ` Sam Ravnborg [this message]
2020-08-20 15:53     ` Sam Ravnborg
2020-08-20 16:37     ` [PATCH v2 1/2] drm/panel: novatek, nt39016: " Paul Cercueil
2020-08-20 16:37       ` [PATCH v2 1/2] drm/panel: novatek,nt39016: " Paul Cercueil
2020-08-20 12:12 ` [PATCH v2 2/2] drm/panel: novatek, nt39016: Remove 'dev' field in priv struct Paul Cercueil
2020-08-20 12:12   ` [PATCH v2 2/2] drm/panel: novatek,nt39016: " Paul Cercueil
2020-08-20 15:53   ` [PATCH v2 2/2] drm/panel: novatek, nt39016: " Sam Ravnborg
2020-08-20 15:53     ` [PATCH v2 2/2] drm/panel: novatek,nt39016: " Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820155302.GA194134@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=od@zcrc.me \
    --cc=paul@crapouillou.net \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.