From: Bilal Wasim <bwasim.lkml@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: drinkcat@chromium.org, Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
laurent.pinchart@ideasonboard.com, hsinyi@chromium.org,
matthias.bgg@gmail.com,
Collabora Kernel ML <kernel@collabora.com>,
sam@ravnborg.org
Subject: Re: [PATCH v2 1/5] drm/bridge_connector: Set default status connected for eDP connectors
Date: Wed, 26 Aug 2020 17:37:46 +0500 [thread overview]
Message-ID: <20200826173746.622c2af9@a-VirtualBox> (raw)
In-Reply-To: <20200826081526.674866-2-enric.balletbo@collabora.com>
On Wed, 26 Aug 2020 10:15:22 +0200
Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote:
> In an eDP application, HPD is not required and on most bridge chips
> useless. If HPD is not used, we need to set initial status as
> connected, otherwise the connector created by the
> drm_bridge_connector API remains in an unknown state.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v2:
> - Included the patch `drm/bridge_connector: Set default status
> connected for eDP connectors`
>
> drivers/gpu/drm/drm_bridge_connector.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_bridge_connector.c
> b/drivers/gpu/drm/drm_bridge_connector.c index
> c6994fe673f3..a58cbde59c34 100644 ---
> a/drivers/gpu/drm/drm_bridge_connector.c +++
> b/drivers/gpu/drm/drm_bridge_connector.c @@ -187,6 +187,7 @@
> drm_bridge_connector_detect(struct drm_connector *connector, bool
> force) case DRM_MODE_CONNECTOR_DPI: case DRM_MODE_CONNECTOR_LVDS:
> case DRM_MODE_CONNECTOR_DSI:
> + case DRM_MODE_CONNECTOR_eDP:
> status = connector_status_connected;
> break;
> default:
Reviewed-by: Bilal Wasim <bwasim.lkml@gmail.com>
Tested-by: Bilal Wasim <bwasim.lkml@gmail.com>
-Bilal
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Bilal Wasim <bwasim.lkml@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
matthias.bgg@gmail.com, drinkcat@chromium.org,
hsinyi@chromium.org, laurent.pinchart@ideasonboard.com,
sam@ravnborg.org, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/5] drm/bridge_connector: Set default status connected for eDP connectors
Date: Wed, 26 Aug 2020 17:37:46 +0500 [thread overview]
Message-ID: <20200826173746.622c2af9@a-VirtualBox> (raw)
In-Reply-To: <20200826081526.674866-2-enric.balletbo@collabora.com>
On Wed, 26 Aug 2020 10:15:22 +0200
Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote:
> In an eDP application, HPD is not required and on most bridge chips
> useless. If HPD is not used, we need to set initial status as
> connected, otherwise the connector created by the
> drm_bridge_connector API remains in an unknown state.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v2:
> - Included the patch `drm/bridge_connector: Set default status
> connected for eDP connectors`
>
> drivers/gpu/drm/drm_bridge_connector.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_bridge_connector.c
> b/drivers/gpu/drm/drm_bridge_connector.c index
> c6994fe673f3..a58cbde59c34 100644 ---
> a/drivers/gpu/drm/drm_bridge_connector.c +++
> b/drivers/gpu/drm/drm_bridge_connector.c @@ -187,6 +187,7 @@
> drm_bridge_connector_detect(struct drm_connector *connector, bool
> force) case DRM_MODE_CONNECTOR_DPI: case DRM_MODE_CONNECTOR_LVDS:
> case DRM_MODE_CONNECTOR_DSI:
> + case DRM_MODE_CONNECTOR_eDP:
> status = connector_status_connected;
> break;
> default:
Reviewed-by: Bilal Wasim <bwasim.lkml@gmail.com>
Tested-by: Bilal Wasim <bwasim.lkml@gmail.com>
-Bilal
next prev parent reply other threads:[~2020-08-27 6:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 8:15 [PATCH v2 0/5] drm/bridge: ps8640: Make sure all needed is powered to get the EDID Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 8:15 ` [PATCH v2 1/5] drm/bridge_connector: Set default status connected for eDP connectors Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 12:37 ` Bilal Wasim [this message]
2020-08-26 12:37 ` Bilal Wasim
2020-08-26 8:15 ` [PATCH v2 2/5] drm/bridge: ps8640: Get the EDID from eDP control Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 8:15 ` [PATCH v2 3/5] drm/bridge: ps8640: Return an error for incorrect attach flags Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 12:45 ` Bilal Wasim
2020-08-26 12:45 ` Bilal Wasim
2020-08-26 8:15 ` [PATCH v2 4/5] drm/bridge: ps8640: Print an error if VDO control fails Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 12:45 ` Bilal Wasim
2020-08-26 12:45 ` Bilal Wasim
2020-08-26 8:15 ` [PATCH v2 5/5] drm/bridge: ps8640: Rework power state handling Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 13:04 ` Bilal Wasim
2020-08-26 13:04 ` Bilal Wasim
2020-08-26 18:46 ` Sam Ravnborg
2020-08-26 18:46 ` Sam Ravnborg
2020-08-27 8:15 ` Enric Balletbo i Serra
2020-08-27 8:15 ` Enric Balletbo i Serra
2020-08-26 17:20 ` [PATCH v2 0/5] drm/bridge: ps8640: Make sure all needed is powered to get the EDID Sam Ravnborg
2020-08-26 17:20 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826173746.622c2af9@a-VirtualBox \
--to=bwasim.lkml@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.