From: Bilal Wasim <bwasim.lkml@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
drinkcat@chromium.org, Jonas Karlman <jonas@kwiboo.se>,
David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrzej Hajda <a.hajda@samsung.com>,
laurent.pinchart@ideasonboard.com, hsinyi@chromium.org,
matthias.bgg@gmail.com,
Collabora Kernel ML <kernel@collabora.com>,
sam@ravnborg.org
Subject: Re: [PATCH v2 3/5] drm/bridge: ps8640: Return an error for incorrect attach flags
Date: Wed, 26 Aug 2020 17:45:10 +0500 [thread overview]
Message-ID: <20200826174510.0207854f@a-VirtualBox> (raw)
In-Reply-To: <20200826081526.674866-4-enric.balletbo@collabora.com>
On Wed, 26 Aug 2020 10:15:24 +0200
Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote:
> Bridge drivers that implement the new model only shall return an error
> from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR
> flag is not set. So make sure we return an error because only the new
> drm_bridge model is supported.
>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v2: None
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
> b/drivers/gpu/drm/bridge/parade-ps8640.c index
> 13755d278db6..ce3e8b2da8c9 100644 ---
> a/drivers/gpu/drm/bridge/parade-ps8640.c +++
> b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -200,6 +200,10 @@ static
> int ps8640_bridge_attach(struct drm_bridge *bridge, .channel = 0,
> .node = NULL,
> };
> +
> + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR))
> + return -EINVAL;
> +
> /* port@0 is ps8640 dsi input port */
> in_ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, -1);
> if (!in_ep)
Reviewed-by: Bilal Wasim <bwasim.lkml@gmail.com>
Tested-by: Bilal Wasim <bwasim.lkml@gmail.com>
-Bilal
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Bilal Wasim <bwasim.lkml@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
matthias.bgg@gmail.com, drinkcat@chromium.org,
hsinyi@chromium.org, laurent.pinchart@ideasonboard.com,
sam@ravnborg.org, Andrzej Hajda <a.hajda@samsung.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>,
Neil Armstrong <narmstrong@baylibre.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 3/5] drm/bridge: ps8640: Return an error for incorrect attach flags
Date: Wed, 26 Aug 2020 17:45:10 +0500 [thread overview]
Message-ID: <20200826174510.0207854f@a-VirtualBox> (raw)
In-Reply-To: <20200826081526.674866-4-enric.balletbo@collabora.com>
On Wed, 26 Aug 2020 10:15:24 +0200
Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote:
> Bridge drivers that implement the new model only shall return an error
> from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR
> flag is not set. So make sure we return an error because only the new
> drm_bridge model is supported.
>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v2: None
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c
> b/drivers/gpu/drm/bridge/parade-ps8640.c index
> 13755d278db6..ce3e8b2da8c9 100644 ---
> a/drivers/gpu/drm/bridge/parade-ps8640.c +++
> b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -200,6 +200,10 @@ static
> int ps8640_bridge_attach(struct drm_bridge *bridge, .channel = 0,
> .node = NULL,
> };
> +
> + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR))
> + return -EINVAL;
> +
> /* port@0 is ps8640 dsi input port */
> in_ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, -1);
> if (!in_ep)
Reviewed-by: Bilal Wasim <bwasim.lkml@gmail.com>
Tested-by: Bilal Wasim <bwasim.lkml@gmail.com>
-Bilal
next prev parent reply other threads:[~2020-08-27 6:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 8:15 [PATCH v2 0/5] drm/bridge: ps8640: Make sure all needed is powered to get the EDID Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 8:15 ` [PATCH v2 1/5] drm/bridge_connector: Set default status connected for eDP connectors Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 12:37 ` Bilal Wasim
2020-08-26 12:37 ` Bilal Wasim
2020-08-26 8:15 ` [PATCH v2 2/5] drm/bridge: ps8640: Get the EDID from eDP control Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 8:15 ` [PATCH v2 3/5] drm/bridge: ps8640: Return an error for incorrect attach flags Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 12:45 ` Bilal Wasim [this message]
2020-08-26 12:45 ` Bilal Wasim
2020-08-26 8:15 ` [PATCH v2 4/5] drm/bridge: ps8640: Print an error if VDO control fails Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 12:45 ` Bilal Wasim
2020-08-26 12:45 ` Bilal Wasim
2020-08-26 8:15 ` [PATCH v2 5/5] drm/bridge: ps8640: Rework power state handling Enric Balletbo i Serra
2020-08-26 8:15 ` Enric Balletbo i Serra
2020-08-26 13:04 ` Bilal Wasim
2020-08-26 13:04 ` Bilal Wasim
2020-08-26 18:46 ` Sam Ravnborg
2020-08-26 18:46 ` Sam Ravnborg
2020-08-27 8:15 ` Enric Balletbo i Serra
2020-08-27 8:15 ` Enric Balletbo i Serra
2020-08-26 17:20 ` [PATCH v2 0/5] drm/bridge: ps8640: Make sure all needed is powered to get the EDID Sam Ravnborg
2020-08-26 17:20 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826174510.0207854f@a-VirtualBox \
--to=bwasim.lkml@gmail.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.