[Buildroot] [PATCH] infra/kconfig-package: quote HOSTCC_NOCCACHE

[Buildroot] [PATCH] infra/kconfig-package: quote HOSTCC_NOCCACHE

[Yann E. MORIN]

HOSTCC may contain spaces, so needs to be quoted.

Most of the places hwere it is already quoted use double-quotes, so we
use that.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/pkg-kconfig.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/pkg-kconfig.mk b/package/pkg-kconfig.mk
index 45faf50e71..2aecf2e203 100644
--- a/package/pkg-kconfig.mk
+++ b/package/pkg-kconfig.mk
@@ -28,7 +28,7 @@ define kconfig-package-update-config
 endef
 
 PKG_KCONFIG_COMMON_OPTS = \
-	HOSTCC=$(HOSTCC_NOCCACHE)
+	HOSTCC="$(HOSTCC_NOCCACHE)"
 
 # Macro to save the defconfig file
 # $(1): the name of the package in upper-case letters
-- 
2.20.1

[Buildroot] [PATCH] infra/kconfig-package: quote HOSTCC_NOCCACHE

[Thomas Petazzoni]

Hello,

On Sat, 29 Aug 2020 22:42:52 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> HOSTCC may contain spaces, so needs to be quoted.

HOSTCC yes, but HOSTCC_NOCCACHE ?

> Most of the places hwere it is already quoted use double-quotes, so we
> use that.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Minor nit: the commit title prefix should be package/pkg-kconfig.mk.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] infra/kconfig-package: quote HOSTCC_NOCCACHE

[Yann E. MORIN]

Thomas, All,

On 2020-08-29 22:54 +0200, Thomas Petazzoni spake thusly:
> On Sat, 29 Aug 2020 22:42:52 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > HOSTCC may contain spaces, so needs to be quoted.
> HOSTCC yes, but HOSTCC_NOCCACHE ?

Yes, why not?

    $ make HOSTCC="distcc gcc-4.1"

which would yield a HOSTCC_MOCCACHE with a space in it.

Note also that HOSTCC_NOCCACHE is already quoted in most places it is
used.

Regards,
Yann E. MORIN.

> > Most of the places hwere it is already quoted use double-quotes, so we
> > use that.
> > 
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> 
> Minor nit: the commit title prefix should be package/pkg-kconfig.mk.
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'