All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Karthik B S <karthik.b.s@intel.com>
Cc: paulo.r.zanoni@intel.com, michel@daenzer.net,
	dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com,
	daniel.vetter@intel.com, harry.wentland@amd.com,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v6 4/7] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips
Date: Tue, 1 Sep 2020 14:23:46 +0300	[thread overview]
Message-ID: <20200901112346.GI6112@intel.com> (raw)
In-Reply-To: <20200807093551.10673-5-karthik.b.s@intel.com>

On Fri, Aug 07, 2020 at 03:05:48PM +0530, Karthik B S wrote:
> Since the flip done event will be sent in the flip_done_handler,
> no need to add the event to the list and delay it for later.
> 
> v2: -Moved the async check above vblank_get as it
>      was causing issues for PSR.
> 
> v3: -No need to wait for vblank to pass, as this wait was causing a
>      16ms delay once every few flips.
> 
> v4: -Rebased.
> 
> v5: -Rebased.
> 
> v6: -Rebased.
> 
> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_sprite.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> index c26ca029fc0a..2b2d96c59d7f 100644
> --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> @@ -93,6 +93,9 @@ void intel_pipe_update_start(const struct intel_crtc_state *new_crtc_state)
>  	DEFINE_WAIT(wait);
>  	u32 psr_status;
>  
> +	if (new_crtc_state->uapi.async_flip)
> +		goto irq_disable;

We shouldn't really need the irq disable at all if we don't do the
vblank evade. And if we only write ctl+surf then atomicity is already
guaranteed by the hw.

> +
>  	vblank_start = adjusted_mode->crtc_vblank_start;
>  	if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
>  		vblank_start = DIV_ROUND_UP(vblank_start, 2);
> @@ -206,7 +209,7 @@ void intel_pipe_update_end(struct intel_crtc_state *new_crtc_state)
>  	 * Would be slightly nice to just grab the vblank count and arm the
>  	 * event outside of the critical section - the spinlock might spin for a
>  	 * while ... */
> -	if (new_crtc_state->uapi.event) {
> +	if (new_crtc_state->uapi.event && !new_crtc_state->uapi.async_flip) {
>  		drm_WARN_ON(&dev_priv->drm,
>  			    drm_crtc_vblank_get(&crtc->base) != 0);
>  
> @@ -220,6 +223,9 @@ void intel_pipe_update_end(struct intel_crtc_state *new_crtc_state)
>  
>  	local_irq_enable();
>  
> +	if (new_crtc_state->uapi.async_flip)
> +		return;
> +
>  	if (intel_vgpu_active(dev_priv))
>  		return;
>  
> -- 
> 2.22.0

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Karthik B S <karthik.b.s@intel.com>
Cc: paulo.r.zanoni@intel.com, michel@daenzer.net,
	dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com,
	vandita.kulkarni@intel.com, uma.shankar@intel.com,
	daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v6 4/7] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips
Date: Tue, 1 Sep 2020 14:23:46 +0300	[thread overview]
Message-ID: <20200901112346.GI6112@intel.com> (raw)
In-Reply-To: <20200807093551.10673-5-karthik.b.s@intel.com>

On Fri, Aug 07, 2020 at 03:05:48PM +0530, Karthik B S wrote:
> Since the flip done event will be sent in the flip_done_handler,
> no need to add the event to the list and delay it for later.
> 
> v2: -Moved the async check above vblank_get as it
>      was causing issues for PSR.
> 
> v3: -No need to wait for vblank to pass, as this wait was causing a
>      16ms delay once every few flips.
> 
> v4: -Rebased.
> 
> v5: -Rebased.
> 
> v6: -Rebased.
> 
> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_sprite.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> index c26ca029fc0a..2b2d96c59d7f 100644
> --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> @@ -93,6 +93,9 @@ void intel_pipe_update_start(const struct intel_crtc_state *new_crtc_state)
>  	DEFINE_WAIT(wait);
>  	u32 psr_status;
>  
> +	if (new_crtc_state->uapi.async_flip)
> +		goto irq_disable;

We shouldn't really need the irq disable at all if we don't do the
vblank evade. And if we only write ctl+surf then atomicity is already
guaranteed by the hw.

> +
>  	vblank_start = adjusted_mode->crtc_vblank_start;
>  	if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
>  		vblank_start = DIV_ROUND_UP(vblank_start, 2);
> @@ -206,7 +209,7 @@ void intel_pipe_update_end(struct intel_crtc_state *new_crtc_state)
>  	 * Would be slightly nice to just grab the vblank count and arm the
>  	 * event outside of the critical section - the spinlock might spin for a
>  	 * while ... */
> -	if (new_crtc_state->uapi.event) {
> +	if (new_crtc_state->uapi.event && !new_crtc_state->uapi.async_flip) {
>  		drm_WARN_ON(&dev_priv->drm,
>  			    drm_crtc_vblank_get(&crtc->base) != 0);
>  
> @@ -220,6 +223,9 @@ void intel_pipe_update_end(struct intel_crtc_state *new_crtc_state)
>  
>  	local_irq_enable();
>  
> +	if (new_crtc_state->uapi.async_flip)
> +		return;
> +
>  	if (intel_vgpu_active(dev_priv))
>  		return;
>  
> -- 
> 2.22.0

-- 
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-09-01 11:23 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07  9:35 [Intel-gfx] [PATCH v6 0/7] Asynchronous flip implementation for i915 Karthik B S
2020-08-07  9:35 ` Karthik B S
2020-08-07  9:35 ` [Intel-gfx] [PATCH v6 1/7] drm/i915: Add enable/disable flip done and flip done handler Karthik B S
2020-08-07  9:35   ` Karthik B S
2020-09-01 11:12   ` [Intel-gfx] " Ville Syrjälä
2020-09-01 11:12     ` Ville Syrjälä
2020-09-02 13:24     ` [Intel-gfx] " Karthik B S
2020-09-02 13:24       ` Karthik B S
2020-09-01 11:40   ` [Intel-gfx] " Ville Syrjälä
2020-09-01 11:40     ` Ville Syrjälä
2020-09-02 14:12     ` [Intel-gfx] " Karthik B S
2020-09-02 14:12       ` Karthik B S
2020-08-07  9:35 ` [Intel-gfx] [PATCH v6 2/7] drm/i915: Add support for async flips in I915 Karthik B S
2020-08-07  9:35   ` Karthik B S
2020-09-01 11:15   ` [Intel-gfx] " Ville Syrjälä
2020-09-01 11:15     ` Ville Syrjälä
2020-09-02 13:28     ` [Intel-gfx] " Karthik B S
2020-09-02 13:28       ` Karthik B S
2020-08-07  9:35 ` [Intel-gfx] [PATCH v6 3/7] drm/i915: Add checks specific to async flips Karthik B S
2020-08-07  9:35   ` Karthik B S
2020-09-01 11:21   ` [Intel-gfx] " Ville Syrjälä
2020-09-01 11:21     ` Ville Syrjälä
2020-09-02 13:44     ` [Intel-gfx] " Karthik B S
2020-09-02 13:44       ` Karthik B S
2020-08-07  9:35 ` [Intel-gfx] [PATCH v6 4/7] drm/i915: Do not call drm_crtc_arm_vblank_event in " Karthik B S
2020-08-07  9:35   ` Karthik B S
2020-09-01 11:23   ` Ville Syrjälä [this message]
2020-09-01 11:23     ` Ville Syrjälä
2020-09-02 13:47     ` [Intel-gfx] " Karthik B S
2020-09-02 13:47       ` Karthik B S
2020-08-07  9:35 ` [Intel-gfx] [PATCH v6 5/7] drm/i915: Add dedicated plane hook for async flip case Karthik B S
2020-08-07  9:35   ` Karthik B S
2020-09-01 11:27   ` [Intel-gfx] " Ville Syrjälä
2020-09-01 11:27     ` Ville Syrjälä
2020-09-02 13:52     ` [Intel-gfx] " Karthik B S
2020-09-02 13:52       ` Karthik B S
2020-08-07  9:35 ` [Intel-gfx] [PATCH v6 6/7] Documentation/gpu: Add asynchronous flip documentation for i915 Karthik B S
2020-08-07  9:35   ` Karthik B S
2020-08-07  9:35 ` [Intel-gfx] [PATCH v6 7/7] drm/i915: Enable async flips in i915 Karthik B S
2020-08-07  9:35   ` Karthik B S
2020-08-07 13:16 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Asynchronous flip implementation for i915 (rev6) Patchwork
2020-08-07 13:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-07 17:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200901112346.GI6112@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    --cc=michel@daenzer.net \
    --cc=nicholas.kazlauskas@amd.com \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.