* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1768 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: "Lars-Peter Clausen" <lars@metafoo.de>
CC: Michael Hennerich <Michael.Hennerich@analog.com>
CC: Jonathan Cameron <jic23@kernel.org>
CC: Hartmut Knaack <knaack.h@gmx.de>
CC: "Peter Meerwald-Stadler" <pmeerw@pmeerw.net>
CC: linux-iio(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
adi-axi-adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/iio/adc/adi-axi-adc.c
+++ b/drivers/iio/adc/adi-axi-adc.c
@@ -276,7 +276,7 @@ static struct attribute *adi_axi_adc_att
static umode_t axi_adc_attr_is_visible(struct kobject *kobj,
struct attribute *attr, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct adi_axi_adc_state *st = iio_priv(indio_dev);
struct adi_axi_adc_conv *conv = &st->client->conv;
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
2020-09-01 9:46 ` [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Alexandru Ardelean <alexandru.ardelean@analog.com>
CC: linux-input(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/input/touchscreen/ads7846.c:484:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
ads7846.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -481,7 +481,7 @@ SHOW(in1_input, vbatt, vbatt_adjust)
static umode_t ads7846_is_visible(struct kobject *kobj, struct attribute *attr,
int index)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct ads7846 *ts = dev_get_drvdata(dev);
if (ts->model == 7843 && index < 2) /* in0, in1 */
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
2020-09-01 9:46 ` [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings kernel test robot
2020-09-01 9:46 ` kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Rajat Jain <rajatja@google.com>
CC: "Gustavo A. R. Silva" <gustavoars@kernel.org>
CC: linux-input(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/input/keyboard/atkbd.c:327:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
atkbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -324,7 +324,7 @@ static ssize_t atkbd_show_function_row_p
static umode_t atkbd_attr_is_visible(struct kobject *kobj,
struct attribute *attr, int i)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct serio *serio = to_serio_port(dev);
struct atkbd *atkbd = serio_get_drvdata(serio);
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
` (2 preceding siblings ...)
2020-09-01 9:46 ` kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Dan Williams <dan.j.williams@intel.com>
CC: Vishal Verma <vishal.l.verma@intel.com>
CC: Dave Jiang <dave.jiang@intel.com>
CC: linux-nvdimm(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/dax/bus.c:334:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/dax/bus.c
+++ b/drivers/dax/bus.c
@@ -331,7 +331,7 @@ static DEVICE_ATTR_RO(numa_node);
static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct dev_dax *dev_dax = to_dev_dax(dev);
if (a == &dev_attr_target_node.attr && dev_dax_target_node(dev_dax) < 0)
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
` (3 preceding siblings ...)
2020-09-01 9:46 ` kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/nvmem/core.c:131:46-47: WARNING opportunity for kobj_to_dev()
drivers/nvmem/core.c:171:46-47: WARNING opportunity for kobj_to_dev()
drivers/nvmem/core.c:222:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -128,7 +128,7 @@ static ssize_t bin_attr_nvmem_read(struc
if (attr->private)
dev = attr->private;
else
- dev = container_of(kobj, struct device, kobj);
+ dev = kobj_to_dev(kobj);
nvmem = to_nvmem_device(dev);
/* Stop the user from reading */
@@ -168,7 +168,7 @@ static ssize_t bin_attr_nvmem_write(stru
if (attr->private)
dev = attr->private;
else
- dev = container_of(kobj, struct device, kobj);
+ dev = kobj_to_dev(kobj);
nvmem = to_nvmem_device(dev);
/* Stop the user from writing */
@@ -219,7 +219,7 @@ static umode_t nvmem_bin_attr_get_umode(
static umode_t nvmem_bin_attr_is_visible(struct kobject *kobj,
struct bin_attribute *attr, int i)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct nvmem_device *nvmem = to_nvmem_device(dev);
return nvmem_bin_attr_get_umode(nvmem);
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
` (4 preceding siblings ...)
2020-09-01 9:46 ` kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Sven Van Asbroeck <TheSven73@gmail.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: devel(a)driverdev.osuosl.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/staging/fieldbus/dev_core.c:137:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
dev_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/fieldbus/dev_core.c
+++ b/drivers/staging/fieldbus/dev_core.c
@@ -134,7 +134,7 @@ static struct attribute *fieldbus_attrs[
static umode_t fieldbus_is_visible(struct kobject *kobj, struct attribute *attr,
int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct fieldbus_dev *fb = dev_get_drvdata(dev);
umode_t mode = attr->mode;
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
` (5 preceding siblings ...)
2020-09-01 9:46 ` kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Sebastian Reichel <sre@kernel.org>
CC: linux-pm(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/power/supply/ds2760_battery.c:201:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
ds2760_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/power/supply/ds2760_battery.c
+++ b/drivers/power/supply/ds2760_battery.c
@@ -198,7 +198,7 @@ static ssize_t w1_slave_read(struct file
struct bin_attribute *bin_attr, char *buf,
loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
return w1_ds2760_read(dev, buf, off, count);
}
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
` (6 preceding siblings ...)
2020-09-01 9:46 ` kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2971 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Sebastian Reichel <sre@kernel.org>
CC: linux-pm(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/power/supply/ds2780_battery.c:627:60-61: WARNING opportunity for kobj_to_dev()
drivers/power/supply/ds2780_battery.c:672:60-61: WARNING opportunity for kobj_to_dev()
drivers/power/supply/ds2780_battery.c:640:60-61: WARNING opportunity for kobj_to_dev()
drivers/power/supply/ds2780_battery.c:685:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
ds2780_battery.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/power/supply/ds2780_battery.c
+++ b/drivers/power/supply/ds2780_battery.c
@@ -624,7 +624,7 @@ static ssize_t ds2780_read_param_eeprom_
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct power_supply *psy = to_power_supply(dev);
struct ds2780_device_info *dev_info = to_ds2780_device_info(psy);
@@ -637,7 +637,7 @@ static ssize_t ds2780_write_param_eeprom
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct power_supply *psy = to_power_supply(dev);
struct ds2780_device_info *dev_info = to_ds2780_device_info(psy);
int ret;
@@ -669,7 +669,7 @@ static ssize_t ds2780_read_user_eeprom_b
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct power_supply *psy = to_power_supply(dev);
struct ds2780_device_info *dev_info = to_ds2780_device_info(psy);
@@ -682,7 +682,7 @@ static ssize_t ds2780_write_user_eeprom_
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct power_supply *psy = to_power_supply(dev);
struct ds2780_device_info *dev_info = to_ds2780_device_info(psy);
int ret;
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
` (7 preceding siblings ...)
2020-09-01 9:46 ` kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Pavel Machek <pavel@ucw.cz>
CC: Dan Murphy <dmurphy@ti.com>
CC: linux-leds(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/leds/trigger/ledtrig-pattern.c:336:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
ledtrig-pattern.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/leds/trigger/ledtrig-pattern.c
+++ b/drivers/leds/trigger/ledtrig-pattern.c
@@ -333,7 +333,7 @@ static DEVICE_ATTR_RW(hw_pattern);
static umode_t pattern_trig_attrs_mode(struct kobject *kobj,
struct attribute *attr, int index)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct led_classdev *led_cdev = dev_get_drvdata(dev);
if (attr == &dev_attr_repeat.attr || attr == &dev_attr_pattern.attr)
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
` (8 preceding siblings ...)
2020-09-01 9:46 ` kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: linux-input(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/input/touchscreen/tsc200x-core.c:341:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
tsc200x-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/input/touchscreen/tsc200x-core.c
+++ b/drivers/input/touchscreen/tsc200x-core.c
@@ -338,7 +338,7 @@ static struct attribute *tsc200x_attrs[]
static umode_t tsc200x_attr_is_visible(struct kobject *kobj,
struct attribute *attr, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct tsc200x *ts = dev_get_drvdata(dev);
umode_t mode = attr->mode;
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
` (9 preceding siblings ...)
2020-09-01 9:46 ` kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
2020-09-01 9:46 ` kernel test robot
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Evgeniy Polyakov <zbr@ioremap.net>
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/w1/slaves/w1_ds2780.c:93:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
w1_ds2780.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/w1/slaves/w1_ds2780.c
+++ b/drivers/w1/slaves/w1_ds2780.c
@@ -90,7 +90,7 @@ static ssize_t w1_slave_read(struct file
struct bin_attribute *bin_attr, char *buf,
loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
return w1_ds2780_io(dev, buf, off, count, 0);
}
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
2020-09-01 9:46 [jlawall:for-5.10 3/4] drivers/iio/adc/adi-axi-adc.c:279:60-61: WARNING opportunity for kobj_to_dev() kernel test robot
` (10 preceding siblings ...)
2020-09-01 9:46 ` kernel test robot
@ 2020-09-01 9:46 ` kernel test robot
11 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2020-09-01 9:46 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Evgeniy Polyakov <zbr@ioremap.net>
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/w1/slaves/w1_ds2781.c:90:60-61: WARNING opportunity for kobj_to_dev()
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10
head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d
commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 3 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
w1_ds2781.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/w1/slaves/w1_ds2781.c
+++ b/drivers/w1/slaves/w1_ds2781.c
@@ -87,7 +87,7 @@ static ssize_t w1_slave_read(struct file
struct bin_attribute *bin_attr, char *buf,
loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
return w1_ds2781_io(dev, buf, off, count, 0);
}
^ permalink raw reply [flat|nested] 13+ messages in thread