From: Mike Snitzer <snitzer@redhat.com>
To: Coly Li <colyli@suse.de>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
linux-nvdimm@lists.01.org,
Vishal Verma <vishal.l.verma@intel.com>,
dm-devel@redhat.com, Jan Kara <jack@suse.com>,
Ira Weiny <ira.weiny@intel.com>
Subject: Re: flood of "dm-X: error: dax access failed" due to 5.9 commit 231609785cbfb
Date: Wed, 2 Sep 2020 12:51:01 -0400 [thread overview]
Message-ID: <20200902165101.GB5928@redhat.com> (raw)
In-Reply-To: <4968af50-663d-74cf-1be2-aaed48a380d5@suse.de>
On Wed, Sep 02 2020 at 12:46pm -0400,
Coly Li <colyli@suse.de> wrote:
> On 2020/9/3 00:44, Mike Snitzer wrote:
> > On Wed, Sep 02 2020 at 12:40pm -0400,
> > Coly Li <colyli@suse.de> wrote:
> >
> >> On 2020/9/3 00:04, Mike Snitzer wrote:
> >>> 5.9 commit 231609785cbfb ("dax: print error message by pr_info() in
> >>> __generic_fsdax_supported()") switched from pr_debug() to pr_info().
> >>>
> >>> The justification in the commit header is really inadequate. If there
> >>> is a problem that you need to drill in on, repeat the testing after
> >>> enabling the dynamic debugging.
> >>>
> >>> Otherwise, now all DM devices that aren't layered on DAX capable devices
> >>> spew really confusing noise to users when they simply activate their
> >>> non-DAX DM devices:
> >>>
> >>> [66567.129798] dm-6: error: dax access failed (-5)
> >>> [66567.134400] dm-6: error: dax access failed (-5)
> >>> [66567.139152] dm-6: error: dax access failed (-5)
> >>> [66567.314546] dm-2: error: dax access failed (-95)
> >>> [66567.319380] dm-2: error: dax access failed (-95)
> >>> [66567.324254] dm-2: error: dax access failed (-95)
> >>> [66567.479025] dm-2: error: dax access failed (-95)
> >>> [66567.483713] dm-2: error: dax access failed (-95)
> >>> [66567.488722] dm-2: error: dax access failed (-95)
> >>> [66567.494061] dm-2: error: dax access failed (-95)
> >>> [66567.498823] dm-2: error: dax access failed (-95)
> >>> [66567.503693] dm-2: error: dax access failed (-95)
> >>>
> >>> commit 231609785cbfb must be reverted.
> >>>
> >>> Please advise, thanks.
> >>
> >> Adrian Huang from Lenovo posted a patch, which titled: dax: do not print
> >> error message for non-persistent memory block device
> >>
> >> It fixes the issue, but no response for now. Maybe we should take this fix.
> >
> > OK, yes sounds like it. It was merged and is commit c2affe920b0e066
> > ("dax: do not print error message for non-persistent memory block
> > device")
>
> Thanks for informing me this patch is merged, I am going to update my
> local one :-)
So the thing is I'm running v5.9-rc3 (which includes this commit) but
I'm still seeing all these warnings when I run the lvm2 testsuite. The
reason _seems_ to be because the lvm2 testsuite uses brd devices for
test devices. So there is something about the brd device that shows
commit c2affe920b0e066 isn't enough :(
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Coly Li <colyli@suse.de>
Cc: Jan Kara <jack@suse.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
linux-nvdimm@lists.01.org, dm-devel@redhat.com
Subject: Re: flood of "dm-X: error: dax access failed" due to 5.9 commit 231609785cbfb
Date: Wed, 2 Sep 2020 12:51:01 -0400 [thread overview]
Message-ID: <20200902165101.GB5928@redhat.com> (raw)
In-Reply-To: <4968af50-663d-74cf-1be2-aaed48a380d5@suse.de>
On Wed, Sep 02 2020 at 12:46pm -0400,
Coly Li <colyli@suse.de> wrote:
> On 2020/9/3 00:44, Mike Snitzer wrote:
> > On Wed, Sep 02 2020 at 12:40pm -0400,
> > Coly Li <colyli@suse.de> wrote:
> >
> >> On 2020/9/3 00:04, Mike Snitzer wrote:
> >>> 5.9 commit 231609785cbfb ("dax: print error message by pr_info() in
> >>> __generic_fsdax_supported()") switched from pr_debug() to pr_info().
> >>>
> >>> The justification in the commit header is really inadequate. If there
> >>> is a problem that you need to drill in on, repeat the testing after
> >>> enabling the dynamic debugging.
> >>>
> >>> Otherwise, now all DM devices that aren't layered on DAX capable devices
> >>> spew really confusing noise to users when they simply activate their
> >>> non-DAX DM devices:
> >>>
> >>> [66567.129798] dm-6: error: dax access failed (-5)
> >>> [66567.134400] dm-6: error: dax access failed (-5)
> >>> [66567.139152] dm-6: error: dax access failed (-5)
> >>> [66567.314546] dm-2: error: dax access failed (-95)
> >>> [66567.319380] dm-2: error: dax access failed (-95)
> >>> [66567.324254] dm-2: error: dax access failed (-95)
> >>> [66567.479025] dm-2: error: dax access failed (-95)
> >>> [66567.483713] dm-2: error: dax access failed (-95)
> >>> [66567.488722] dm-2: error: dax access failed (-95)
> >>> [66567.494061] dm-2: error: dax access failed (-95)
> >>> [66567.498823] dm-2: error: dax access failed (-95)
> >>> [66567.503693] dm-2: error: dax access failed (-95)
> >>>
> >>> commit 231609785cbfb must be reverted.
> >>>
> >>> Please advise, thanks.
> >>
> >> Adrian Huang from Lenovo posted a patch, which titled: dax: do not print
> >> error message for non-persistent memory block device
> >>
> >> It fixes the issue, but no response for now. Maybe we should take this fix.
> >
> > OK, yes sounds like it. It was merged and is commit c2affe920b0e066
> > ("dax: do not print error message for non-persistent memory block
> > device")
>
> Thanks for informing me this patch is merged, I am going to update my
> local one :-)
So the thing is I'm running v5.9-rc3 (which includes this commit) but
I'm still seeing all these warnings when I run the lvm2 testsuite. The
reason _seems_ to be because the lvm2 testsuite uses brd devices for
test devices. So there is something about the brd device that shows
commit c2affe920b0e066 isn't enough :(
Mike
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-09-02 16:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 16:04 flood of "dm-X: error: dax access failed" due to 5.9 commit 231609785cbfb Mike Snitzer
2020-09-02 16:04 ` Mike Snitzer
2020-09-02 16:40 ` Coly Li
2020-09-02 16:40 ` Coly Li
2020-09-02 16:44 ` Mike Snitzer
2020-09-02 16:44 ` Mike Snitzer
2020-09-02 16:46 ` Coly Li
2020-09-02 16:46 ` Coly Li
2020-09-02 16:51 ` Mike Snitzer [this message]
2020-09-02 16:51 ` Mike Snitzer
2020-09-02 16:53 ` Coly Li
2020-09-02 16:53 ` Coly Li
2020-09-03 5:05 ` Coly Li
2020-09-03 5:05 ` Coly Li
2020-09-03 5:20 ` Coly Li
2020-09-03 8:37 ` Coly Li
2020-09-03 11:24 ` [External] " Adrian Huang12
2020-09-03 11:31 ` Coly Li
2020-09-03 11:09 ` Adrian Huang12
2020-09-03 11:24 ` Coly Li
2020-09-02 23:05 ` Verma, Vishal L
2020-09-02 23:05 ` Verma, Vishal L
2020-09-03 3:32 ` Coly Li
2020-09-03 3:32 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902165101.GB5928@redhat.com \
--to=snitzer@redhat.com \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.com \
--cc=linux-nvdimm@lists.01.org \
--cc=pankaj.gupta.linux@gmail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.